Linux-Next Archive on
 help / color / Atom feed
From: coverity-bot <>
To: Lyude Paul <>
Cc: Sean Paul <>,
	"Gustavo A. R. Silva" <>,
Subject: Coverity: drm_dp_mst_process_up_req(): Null pointer dereferences
Date: Mon, 4 Nov 2019 09:42:51 -0800
Message-ID: <201911040942.CA1A7EE8@keescook> (raw)


This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

9408cc94eb04 ("drm/dp_mst: Handle UP requests asynchronously")

Coverity reported the following:

*** CID 1487392:  Null pointer dereferences  (FORWARD_NULL)
/drivers/gpu/drm/drm_dp_mst_topology.c: 3710 in drm_dp_mst_process_up_req()
3705     		if (msg->req_type == DP_CONNECTION_STATUS_NOTIFY)
3706     			guid = msg->u.conn_stat.guid;
3707     		else if (msg->req_type == DP_RESOURCE_STATUS_NOTIFY)
3708     			guid = msg->u.resource_stat.guid;
vvv     CID 1487392:  Null pointer dereferences  (FORWARD_NULL)
vvv     Passing null pointer "guid" to "drm_dp_get_mst_branch_device_by_guid", which dereferences it.
3710     		mstb = drm_dp_get_mst_branch_device_by_guid(mgr, guid);
3711     	} else {
3712     		mstb = drm_dp_get_mst_branch_device(mgr, hdr->lct, hdr->rad);
3713     	}
3715     	if (!mstb) {

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <>
Addresses-Coverity-ID: 1487392 ("Null pointer dereferences")
Fixes: 9408cc94eb04 ("drm/dp_mst: Handle UP requests asynchronously")

Thanks for your attention!


                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201911040942.CA1A7EE8@keescook \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on

Archives are clonable:
	git clone --mirror linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ \
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone