Linux-Next Archive on
 help / color / Atom feed
* Coverity: perf_install_in_context(): Integer handling issues
@ 2019-11-04 17:43 coverity-bot
  0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2019-11-04 17:43 UTC (permalink / raw)
  To: Peter Zijlstra
  Cc: Peter Zijlstra, Andi Kleen, Ingo Molnar, Gustavo A. R. Silva, linux-next


This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

db0503e4f675 ("perf/core: Optimize perf_install_in_event()")

Coverity reported the following:

*** CID 711630:  Integer handling issues  (NEGATIVE_RETURNS)
/kernel/events/core.c: 2683 in perf_install_in_context()
2677     	if (__perf_effective_state(event) == PERF_EVENT_STATE_OFF && ctx->nr_events) {
2678     		raw_spin_lock_irq(&ctx->lock);
2679     		if (ctx->task == TASK_TOMBSTONE) {
2680     			raw_spin_unlock_irq(&ctx->lock);
2681     			return;
2682     		}
vvv     CID 711630:  Integer handling issues  (NEGATIVE_RETURNS)
vvv     "event->cpu" is passed to a parameter that cannot be negative.
2683     		add_event_to_ctx(event, ctx);
2684     		raw_spin_unlock_irq(&ctx->lock);
2685     		return;
2686     	}
2688     	if (!task) {

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <>
Addresses-Coverity-ID: 711630 ("Integer handling issues")
Fixes: db0503e4f675 ("perf/core: Optimize perf_install_in_event()")

Thanks for your attention!


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 17:43 Coverity: perf_install_in_context(): Integer handling issues coverity-bot

Linux-Next Archive on

Archives are clonable:
	git clone --mirror linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ \
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone