* linux-next: build warning after merge of the mlx5-next tree
@ 2019-11-05 2:07 Stephen Rothwell
2019-11-05 14:38 ` Leon Romanovsky
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2019-11-05 2:07 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Parav Pandit,
Saeed Mahameed
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
Hi all,
After merging the mlx5-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c: In function 'esw_vport_ingress_config':
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c:1356:2: warning: 'spec' may be used uninitialized in this function [-Wmaybe-uninitialized]
1356 | kvfree(spec);
| ^~~~~~~~~~~~
Introduced by commit
10652f39943e ("net/mlx5: Refactor ingress acl configuration")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warning after merge of the mlx5-next tree
2019-11-05 2:07 linux-next: build warning after merge of the mlx5-next tree Stephen Rothwell
@ 2019-11-05 14:38 ` Leon Romanovsky
0 siblings, 0 replies; 5+ messages in thread
From: Leon Romanovsky @ 2019-11-05 14:38 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Parav Pandit,
Saeed Mahameed
On Tue, Nov 05, 2019 at 01:07:28PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mlx5-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/eswitch.c: In function 'esw_vport_ingress_config':
> drivers/net/ethernet/mellanox/mlx5/core/eswitch.c:1356:2: warning: 'spec' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 1356 | kvfree(spec);
> | ^~~~~~~~~~~~
>
> Introduced by commit
>
> 10652f39943e ("net/mlx5: Refactor ingress acl configuration")
Thanks Stephen.
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warning after merge of the mlx5-next tree
2020-03-18 2:05 ` Stephen Rothwell
@ 2020-03-18 2:31 ` Saeed Mahameed
0 siblings, 0 replies; 5+ messages in thread
From: Saeed Mahameed @ 2020-03-18 2:31 UTC (permalink / raw)
To: sfr, Jason Gunthorpe, dledford; +Cc: linux-next, linux-kernel, leon
On Wed, 2020-03-18 at 13:05 +1100, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 16 Mar 2020 10:39:13 +1100 Stephen Rothwell <
> sfr@canb.auug.org.au> wrote:
> > Hi all,
> >
> > After merging the mlx5-next tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > In file included from include/linux/printk.h:331,
> > from include/linux/kernel.h:15,
> > from
> > drivers/net/ethernet/mellanox/mlx5/core/mr.c:33:
> > drivers/net/ethernet/mellanox/mlx5/core/mr.c: In function
> > 'mlx5_core_create_mkey':
> > include/linux/dynamic_debug.h:157:25: warning: 'key' may be used
> > uninitialized in this function [-Wmaybe-uninitialized]
> > 157 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
> > | ^~~~~~~~~~~~~~~~~
> > drivers/net/ethernet/mellanox/mlx5/core/mr.c:47:5: note: 'key' was
> > declared here
> > 47 | u8 key;
> > | ^~~
> >
> > Probably introduced by commit
> >
> > fc6a9f86f08a ("{IB,net}/mlx5: Assign mkey variant in mlx5_ib
> > only")
>
> This warning now appears in the rdma tree.
>
thanks Stephen,
actuall a fix patch was merged yesterday into mlx5-next [1]
and should already be in linux-next build, and will soon land in rdma
tree.
Thanks,
Saeed.
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/commit/?h=mlx5-next&id=826096d84f509d95ee8f72728fe19c44fbb9df6b
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warning after merge of the mlx5-next tree
2020-03-15 23:39 Stephen Rothwell
@ 2020-03-18 2:05 ` Stephen Rothwell
2020-03-18 2:31 ` Saeed Mahameed
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-03-18 2:05 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe
Cc: Leon Romanovsky, Linux Next Mailing List,
Linux Kernel Mailing List, Saeed Mahameed
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
Hi all,
On Mon, 16 Mar 2020 10:39:13 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the mlx5-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from include/linux/printk.h:331,
> from include/linux/kernel.h:15,
> from drivers/net/ethernet/mellanox/mlx5/core/mr.c:33:
> drivers/net/ethernet/mellanox/mlx5/core/mr.c: In function 'mlx5_core_create_mkey':
> include/linux/dynamic_debug.h:157:25: warning: 'key' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 157 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
> | ^~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/mr.c:47:5: note: 'key' was declared here
> 47 | u8 key;
> | ^~~
>
> Probably introduced by commit
>
> fc6a9f86f08a ("{IB,net}/mlx5: Assign mkey variant in mlx5_ib only")
This warning now appears in the rdma tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: build warning after merge of the mlx5-next tree
@ 2020-03-15 23:39 Stephen Rothwell
2020-03-18 2:05 ` Stephen Rothwell
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-03-15 23:39 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Saeed Mahameed
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
Hi all,
After merging the mlx5-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
In file included from include/linux/printk.h:331,
from include/linux/kernel.h:15,
from drivers/net/ethernet/mellanox/mlx5/core/mr.c:33:
drivers/net/ethernet/mellanox/mlx5/core/mr.c: In function 'mlx5_core_create_mkey':
include/linux/dynamic_debug.h:157:25: warning: 'key' may be used uninitialized in this function [-Wmaybe-uninitialized]
157 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/mr.c:47:5: note: 'key' was declared here
47 | u8 key;
| ^~~
Probably introduced by commit
fc6a9f86f08a ("{IB,net}/mlx5: Assign mkey variant in mlx5_ib only")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-18 2:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 2:07 linux-next: build warning after merge of the mlx5-next tree Stephen Rothwell
2019-11-05 14:38 ` Leon Romanovsky
2020-03-15 23:39 Stephen Rothwell
2020-03-18 2:05 ` Stephen Rothwell
2020-03-18 2:31 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).