From: Kees Cook <keescook@chromium.org>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Re: Coverity: meson_allocate_chanlist(): Uninitialized variables
Date: Tue, 5 Nov 2019 13:11:34 -0800 [thread overview]
Message-ID: <201911051311.6A783103F@keescook> (raw)
In-Reply-To: <20191105191644.GD16603@Red>
On Tue, Nov 05, 2019 at 08:16:44PM +0100, LABBE Corentin wrote:
> On Mon, Nov 04, 2019 at 09:39:49AM -0800, coverity-bot wrote:
> > Hello!
> >
> > This is an experimental automated report about issues detected by Coverity
> > from a scan of next-20191031 as part of the linux-next weekly scan project:
> > https://scan.coverity.com/projects/linux-next-weekly-scan
> >
> > You're getting this email because you were associated with the identified
> > lines of code (noted below) that were touched by recent commits:
> >
> > 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
> >
> > Coverity reported the following:
> >
> > *** CID 1487398: Uninitialized variables (UNINIT)
> > /drivers/crypto/amlogic/amlogic-gxl-core.c: 184 in meson_allocate_chanlist()
> > 178 goto error_engine;
> > 179 }
> > 180 }
> > 181 return 0;
> > 182 error_engine:
> > 183 meson_free_chanlist(mc, i);
> > vvv CID 1487398: Uninitialized variables (UNINIT)
> > vvv Using uninitialized value "err".
> > 184 return err;
> > 185 }
> > 186
> > 187 static int meson_register_algs(struct meson_dev *mc)
> > 188 {
> > 189 int err, i;
> >
> > If this is a false positive, please let us know so we can mark it as
> > such, or teach the Coverity rules to be smarter. If not, please make
> > sure fixes get into linux-next. :) For patches fixing this, please
> > include these lines (but double-check the "Fixes" first):
> >
> > Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> > Addresses-Coverity-ID: 1487398 ("Uninitialized variables")
> > Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
> >
> >
> > Thanks for your attention!
>
> Hello
>
> A patch was already posted for this issue ("[PATCH][next] crypto: amlogic: ensure error variable err is set before returning it")
Excellent, thank you! (And for the upcoming patches!)
--
Kees Cook
prev parent reply other threads:[~2019-11-05 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 17:39 Coverity: meson_allocate_chanlist(): Uninitialized variables coverity-bot
2019-11-05 19:16 ` LABBE Corentin
2019-11-05 21:11 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911051311.6A783103F@keescook \
--to=keescook@chromium.org \
--cc=clabbe@baylibre.com \
--cc=gustavo@embeddedor.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-next@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).