* Coverity: meson_cipher(): Resource leaks
@ 2019-11-04 17:37 coverity-bot
2019-11-05 19:08 ` LABBE Corentin
0 siblings, 1 reply; 2+ messages in thread
From: coverity-bot @ 2019-11-04 17:37 UTC (permalink / raw)
To: Corentin Labbe
Cc: Neil Armstrong, Herbert Xu, Gustavo A. R. Silva, linux-next
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
Coverity reported the following:
*** CID 1487401: Resource leaks (RESOURCE_LEAK)
/drivers/crypto/amlogic/amlogic-gxl-cipher.c: 134 in meson_cipher()
128 keyivlen = op->keylen;
129
130 ivsize = crypto_skcipher_ivsize(tfm);
131 if (areq->iv && ivsize > 0) {
132 if (ivsize > areq->cryptlen) {
133 dev_err(mc->dev, "invalid ivsize=%d vs len=%d\n", ivsize, areq->cryptlen);
vvv CID 1487401: Resource leaks (RESOURCE_LEAK)
vvv Variable "bkeyiv" going out of scope leaks the storage it points to.
134 return -EINVAL;
135 }
136 memcpy(bkeyiv + 32, areq->iv, ivsize);
137 keyivlen = 48;
138 if (rctx->op_dir == MESON_DECRYPT) {
139 backup_iv = kzalloc(ivsize, GFP_KERNEL);
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487401 ("Resource leaks")
Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
Thanks for your attention!
--
Coverity-bot
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Coverity: meson_cipher(): Resource leaks
2019-11-04 17:37 Coverity: meson_cipher(): Resource leaks coverity-bot
@ 2019-11-05 19:08 ` LABBE Corentin
0 siblings, 0 replies; 2+ messages in thread
From: LABBE Corentin @ 2019-11-05 19:08 UTC (permalink / raw)
To: coverity-bot; +Cc: Neil Armstrong, Herbert Xu, Gustavo A. R. Silva, linux-next
On Mon, Nov 04, 2019 at 09:37:58AM -0800, coverity-bot wrote:
> Hello!
>
> This is an experimental automated report about issues detected by Coverity
> from a scan of next-20191031 as part of the linux-next weekly scan project:
> https://scan.coverity.com/projects/linux-next-weekly-scan
>
> You're getting this email because you were associated with the identified
> lines of code (noted below) that were touched by recent commits:
>
> 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
>
> Coverity reported the following:
>
> *** CID 1487401: Resource leaks (RESOURCE_LEAK)
> /drivers/crypto/amlogic/amlogic-gxl-cipher.c: 134 in meson_cipher()
> 128 keyivlen = op->keylen;
> 129
> 130 ivsize = crypto_skcipher_ivsize(tfm);
> 131 if (areq->iv && ivsize > 0) {
> 132 if (ivsize > areq->cryptlen) {
> 133 dev_err(mc->dev, "invalid ivsize=%d vs len=%d\n", ivsize, areq->cryptlen);
> vvv CID 1487401: Resource leaks (RESOURCE_LEAK)
> vvv Variable "bkeyiv" going out of scope leaks the storage it points to.
> 134 return -EINVAL;
> 135 }
> 136 memcpy(bkeyiv + 32, areq->iv, ivsize);
> 137 keyivlen = 48;
> 138 if (rctx->op_dir == MESON_DECRYPT) {
> 139 backup_iv = kzalloc(ivsize, GFP_KERNEL);
>
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include these lines (but double-check the "Fixes" first):
>
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1487401 ("Resource leaks")
> Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
>
>
> Thanks for your attention!
>
Thanks for the report, I will send the fix soon.
Regards
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-05 19:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 17:37 Coverity: meson_cipher(): Resource leaks coverity-bot
2019-11-05 19:08 ` LABBE Corentin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).