From: coverity-bot <keescook@chromium.org>
To: Mikita Lipski <mikita.lipski@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
Lyude Paul <lyude@redhat.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: dm_encoder_helper_atomic_check(): Control flow issues
Date: Mon, 11 Nov 2019 17:36:03 -0800 [thread overview]
Message-ID: <201911111736.DC6A6DA8E8@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191108 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
5133c6241d9c ("drm/amd/display: Add MST atomic routines")
Coverity reported the following:
*** CID 1487838: Control flow issues (NO_EFFECT)
/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: 4869 in dm_encoder_helper_atomic_check()
4863 dm_new_connector_state->pbn = drm_dp_calc_pbn_mode(clock, bpp);
4864 }
4865 dm_new_connector_state->vcpi_slots = drm_dp_atomic_find_vcpi_slots(state,
4866 mst_mgr,
4867 mst_port,
4868 dm_new_connector_state->pbn);
vvv CID 1487838: Control flow issues (NO_EFFECT)
vvv This less-than-zero comparison of an unsigned value is never true. "dm_new_connector_state->vcpi_slots < 0ULL".
4869 if (dm_new_connector_state->vcpi_slots < 0) {
4870 DRM_DEBUG_ATOMIC("failed finding vcpi slots: %d\n", (int)dm_new_connector_state->vcpi_slots);
4871 return dm_new_connector_state->vcpi_slots;
4872 }
4873 return 0;
4874 }
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487838 ("Control flow issues")
Fixes: 5133c6241d9c ("drm/amd/display: Add MST atomic routines")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-11-12 1:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911111736.DC6A6DA8E8@keescook \
--to=keescook@chromium.org \
--cc=alexander.deucher@amd.com \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=mikita.lipski@amd.com \
--cc=nicholas.kazlauskas@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).