linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build warning after merge of the ftrace tree
@ 2019-11-15  3:02 Stephen Rothwell
  2019-11-15  3:43 ` Steven Rostedt
  0 siblings, 1 reply; 44+ messages in thread
From: Stephen Rothwell @ 2019-11-15  3:02 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Viktor Rosendahl (BMW), Joel Fernandes (Google)

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

Hi all,

After merging the ftrace tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from kernel/trace/trace.c:52:
kernel/trace/trace.h:804:13: warning: 'latency_fsnotify' defined but not used [-Wunused-function]
  804 | static void latency_fsnotify(struct trace_array *tr) { }
      |             ^~~~~~~~~~~~~~~~

Introduced by commit

  91edde2e6ae1 ("ftrace: Implement fs notification for tracing_max_latency")

"inline" missing :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2019-11-15  3:02 linux-next: build warning after merge of the ftrace tree Stephen Rothwell
@ 2019-11-15  3:43 ` Steven Rostedt
  0 siblings, 0 replies; 44+ messages in thread
From: Steven Rostedt @ 2019-11-15  3:43 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Viktor Rosendahl (BMW), Joel Fernandes (Google)

On Fri, 15 Nov 2019 14:02:13 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the ftrace tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from kernel/trace/trace.c:52:
> kernel/trace/trace.h:804:13: warning: 'latency_fsnotify' defined but not used [-Wunused-function]
>   804 | static void latency_fsnotify(struct trace_array *tr) { }
>       |             ^~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   91edde2e6ae1 ("ftrace: Implement fs notification for tracing_max_latency")
> 
> "inline" missing :-(
> 

Thanks for pointing that out, I'll go and fix this.


-- Steve



^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2023-06-23  4:35 Stephen Rothwell
@ 2023-06-23  6:53 ` Donglin Peng
  0 siblings, 0 replies; 44+ messages in thread
From: Donglin Peng @ 2023-06-23  6:53 UTC (permalink / raw)
  To: Stephen Rothwell, Steven Rostedt, Masami Hiramatsu
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

On 2023/6/23 12:35, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the ftrace tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/trace/ftrace.rst:2797: WARNING: Literal block expected; none found.
> Documentation/trace/ftrace.rst:2816: WARNING: Literal block expected; none found.
> 
> Introduced by commit
> 
>    21c094d3f8a6 ("tracing: Add documentation for funcgraph-retval and funcgraph-retval-hex")
> 

I am so sorry, and I will fix it right now.

^ permalink raw reply	[flat|nested] 44+ messages in thread

* linux-next: build warning after merge of the ftrace tree
@ 2023-06-23  4:35 Stephen Rothwell
  2023-06-23  6:53 ` Donglin Peng
  0 siblings, 1 reply; 44+ messages in thread
From: Stephen Rothwell @ 2023-06-23  4:35 UTC (permalink / raw)
  To: Steven Rostedt, Masami Hiramatsu
  Cc: Donglin Peng, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi all,

After merging the ftrace tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/trace/ftrace.rst:2797: WARNING: Literal block expected; none found.
Documentation/trace/ftrace.rst:2816: WARNING: Literal block expected; none found.

Introduced by commit

  21c094d3f8a6 ("tracing: Add documentation for funcgraph-retval and funcgraph-retval-hex")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* linux-next: build warning after merge of the ftrace tree
@ 2022-11-25  3:10 Stephen Rothwell
  0 siblings, 0 replies; 44+ messages in thread
From: Stephen Rothwell @ 2022-11-25  3:10 UTC (permalink / raw)
  To: Steven Rostedt, Masami Hiramatsu
  Cc: Daniel Bristot de Oliveira, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Hi all,

After merging the ftrace tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/trace/osnoise-tracer.rst:112: ERROR: Unknown target name: "no".

Introduced by commit

  67543cd6b8ee ("Documentation/osnoise: Add osnoise/options documentation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2021-10-28 21:29     ` Kalesh Singh
@ 2021-10-28 22:36       ` Stephen Rothwell
  0 siblings, 0 replies; 44+ messages in thread
From: Stephen Rothwell @ 2021-10-28 22:36 UTC (permalink / raw)
  To: Kalesh Singh
  Cc: Steven Rostedt, Mauro Carvalho Chehab, Linux Kernel Mailing List,
	Linux Next Mailing List, Jonathan Corbet

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

Hi Kalesh,

On Thu, 28 Oct 2021 14:29:47 -0700 Kalesh Singh <kaleshsingh@google.com> wrote:
>
> On Thu, Oct 28, 2021 at 2:10 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Thu, 28 Oct 2021 09:16:46 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:  
> > >
> > > On Thu, 28 Oct 2021 23:23:45 +1100
> > > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >  
> > > > After merging the ftrace tree, today's linux-next build (htmldocs)
> > > > produced this warning:
> > > >
> > > > Documentation/trace/histogram.rst:1766: WARNING: Inline emphasis start-string without end-string.  
> > >
> > > I have no idea what that means.  
> >
> > I assume you need to quote (with '\') the '*' on line 1767 (?).  
> 
> I also found the problem to be '*' character. I posted a fix at:
> https://lore.kernel.org/r/20211028170548.2597449-1-kaleshsingh@google.com/

Yeah, every now and then I forget to read all my email before replying :-)

Thanks.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2021-10-28 21:10   ` Stephen Rothwell
  2021-10-28 21:29     ` Kalesh Singh
@ 2021-10-28 21:30     ` Steven Rostedt
  1 sibling, 0 replies; 44+ messages in thread
From: Steven Rostedt @ 2021-10-28 21:30 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mauro Carvalho Chehab, Kalesh Singh, Linux Kernel Mailing List,
	Linux Next Mailing List, Jonathan Corbet

On Fri, 29 Oct 2021 08:10:09 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> > > Documentation/trace/histogram.rst:1766: WARNING: Inline emphasis start-string without end-string.    
> > 
> > I have no idea what that means.  
> 
> I assume you need to quote (with '\') the '*' on line 1767 (?).

Yeah, I figured that out when Kalesh sent me the patch to fix it ;-)

-- Steve

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2021-10-28 21:10   ` Stephen Rothwell
@ 2021-10-28 21:29     ` Kalesh Singh
  2021-10-28 22:36       ` Stephen Rothwell
  2021-10-28 21:30     ` Steven Rostedt
  1 sibling, 1 reply; 44+ messages in thread
From: Kalesh Singh @ 2021-10-28 21:29 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Steven Rostedt, Mauro Carvalho Chehab, Linux Kernel Mailing List,
	Linux Next Mailing List, Jonathan Corbet

On Thu, Oct 28, 2021 at 2:10 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Steven,
>
> On Thu, 28 Oct 2021 09:16:46 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Thu, 28 Oct 2021 23:23:45 +1100
> > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > > After merging the ftrace tree, today's linux-next build (htmldocs)
> > > produced this warning:
> > >
> > > Documentation/trace/histogram.rst:1766: WARNING: Inline emphasis start-string without end-string.
> >
> > I have no idea what that means.
>
> I assume you need to quote (with '\') the '*' on line 1767 (?).

Hi Stephen,

I also found the problem to be '*' character. I posted a fix at:
https://lore.kernel.org/r/20211028170548.2597449-1-kaleshsingh@google.com/

Thanks,
Kalesh

>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2021-10-28 13:16 ` Steven Rostedt
@ 2021-10-28 21:10   ` Stephen Rothwell
  2021-10-28 21:29     ` Kalesh Singh
  2021-10-28 21:30     ` Steven Rostedt
  0 siblings, 2 replies; 44+ messages in thread
From: Stephen Rothwell @ 2021-10-28 21:10 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Mauro Carvalho Chehab, Kalesh Singh, Linux Kernel Mailing List,
	Linux Next Mailing List, Jonathan Corbet

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

Hi Steven,

On Thu, 28 Oct 2021 09:16:46 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Thu, 28 Oct 2021 23:23:45 +1100
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > After merging the ftrace tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > Documentation/trace/histogram.rst:1766: WARNING: Inline emphasis start-string without end-string.  
> 
> I have no idea what that means.

I assume you need to quote (with '\') the '*' on line 1767 (?).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2021-10-28 12:23 Stephen Rothwell
@ 2021-10-28 13:16 ` Steven Rostedt
  2021-10-28 21:10   ` Stephen Rothwell
  0 siblings, 1 reply; 44+ messages in thread
From: Steven Rostedt @ 2021-10-28 13:16 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Kalesh Singh, Linux Kernel Mailing List, Linux Next Mailing List

On Thu, 28 Oct 2021 23:23:45 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the ftrace tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/trace/histogram.rst:1766: WARNING: Inline emphasis start-string without end-string.

I have no idea what that means.

-- Steve

> 
> Introduced by commit
> 
>   2d2f6d4b8ce7 ("tracing/histogram: Document expression arithmetic and constants")
> 


^ permalink raw reply	[flat|nested] 44+ messages in thread

* linux-next: build warning after merge of the ftrace tree
@ 2021-10-28 12:23 Stephen Rothwell
  2021-10-28 13:16 ` Steven Rostedt
  0 siblings, 1 reply; 44+ messages in thread
From: Stephen Rothwell @ 2021-10-28 12:23 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Kalesh Singh, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

Hi all,

After merging the ftrace tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/trace/histogram.rst:1766: WARNING: Inline emphasis start-string without end-string.

Introduced by commit

  2d2f6d4b8ce7 ("tracing/histogram: Document expression arithmetic and constants")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2021-10-25 23:35 Stephen Rothwell
@ 2021-10-26 12:15 ` Masami Hiramatsu
  0 siblings, 0 replies; 44+ messages in thread
From: Masami Hiramatsu @ 2021-10-26 12:15 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Steven Rostedt, Masami Hiramatsu, Linux Kernel Mailing List,
	Linux Next Mailing List

On Tue, 26 Oct 2021 10:35:53 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the ftrace tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> lib/bootconfig.c:78: warning: Function parameter or member 'node_size' not described in 'xbc_get_info'
> lib/bootconfig.c:78: warning: Function parameter or member 'data_size' not described in 'xbc_get_info'
> 
> Introduced by commit
> 
>   e306220cb7b7 ("bootconfig: Add xbc_get_info() for the node information")

Oops, thanks for reporting! I just missed '@' for those parameters...

Thank you,

> 
> -- 
> Cheers,
> Stephen Rothwell


-- 
Masami Hiramatsu <mhiramat@kernel.org>

^ permalink raw reply	[flat|nested] 44+ messages in thread

* linux-next: build warning after merge of the ftrace tree
@ 2021-10-25 23:35 Stephen Rothwell
  2021-10-26 12:15 ` Masami Hiramatsu
  0 siblings, 1 reply; 44+ messages in thread
From: Stephen Rothwell @ 2021-10-25 23:35 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Masami Hiramatsu, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Hi all,

After merging the ftrace tree, today's linux-next build (htmldocs)
produced this warning:

lib/bootconfig.c:78: warning: Function parameter or member 'node_size' not described in 'xbc_get_info'
lib/bootconfig.c:78: warning: Function parameter or member 'data_size' not described in 'xbc_get_info'

Introduced by commit

  e306220cb7b7 ("bootconfig: Add xbc_get_info() for the node information")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2021-10-25  4:39 Stephen Rothwell
@ 2021-10-25  6:13 ` Masami Hiramatsu
  0 siblings, 0 replies; 44+ messages in thread
From: Masami Hiramatsu @ 2021-10-25  6:13 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Steven Rostedt, Masami Hiramatsu, Linux Kernel Mailing List,
	Linux Next Mailing List

On Mon, 25 Oct 2021 15:39:42 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the ftrace tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> WARNING: modpost: vmlinux.o(.text.unlikely+0x90082): Section mismatch in reference from the function xbc_alloc_mem() to the function .init.text:memblock_alloc_try_nid()
> The function xbc_alloc_mem() references
> the function __init memblock_alloc_try_nid().
> This is often because xbc_alloc_mem lacks a __init 
> annotation or the annotation of memblock_alloc_try_nid is wrong.
> 
> Introduced by commit
> 
>   4ee1b4cac236 ("bootconfig: Cleanup dummy headers in tools/bootconfig")

Thanks for reporting!
Let me fix that.



> 
> -- 
> Cheers,
> Stephen Rothwell


-- 
Masami Hiramatsu <mhiramat@kernel.org>

^ permalink raw reply	[flat|nested] 44+ messages in thread

* linux-next: build warning after merge of the ftrace tree
@ 2021-10-25  4:39 Stephen Rothwell
  2021-10-25  6:13 ` Masami Hiramatsu
  0 siblings, 1 reply; 44+ messages in thread
From: Stephen Rothwell @ 2021-10-25  4:39 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Masami Hiramatsu, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

Hi all,

After merging the ftrace tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: vmlinux.o(.text.unlikely+0x90082): Section mismatch in reference from the function xbc_alloc_mem() to the function .init.text:memblock_alloc_try_nid()
The function xbc_alloc_mem() references
the function __init memblock_alloc_try_nid().
This is often because xbc_alloc_mem lacks a __init 
annotation or the annotation of memblock_alloc_try_nid is wrong.

Introduced by commit

  4ee1b4cac236 ("bootconfig: Cleanup dummy headers in tools/bootconfig")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2021-08-23 14:00 ` Steven Rostedt
@ 2021-08-24 10:53   ` Stephen Rothwell
  0 siblings, 0 replies; 44+ messages in thread
From: Stephen Rothwell @ 2021-08-24 10:53 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Hi Steven,

On Mon, 23 Aug 2021 10:00:07 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Does the below fix it?

Fixed it for me, thanks.

Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2021-08-23  9:58 Stephen Rothwell
@ 2021-08-23 14:00 ` Steven Rostedt
  2021-08-24 10:53   ` Stephen Rothwell
  0 siblings, 1 reply; 44+ messages in thread
From: Steven Rostedt @ 2021-08-23 14:00 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

On Mon, 23 Aug 2021 19:58:04 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the ftrace tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/trace/histogram.rst:80: WARNING: Malformed table.
> Text in column margin in table line 8.
> 
> =========== ==========================================
> .hex        display a number as a hex value
> .sym        display an address as a symbol
> .sym-offset display an address as a symbol and offset
> .syscall    display a syscall id as a system call name
> .execname   display a common_pid as a program name
> .log2       display log2 value rather than raw number
> .buckets=size  display grouping of values rather than raw number
> .usecs      display a common_timestamp in microseconds
> =========== ==========================================
> 
> Introduced by commit
> 
>   370364351926 ("tracing/histogram: Update the documentation for the buckets modifier")
> 

Hi Stephen,

Does the below fix it?

-- Steve

diff --git a/Documentation/trace/histogram.rst b/Documentation/trace/histogram.rst
index 4e650671f245..533415644c54 100644
--- a/Documentation/trace/histogram.rst
+++ b/Documentation/trace/histogram.rst
@@ -70,16 +70,16 @@ Documentation written by Tom Zanussi
   modified by appending any of the following modifiers to the field
   name:
 
-	=========== ==========================================
-        .hex        display a number as a hex value
-	.sym        display an address as a symbol
-	.sym-offset display an address as a symbol and offset
-	.syscall    display a syscall id as a system call name
-	.execname   display a common_pid as a program name
-	.log2       display log2 value rather than raw number
+	=============  =================================================
+        .hex           display a number as a hex value
+	.sym           display an address as a symbol
+	.sym-offset    display an address as a symbol and offset
+	.syscall       display a syscall id as a system call name
+	.execname      display a common_pid as a program name
+	.log2          display log2 value rather than raw number
 	.buckets=size  display grouping of values rather than raw number
-	.usecs      display a common_timestamp in microseconds
-	=========== ==========================================
+	.usecs         display a common_timestamp in microseconds
+	=============  =================================================
 
   Note that in general the semantics of a given field aren't
   interpreted when applying a modifier to it, but there are some

^ permalink raw reply related	[flat|nested] 44+ messages in thread

* linux-next: build warning after merge of the ftrace tree
@ 2021-08-23  9:58 Stephen Rothwell
  2021-08-23 14:00 ` Steven Rostedt
  0 siblings, 1 reply; 44+ messages in thread
From: Stephen Rothwell @ 2021-08-23  9:58 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

Hi all,

After merging the ftrace tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/trace/histogram.rst:80: WARNING: Malformed table.
Text in column margin in table line 8.

=========== ==========================================
.hex        display a number as a hex value
.sym        display an address as a symbol
.sym-offset display an address as a symbol and offset
.syscall    display a syscall id as a system call name
.execname   display a common_pid as a program name
.log2       display log2 value rather than raw number
.buckets=size  display grouping of values rather than raw number
.usecs      display a common_timestamp in microseconds
=========== ==========================================

Introduced by commit

  370364351926 ("tracing/histogram: Update the documentation for the buckets modifier")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2020-11-16 20:29       ` Jonathan Corbet
@ 2020-11-16 20:35         ` Steven Rostedt
  0 siblings, 0 replies; 44+ messages in thread
From: Steven Rostedt @ 2020-11-16 20:35 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: Stephen Rothwell, linux-doc, Linux Kernel Mailing List,
	Linux Next Mailing List

On Mon, 16 Nov 2020 13:29:29 -0700
Jonathan Corbet <corbet@lwn.net> wrote:

> > Would something like the below work? I think I fixed the other places with
> > issues and for consistency, replaced the ".. code-block:: c" with just "::"
> > usage throughout the file.  
> 
> That will work.  It will also have the effect of removing C syntax
> highlighting from the formatted output; that is fine with me, but others
> are more attached to it.

Is there a way to set a default highlighting to be C syntax?

Otherwise I'll just put it back and add the code-block statements back in,
even though there are those that will complain about the added mark up ;-)

-- Steve

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2020-11-16 20:25     ` Steven Rostedt
@ 2020-11-16 20:29       ` Jonathan Corbet
  2020-11-16 20:35         ` Steven Rostedt
  0 siblings, 1 reply; 44+ messages in thread
From: Jonathan Corbet @ 2020-11-16 20:29 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Stephen Rothwell, linux-doc, Linux Kernel Mailing List,
	Linux Next Mailing List

On Mon, 16 Nov 2020 15:25:52 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Mon, 16 Nov 2020 12:24:32 -0700
> Jonathan Corbet <corbet@lwn.net> wrote:
> 
> > The problem is those literal blocks.  The easiest fix will be to just use
> > the double-colon notation to indicate a literal block, so the paragraph
> > above would end with "...start your code with::".  Note that there's a few
> > of them to fix.  
> 
> Would something like the below work? I think I fixed the other places with
> issues and for consistency, replaced the ".. code-block:: c" with just "::"
> usage throughout the file.

That will work.  It will also have the effect of removing C syntax
highlighting from the formatted output; that is fine with me, but others
are more attached to it.

jon

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2020-11-16 19:24   ` Jonathan Corbet
@ 2020-11-16 20:25     ` Steven Rostedt
  2020-11-16 20:29       ` Jonathan Corbet
  0 siblings, 1 reply; 44+ messages in thread
From: Steven Rostedt @ 2020-11-16 20:25 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: Stephen Rothwell, linux-doc, Linux Kernel Mailing List,
	Linux Next Mailing List

On Mon, 16 Nov 2020 12:24:32 -0700
Jonathan Corbet <corbet@lwn.net> wrote:

> The problem is those literal blocks.  The easiest fix will be to just use
> the double-colon notation to indicate a literal block, so the paragraph
> above would end with "...start your code with::".  Note that there's a few
> of them to fix.

Would something like the below work? I think I fixed the other places with
issues and for consistency, replaced the ".. code-block:: c" with just "::"
usage throughout the file.

-- Steve

diff --git a/Documentation/trace/ftrace-uses.rst b/Documentation/trace/ftrace-uses.rst
index 5981d5691745..f21464538fa0 100644
--- a/Documentation/trace/ftrace-uses.rst
+++ b/Documentation/trace/ftrace-uses.rst
@@ -43,9 +43,7 @@ as well as what protections the callback will perform and not require
 ftrace to handle.
 
 There is only one field that is needed to be set when registering
-an ftrace_ops with ftrace:
-
-.. code-block:: c
+an ftrace_ops with ftrace::
 
  struct ftrace_ops ops = {
        .func			= my_callback_func,
@@ -82,9 +80,7 @@ may take some time to finish.
 The callback function
 =====================
 
-The prototype of the callback function is as follows (as of v4.14):
-
-.. code-block:: c
+The prototype of the callback function is as follows (as of v4.14)::
 
    void callback_func(unsigned long ip, unsigned long parent_ip,
                       struct ftrace_ops *op, struct pt_regs *regs);
@@ -114,7 +110,7 @@ Protect your callback
 As functions can be called from anywhere, and it is possible that a function
 called by a callback may also be traced, and call that same callback,
 recursion protection must be used. There are two helper functions that
-can help in this regard. If you start your code with:
+can help in this regard. If you start your code with::
 
 	int bit;
 
@@ -122,7 +118,7 @@ can help in this regard. If you start your code with:
 	if (bit < 0)
 		return;
 
-and end it with:
+and end it with::
 
 	ftrace_test_recursion_unlock(bit);
 
@@ -143,7 +139,7 @@ function call.
 If your callback accesses any data or critical section that requires RCU
 protection, it is best to make sure that RCU is "watching", otherwise
 that data or critical section will not be protected as expected. In this
-case add:
+case add::
 
 	if (!rcu_is_watching())
 		return;
@@ -249,9 +245,7 @@ match a specific pattern.
 
 See Filter Commands in :file:`Documentation/trace/ftrace.rst`.
 
-To just trace the schedule function:
-
-.. code-block:: c
+To just trace the schedule function::
 
    ret = ftrace_set_filter(&ops, "schedule", strlen("schedule"), 0);
 
@@ -259,17 +253,13 @@ To add more functions, call the ftrace_set_filter() more than once with the
 @reset parameter set to zero. To remove the current filter set and replace it
 with new functions defined by @buf, have @reset be non-zero.
 
-To remove all the filtered functions and trace all functions:
-
-.. code-block:: c
+To remove all the filtered functions and trace all functions::
 
    ret = ftrace_set_filter(&ops, NULL, 0, 1);
 
 
 Sometimes more than one function has the same name. To trace just a specific
-function in this case, ftrace_set_filter_ip() can be used.
-
-.. code-block:: c
+function in this case, ftrace_set_filter_ip() can be used::
 
    ret = ftrace_set_filter_ip(&ops, ip, 0, 0);
 
@@ -284,9 +274,7 @@ two lists are non-empty and contain the same functions, the callback will not
 be called by any function.
 
 An empty "notrace" list means to allow all functions defined by the filter
-to be traced.
-
-.. code-block:: c
+to be traced::
 
    int ftrace_set_notrace(struct ftrace_ops *ops, unsigned char *buf,
                           int len, int reset);
@@ -298,9 +286,7 @@ filter list, and this function does not modify the filter list.
 A non-zero @reset will clear the "notrace" list before adding functions
 that match @buf to it.
 
-Clearing the "notrace" list is the same as clearing the filter list
-
-.. code-block:: c
+Clearing the "notrace" list is the same as clearing the filter list::
 
   ret = ftrace_set_notrace(&ops, NULL, 0, 1);
 
@@ -311,9 +297,7 @@ has been registered.
 
 If a filter is in place, and the @reset is non-zero, and @buf contains a
 matching glob to functions, the switch will happen during the time of
-the ftrace_set_filter() call. At no time will all functions call the callback.
-
-.. code-block:: c
+the ftrace_set_filter() call. At no time will all functions call the callback::
 
    ftrace_set_filter(&ops, "schedule", strlen("schedule"), 1);
 
@@ -323,9 +307,7 @@ the ftrace_set_filter() call. At no time will all functions call the callback.
 
    ftrace_set_filter(&ops, "try_to_wake_up", strlen("try_to_wake_up"), 1);
 
-is not the same as:
-
-.. code-block:: c
+is not the same as::
 
    ftrace_set_filter(&ops, "schedule", strlen("schedule"), 1);
 

^ permalink raw reply related	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2020-11-16 17:43 ` Steven Rostedt
@ 2020-11-16 19:24   ` Jonathan Corbet
  2020-11-16 20:25     ` Steven Rostedt
  0 siblings, 1 reply; 44+ messages in thread
From: Jonathan Corbet @ 2020-11-16 19:24 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Stephen Rothwell, linux-doc, Linux Kernel Mailing List,
	Linux Next Mailing List

On Mon, 16 Nov 2020 12:43:38 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> > After merging the ftrace tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > Documentation/trace/ftrace-uses.rst:123: WARNING: Unexpected indentation.
> > 
> > Introduced by commit
> > 
> >   a25d036d939a ("ftrace: Reverse what the RECURSION flag means in the ftrace_ops")
> >   
> 
> I'm not good at rst markup. Not sure how to fix this.

Looking at the commit in question:

> +Protect your callback
> +=====================
> +
> +As functions can be called from anywhere, and it is possible that a function
> +called by a callback may also be traced, and call that same callback,
> +recursion protection must be used. There are two helper functions that
> +can help in this regard. If you start your code with:
> +
> +	int bit;
> +
> +	bit = ftrace_test_recursion_trylock();
> +	if (bit < 0)
> +		return;

The problem is those literal blocks.  The easiest fix will be to just use
the double-colon notation to indicate a literal block, so the paragraph
above would end with "...start your code with::".  Note that there's a few
of them to fix.

Thanks,

jon

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2020-11-16  6:35 Stephen Rothwell
@ 2020-11-16 17:43 ` Steven Rostedt
  2020-11-16 19:24   ` Jonathan Corbet
  0 siblings, 1 reply; 44+ messages in thread
From: Steven Rostedt @ 2020-11-16 17:43 UTC (permalink / raw)
  To: Stephen Rothwell, linux-doc
  Cc: Linux Kernel Mailing List, Linux Next Mailing List, Jonathan Corbet

On Mon, 16 Nov 2020 17:35:02 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the ftrace tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/trace/ftrace-uses.rst:123: WARNING: Unexpected indentation.
> 
> Introduced by commit
> 
>   a25d036d939a ("ftrace: Reverse what the RECURSION flag means in the ftrace_ops")
> 

I'm not good at rst markup. Not sure how to fix this.

Thanks,

-- Steve

^ permalink raw reply	[flat|nested] 44+ messages in thread

* linux-next: build warning after merge of the ftrace tree
@ 2020-11-16  6:35 Stephen Rothwell
  2020-11-16 17:43 ` Steven Rostedt
  0 siblings, 1 reply; 44+ messages in thread
From: Stephen Rothwell @ 2020-11-16  6:35 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hi all,

After merging the ftrace tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/trace/ftrace-uses.rst:123: WARNING: Unexpected indentation.

Introduced by commit

  a25d036d939a ("ftrace: Reverse what the RECURSION flag means in the ftrace_ops")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* linux-next: build warning after merge of the ftrace tree
@ 2020-08-05  4:21 Stephen Rothwell
  0 siblings, 0 replies; 44+ messages in thread
From: Stephen Rothwell @ 2020-08-05  4:21 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Muchun Song,
	Chengming Zhou, Masami Hiramatsu

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

Hi all,

After merging the ftrace tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

kernel/kprobes.c: In function 'kill_kprobe':
kernel/kprobes.c:1116:33: warning: statement with no effect [-Wunused-value]
 1116 | #define disarm_kprobe_ftrace(p) (-ENODEV)
      |                                 ^
kernel/kprobes.c:2154:3: note: in expansion of macro 'disarm_kprobe_ftrace'
 2154 |   disarm_kprobe_ftrace(p);
      |   ^~~~~~~~~~~~~~~~~~~~

Introduced by commit

  0cb2f1372baa ("kprobes: Fix NULL pointer dereference at kprobe_ftrace_handler")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  3:13                     ` Steven Rostedt
@ 2014-06-05  3:42                       ` Fengguang Wu
  0 siblings, 0 replies; 44+ messages in thread
From: Fengguang Wu @ 2014-06-05  3:42 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wed, Jun 04, 2014 at 11:13:51PM -0400, Steven Rostedt wrote:
> On Thu, 5 Jun 2014 11:03:34 +0800
> Fengguang Wu <fengguang.wu@intel.com> wrote:
> 
> > On Wed, Jun 04, 2014 at 10:36:24PM -0400, Steven Rostedt wrote:
> > > On Thu, 5 Jun 2014 10:14:57 +0800
> > > Fengguang Wu <fengguang.wu@intel.com> wrote:
> > > 
> > > > > I wonder if the "(Red Hat)" part is causing an issue. Can you send
> > > > > directly to my email "rostedt@goodmis.org" and strip the name part?
> > > > 
> > > > OK. I've committed the change. Let's see how well it will work.
> > > 
> > > OK, I never received an error message for my buggy commit I posted
> > > before you did this change. I fixed the buggy commit and added another
> > > bug. I'll now wait again to see if I get notified.
> > 
> > FYI, we got two error reports
> > 
> > [trace:test-wu-bot 28/29] kernel/trace/trace.c:6683:1: error: expected '; ' before '}' token
> > [trace:test-wu-bot 29/29] kernel/trace/trace.c:6701:9: error: 'x' undeclared
> > 
> > in
> > 
> > https://lists.01.org/pipermail/kbuild-all/2014-June/004839.html
> > https://lists.01.org/pipermail/kbuild-all/2014-June/004840.html
> > 
> 
> And I received no emails :-(

Those 2 emails has

        To: Steven Rostedt <rostedt@goodmis.org>

in the header.

> I wonder why it's failing. What changed since March? I can't think of
> anything on my end.

It could be changes in one of the SMTP servers. Who knows. The
simplest workaround may be to have another email address to receive
all reports to you.

Thanks,
Fengguang

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  3:03                   ` Fengguang Wu
@ 2014-06-05  3:13                     ` Steven Rostedt
  2014-06-05  3:42                       ` Fengguang Wu
  0 siblings, 1 reply; 44+ messages in thread
From: Steven Rostedt @ 2014-06-05  3:13 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thu, 5 Jun 2014 11:03:34 +0800
Fengguang Wu <fengguang.wu@intel.com> wrote:

> On Wed, Jun 04, 2014 at 10:36:24PM -0400, Steven Rostedt wrote:
> > On Thu, 5 Jun 2014 10:14:57 +0800
> > Fengguang Wu <fengguang.wu@intel.com> wrote:
> > 
> > > > I wonder if the "(Red Hat)" part is causing an issue. Can you send
> > > > directly to my email "rostedt@goodmis.org" and strip the name part?
> > > 
> > > OK. I've committed the change. Let's see how well it will work.
> > 
> > OK, I never received an error message for my buggy commit I posted
> > before you did this change. I fixed the buggy commit and added another
> > bug. I'll now wait again to see if I get notified.
> 
> FYI, we got two error reports
> 
> [trace:test-wu-bot 28/29] kernel/trace/trace.c:6683:1: error: expected '; ' before '}' token
> [trace:test-wu-bot 29/29] kernel/trace/trace.c:6701:9: error: 'x' undeclared
> 
> in
> 
> https://lists.01.org/pipermail/kbuild-all/2014-June/004839.html
> https://lists.01.org/pipermail/kbuild-all/2014-June/004840.html
> 

And I received no emails :-(

I wonder why it's failing. What changed since March? I can't think of
anything on my end.

-- Steve

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  2:36                 ` Steven Rostedt
  2014-06-05  2:50                   ` Fengguang Wu
@ 2014-06-05  3:03                   ` Fengguang Wu
  2014-06-05  3:13                     ` Steven Rostedt
  1 sibling, 1 reply; 44+ messages in thread
From: Fengguang Wu @ 2014-06-05  3:03 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wed, Jun 04, 2014 at 10:36:24PM -0400, Steven Rostedt wrote:
> On Thu, 5 Jun 2014 10:14:57 +0800
> Fengguang Wu <fengguang.wu@intel.com> wrote:
> 
> > > I wonder if the "(Red Hat)" part is causing an issue. Can you send
> > > directly to my email "rostedt@goodmis.org" and strip the name part?
> > 
> > OK. I've committed the change. Let's see how well it will work.
> 
> OK, I never received an error message for my buggy commit I posted
> before you did this change. I fixed the buggy commit and added another
> bug. I'll now wait again to see if I get notified.

FYI, we got two error reports

[trace:test-wu-bot 28/29] kernel/trace/trace.c:6683:1: error: expected '; ' before '}' token
[trace:test-wu-bot 29/29] kernel/trace/trace.c:6701:9: error: 'x' undeclared

in

https://lists.01.org/pipermail/kbuild-all/2014-June/004839.html
https://lists.01.org/pipermail/kbuild-all/2014-June/004840.html

Thanks,
Fengguang

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  2:36                 ` Steven Rostedt
@ 2014-06-05  2:50                   ` Fengguang Wu
  2014-06-05  3:03                   ` Fengguang Wu
  1 sibling, 0 replies; 44+ messages in thread
From: Fengguang Wu @ 2014-06-05  2:50 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wed, Jun 04, 2014 at 10:36:24PM -0400, Steven Rostedt wrote:
> On Thu, 5 Jun 2014 10:14:57 +0800
> Fengguang Wu <fengguang.wu@intel.com> wrote:
> 
> > > I wonder if the "(Red Hat)" part is causing an issue. Can you send
> > > directly to my email "rostedt@goodmis.org" and strip the name part?
> > 
> > OK. I've committed the change. Let's see how well it will work.
> 
> OK, I never received an error message for my buggy commit I posted
> before you did this change. I fixed the buggy commit and added another
> bug. I'll now wait again to see if I get notified.

Sorry we got something wrong and your first bad commit is not tested.
The new one is being tested now.

Thanks,
Fengguang

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  2:14               ` Fengguang Wu
  2014-06-05  2:36                 ` Steven Rostedt
  2014-06-05  2:38                 ` Steven Rostedt
@ 2014-06-05  2:46                 ` Steven Rostedt
  2 siblings, 0 replies; 44+ messages in thread
From: Steven Rostedt @ 2014-06-05  2:46 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thu, 5 Jun 2014 10:14:57 +0800
Fengguang Wu <fengguang.wu@intel.com> wrote:

> On Wed, Jun 04, 2014 at 09:39:32PM -0400, Steven Rostedt wrote:
> > On Thu, 5 Jun 2014 09:33:00 +0800
> > Fengguang Wu <fengguang.wu@intel.com> wrote:
> > 
> > 
> > > Here are the recent emails sent to you:
> > > 
> > >  439   F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but not used
> > >  446   F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no member named 'trampoline'
> > > 1207   F May 31 To Steven Rostedt (  43:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
> > > 1210   F May 31 To Steven Rostedt (  29:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct pointer types lacks a cast
> > 
> > I don't have any of those :-(

BTW, this is the last report I received from your build bot. Anything
after that has gone into limbo.

From: kbuild test robot <fengguang.wu@intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, kbuild-all@01.org
Subject: [drm-intel:for-linux-next 342/342] drivers/gpu/drm/i915/./i915_trace.h:246:22: error: 'dev' undeclared
Date: Wed, 19 Mar 2014 10:12:41 +0800
User-Agent: Heirloom mailx 12.5 6/20/10
Message-ID: <5328fd19.A1aXhOyyvL3I2gl3%fengguang.wu@intel.com>

I noticed that there was no "Red Hat" in that one.

-- Steve

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  2:38                 ` Steven Rostedt
@ 2014-06-05  2:44                   ` Fengguang Wu
  0 siblings, 0 replies; 44+ messages in thread
From: Fengguang Wu @ 2014-06-05  2:44 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wed, Jun 04, 2014 at 10:38:17PM -0400, Steven Rostedt wrote:
> On Thu, 5 Jun 2014 10:14:57 +0800
> Fengguang Wu <fengguang.wu@intel.com> wrote:
> 
> > On Wed, Jun 04, 2014 at 09:39:32PM -0400, Steven Rostedt wrote:
> > > On Thu, 5 Jun 2014 09:33:00 +0800
> > > Fengguang Wu <fengguang.wu@intel.com> wrote:
> > > 
> > > 
> > > > Here are the recent emails sent to you:
> > > > 
> > > >  439   F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but not used
> > > >  446   F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no member named 'trampoline'
> > > > 1207   F May 31 To Steven Rostedt (  43:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
> > > > 1210   F May 31 To Steven Rostedt (  29:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct pointer types lacks a cast
> > > 
> > > I don't have any of those :-(
> > 
> BTW, can you give me the links to those errors. I'd like to fix them.

Sure. Search "ftrace" in this page, and you'll get all the 4 reports:

https://lists.01.org/pipermail/kbuild-all/2014-May/date.html

Thanks,
Fengguang

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  2:14               ` Fengguang Wu
  2014-06-05  2:36                 ` Steven Rostedt
@ 2014-06-05  2:38                 ` Steven Rostedt
  2014-06-05  2:44                   ` Fengguang Wu
  2014-06-05  2:46                 ` Steven Rostedt
  2 siblings, 1 reply; 44+ messages in thread
From: Steven Rostedt @ 2014-06-05  2:38 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thu, 5 Jun 2014 10:14:57 +0800
Fengguang Wu <fengguang.wu@intel.com> wrote:

> On Wed, Jun 04, 2014 at 09:39:32PM -0400, Steven Rostedt wrote:
> > On Thu, 5 Jun 2014 09:33:00 +0800
> > Fengguang Wu <fengguang.wu@intel.com> wrote:
> > 
> > 
> > > Here are the recent emails sent to you:
> > > 
> > >  439   F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but not used
> > >  446   F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no member named 'trampoline'
> > > 1207   F May 31 To Steven Rostedt (  43:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
> > > 1210   F May 31 To Steven Rostedt (  29:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct pointer types lacks a cast
> > 
> > I don't have any of those :-(
> 
BTW, can you give me the links to those errors. I'd like to fix them.

Thanks,

-- Steve

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  2:14               ` Fengguang Wu
@ 2014-06-05  2:36                 ` Steven Rostedt
  2014-06-05  2:50                   ` Fengguang Wu
  2014-06-05  3:03                   ` Fengguang Wu
  2014-06-05  2:38                 ` Steven Rostedt
  2014-06-05  2:46                 ` Steven Rostedt
  2 siblings, 2 replies; 44+ messages in thread
From: Steven Rostedt @ 2014-06-05  2:36 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thu, 5 Jun 2014 10:14:57 +0800
Fengguang Wu <fengguang.wu@intel.com> wrote:

> > I wonder if the "(Red Hat)" part is causing an issue. Can you send
> > directly to my email "rostedt@goodmis.org" and strip the name part?
> 
> OK. I've committed the change. Let's see how well it will work.

OK, I never received an error message for my buggy commit I posted
before you did this change. I fixed the buggy commit and added another
bug. I'll now wait again to see if I get notified.

-- Steve

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  1:39             ` Steven Rostedt
@ 2014-06-05  2:14               ` Fengguang Wu
  2014-06-05  2:36                 ` Steven Rostedt
                                   ` (2 more replies)
  0 siblings, 3 replies; 44+ messages in thread
From: Fengguang Wu @ 2014-06-05  2:14 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wed, Jun 04, 2014 at 09:39:32PM -0400, Steven Rostedt wrote:
> On Thu, 5 Jun 2014 09:33:00 +0800
> Fengguang Wu <fengguang.wu@intel.com> wrote:
> 
> 
> > Here are the recent emails sent to you:
> > 
> >  439   F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but not used
> >  446   F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no member named 'trampoline'
> > 1207   F May 31 To Steven Rostedt (  43:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
> > 1210   F May 31 To Steven Rostedt (  29:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct pointer types lacks a cast
> 
> I don't have any of those :-(

Ah..

> > > I may add a bad commit to one of my branches and see if I get a
> > > response from you just to test it out. I really hope we can fix this
> > > because I've gotten someone dependent on your reports. :-/
> > 
> > Yes we need to fix it. The same lost email issue has happened for
> > someone else, which was fixed by changing the email address. I can
> > conveniently redirect reports to any other email addresses you have.
> 
> I wonder if the "(Red Hat)" part is causing an issue. Can you send
> directly to my email "rostedt@goodmis.org" and strip the name part?

OK. I've committed the change. Let's see how well it will work.

Thanks,
Fengguang

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  1:33           ` Fengguang Wu
@ 2014-06-05  1:39             ` Steven Rostedt
  2014-06-05  2:14               ` Fengguang Wu
  0 siblings, 1 reply; 44+ messages in thread
From: Steven Rostedt @ 2014-06-05  1:39 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thu, 5 Jun 2014 09:33:00 +0800
Fengguang Wu <fengguang.wu@intel.com> wrote:


> Here are the recent emails sent to you:
> 
>  439   F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but not used
>  446   F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no member named 'trampoline'
> 1207   F May 31 To Steven Rostedt (  43:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
> 1210   F May 31 To Steven Rostedt (  29:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct pointer types lacks a cast

I don't have any of those :-(

> 
> > I may add a bad commit to one of my branches and see if I get a
> > response from you just to test it out. I really hope we can fix this
> > because I've gotten someone dependent on your reports. :-/
> 
> Yes we need to fix it. The same lost email issue has happened for
> someone else, which was fixed by changing the email address. I can
> conveniently redirect reports to any other email addresses you have.

I wonder if the "(Red Hat)" part is causing an issue. Can you send
directly to my email "rostedt@goodmis.org" and strip the name part?

Thanks.

-- Steve

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  1:12         ` Steven Rostedt
  2014-06-05  1:20           ` Steven Rostedt
@ 2014-06-05  1:33           ` Fengguang Wu
  2014-06-05  1:39             ` Steven Rostedt
  1 sibling, 1 reply; 44+ messages in thread
From: Fengguang Wu @ 2014-06-05  1:33 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wed, Jun 04, 2014 at 09:12:02PM -0400, Steven Rostedt wrote:
> On Thu, 5 Jun 2014 09:03:53 +0800
> Fengguang Wu <fengguang.wu@intel.com> wrote:
>
> > > Was I Cc'd? I don't have that in my inbox, nor do I see it in any of my
> > > spam filters.
> >
> > Yes, here is the email message:
> >
> >         Date: Sat, 31 May 2014 02:16:43 +0800
> >         From: kbuild test robot <fengguang.wu@intel.com>
> > ==>     To: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
>
> Hmm, I wonder where it ended up? I do have a pretty complex procmailrc
> file, but I even checked the procmail log file, and it doesn't show it.
>
> I don't think my email provider dropped it, as I have all the spam
> filtering turned off and do my own filtering. Although, they may have
> added something behind my back. Wouldn't be the first time.
>
> Are you sure that got sent?

I have no supporting log to check whether the emails are actually sent
to you.  All I have is the list of emails that were sent, and these
emails do have the TO: field to you.

> Can you check if your bots have triggered anything else for me. Because
> your bots have been surprisingly quiet lately. I just took that as me
> getting better at not pushing crap.

Here are the recent emails sent to you:

 439   F May 10 To Steven Rostedt (4440:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:108:27: warning: 'removed_ops' defined but not used
 446   F May 10 To Steven Rostedt (3531:1) [trace:ftrace/next-3.17 29/29] kernel/trace/ftrace.c:5358:12: error: 'struct ftrace_ops' has no member named 'trampoline'
1207   F May 31 To Steven Rostedt (  43:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
1210   F May 31 To Steven Rostedt (  29:0) [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct pointer types lacks a cast

> I may add a bad commit to one of my branches and see if I get a
> response from you just to test it out. I really hope we can fix this
> because I've gotten someone dependent on your reports. :-/

Yes we need to fix it. The same lost email issue has happened for
someone else, which was fixed by changing the email address. I can
conveniently redirect reports to any other email addresses you have.

Thanks,
Fengguang

>
> -- Steve
>
>
> >         CC: kbuild-all@01.org
> >         Subject: [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
> >         User-Agent: Heirloom mailx 12.5 6/20/10
> >
> >         tree:   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git ftrace/core
> >         head:   4c27e756bc019ec1c11232893af036fdae720a97
> >         commit: 81dc9f0ef21e40114cc895894c7acf3055f6d1fb [29/32] tracing: Add tracepoint benchmark tracepoint
> >         config: make ARCH=x86_64 allmodconfig
> >
> >         All warnings:
> >
> >            kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
> >         >> kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' [-Wunused-variable]
> >              u64 seedsq;
> >                  ^
> > Thanks,
> > Fengguang

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  1:12         ` Steven Rostedt
@ 2014-06-05  1:20           ` Steven Rostedt
  2014-06-05  1:33           ` Fengguang Wu
  1 sibling, 0 replies; 44+ messages in thread
From: Steven Rostedt @ 2014-06-05  1:20 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Fengguang Wu, Stephen Rothwell, linux-next, linux-kernel

On Wed, 4 Jun 2014 21:12:02 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:


> I may add a bad commit to one of my branches and see if I get a
> response from you just to test it out. I really hope we can fix this
> because I've gotten someone dependent on your reports. :-/

I did just this. I created a branch called test-wu-bot and added a
commit that removed a semicolon. I pushed it up to kernel.org. Now I'll
just sit back to see if it reports a build failure.

Thanks,

-- Steve

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  1:03       ` Fengguang Wu
@ 2014-06-05  1:12         ` Steven Rostedt
  2014-06-05  1:20           ` Steven Rostedt
  2014-06-05  1:33           ` Fengguang Wu
  0 siblings, 2 replies; 44+ messages in thread
From: Steven Rostedt @ 2014-06-05  1:12 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thu, 5 Jun 2014 09:03:53 +0800
Fengguang Wu <fengguang.wu@intel.com> wrote:

> > Was I Cc'd? I don't have that in my inbox, nor do I see it in any of my
> > spam filters.
> 
> Yes, here is the email message:
> 
>         Date: Sat, 31 May 2014 02:16:43 +0800
>         From: kbuild test robot <fengguang.wu@intel.com>
> ==>     To: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>

Hmm, I wonder where it ended up? I do have a pretty complex procmailrc
file, but I even checked the procmail log file, and it doesn't show it.

I don't think my email provider dropped it, as I have all the spam
filtering turned off and do my own filtering. Although, they may have
added something behind my back. Wouldn't be the first time.

Are you sure that got sent?

Can you check if your bots have triggered anything else for me. Because
your bots have been surprisingly quiet lately. I just took that as me
getting better at not pushing crap.

I may add a bad commit to one of my branches and see if I get a
response from you just to test it out. I really hope we can fix this
because I've gotten someone dependent on your reports. :-/


-- Steve


>         CC: kbuild-all@01.org
>         Subject: [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
>         User-Agent: Heirloom mailx 12.5 6/20/10
> 
>         tree:   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git ftrace/core
>         head:   4c27e756bc019ec1c11232893af036fdae720a97
>         commit: 81dc9f0ef21e40114cc895894c7acf3055f6d1fb [29/32] tracing: Add tracepoint benchmark tracepoint
>         config: make ARCH=x86_64 allmodconfig
> 
>         All warnings:
> 
>            kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
>         >> kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' [-Wunused-variable]
>              u64 seedsq;                                                                             
>                  ^
> Thanks,
> Fengguang

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  1:00     ` Steven Rostedt
@ 2014-06-05  1:03       ` Fengguang Wu
  2014-06-05  1:12         ` Steven Rostedt
  0 siblings, 1 reply; 44+ messages in thread
From: Fengguang Wu @ 2014-06-05  1:03 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wed, Jun 04, 2014 at 09:00:16PM -0400, Steven Rostedt wrote:
> On Thu, 5 Jun 2014 08:20:12 +0800
> Fengguang Wu <fengguang.wu@intel.com> wrote:
> 
> > On Wed, Jun 04, 2014 at 12:26:12PM -0400, Steven Rostedt wrote:
> > > On Wed, 4 Jun 2014 16:09:21 +1000
> > > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > 
> > > > Hi Steven,
> > > > 
> > > > After merging the ftrace tree, today's linux-next build (x86_64 allmodconfig)
> > > > produced this warning:
> > > > 
> > > > kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
> > > > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' [-Wunused-variable]
> > > >   u64 seedsq;
> > > >       ^
> > > > 
> > > > Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark tracepoint").
> > > 
> > > Hmm, I don't know why my tests missed this. I do a allmodconfig looking
> > > for new warning messages too. Oh, but I do need to add this config to my
> > > regular testing config :-/
> > > 
> > > I'm surprised Wu's bot didn't report it either.
> > 
> > Steven, it was reported, here is the email archive:
> > 
> > https://lists.01.org/pipermail/kbuild-all/2014-May/004749.html
> 
> Was I Cc'd? I don't have that in my inbox, nor do I see it in any of my
> spam filters.

Yes, here is the email message:

        Date: Sat, 31 May 2014 02:16:43 +0800
        From: kbuild test robot <fengguang.wu@intel.com>
==>     To: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
        CC: kbuild-all@01.org
        Subject: [trace:ftrace/core 29/32] kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq'
        User-Agent: Heirloom mailx 12.5 6/20/10

        tree:   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git ftrace/core
        head:   4c27e756bc019ec1c11232893af036fdae720a97
        commit: 81dc9f0ef21e40114cc895894c7acf3055f6d1fb [29/32] tracing: Add tracepoint benchmark tracepoint
        config: make ARCH=x86_64 allmodconfig

        All warnings:

           kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
        >> kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' [-Wunused-variable]
             u64 seedsq;                                                                             
                 ^
Thanks,
Fengguang

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-05  0:20   ` Fengguang Wu
@ 2014-06-05  1:00     ` Steven Rostedt
  2014-06-05  1:03       ` Fengguang Wu
  0 siblings, 1 reply; 44+ messages in thread
From: Steven Rostedt @ 2014-06-05  1:00 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thu, 5 Jun 2014 08:20:12 +0800
Fengguang Wu <fengguang.wu@intel.com> wrote:

> On Wed, Jun 04, 2014 at 12:26:12PM -0400, Steven Rostedt wrote:
> > On Wed, 4 Jun 2014 16:09:21 +1000
> > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > > Hi Steven,
> > > 
> > > After merging the ftrace tree, today's linux-next build (x86_64 allmodconfig)
> > > produced this warning:
> > > 
> > > kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
> > > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' [-Wunused-variable]
> > >   u64 seedsq;
> > >       ^
> > > 
> > > Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark tracepoint").
> > 
> > Hmm, I don't know why my tests missed this. I do a allmodconfig looking
> > for new warning messages too. Oh, but I do need to add this config to my
> > regular testing config :-/
> > 
> > I'm surprised Wu's bot didn't report it either.
> 
> Steven, it was reported, here is the email archive:
> 
> https://lists.01.org/pipermail/kbuild-all/2014-May/004749.html

Was I Cc'd? I don't have that in my inbox, nor do I see it in any of my
spam filters.

-- Steve

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-04 16:26 ` Steven Rostedt
  2014-06-04 16:49   ` Stephen Rothwell
@ 2014-06-05  0:20   ` Fengguang Wu
  2014-06-05  1:00     ` Steven Rostedt
  1 sibling, 1 reply; 44+ messages in thread
From: Fengguang Wu @ 2014-06-05  0:20 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wed, Jun 04, 2014 at 12:26:12PM -0400, Steven Rostedt wrote:
> On Wed, 4 Jun 2014 16:09:21 +1000
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi Steven,
> > 
> > After merging the ftrace tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
> > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' [-Wunused-variable]
> >   u64 seedsq;
> >       ^
> > 
> > Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark tracepoint").
> 
> Hmm, I don't know why my tests missed this. I do a allmodconfig looking
> for new warning messages too. Oh, but I do need to add this config to my
> regular testing config :-/
> 
> I'm surprised Wu's bot didn't report it either.

Steven, it was reported, here is the email archive:

https://lists.01.org/pipermail/kbuild-all/2014-May/004749.html

Thanks,
Fengguang

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-04 16:26 ` Steven Rostedt
@ 2014-06-04 16:49   ` Stephen Rothwell
  2014-06-05  0:20   ` Fengguang Wu
  1 sibling, 0 replies; 44+ messages in thread
From: Stephen Rothwell @ 2014-06-04 16:49 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: linux-next, linux-kernel, Fengguang Wu

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

Hi Steve,

On Wed, 4 Jun 2014 12:26:12 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed, 4 Jun 2014 16:09:21 +1000
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > After merging the ftrace tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
> > kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' [-Wunused-variable]
> >   u64 seedsq;
> >       ^
> > 
> > Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark tracepoint").
> 
> Hmm, I don't know why my tests missed this. I do a allmodconfig looking
> for new warning messages too. Oh, but I do need to add this config to my
> regular testing config :-/
> 
> I'm surprised Wu's bot didn't report it either.
> 
> I'm not going to rebase, but I'll add a patch to nuke it.

Correct behaviour!  :-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

* Re: linux-next: build warning after merge of the ftrace tree
  2014-06-04  6:09 Stephen Rothwell
@ 2014-06-04 16:26 ` Steven Rostedt
  2014-06-04 16:49   ` Stephen Rothwell
  2014-06-05  0:20   ` Fengguang Wu
  0 siblings, 2 replies; 44+ messages in thread
From: Steven Rostedt @ 2014-06-04 16:26 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Fengguang Wu

On Wed, 4 Jun 2014 16:09:21 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Steven,
> 
> After merging the ftrace tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
> kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' [-Wunused-variable]
>   u64 seedsq;
>       ^
> 
> Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark tracepoint").

Hmm, I don't know why my tests missed this. I do a allmodconfig looking
for new warning messages too. Oh, but I do need to add this config to my
regular testing config :-/

I'm surprised Wu's bot didn't report it either.

I'm not going to rebase, but I'll add a patch to nuke it.

Thanks!

-- Steve

^ permalink raw reply	[flat|nested] 44+ messages in thread

* linux-next: build warning after merge of the ftrace tree
@ 2014-06-04  6:09 Stephen Rothwell
  2014-06-04 16:26 ` Steven Rostedt
  0 siblings, 1 reply; 44+ messages in thread
From: Stephen Rothwell @ 2014-06-04  6:09 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hi Steven,

After merging the ftrace tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' [-Wunused-variable]
  u64 seedsq;
      ^

Introduced by commit 81dc9f0ef21e ("tracing: Add tracepoint benchmark tracepoint").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread

end of thread, other threads:[~2023-06-23  7:05 UTC | newest]

Thread overview: 44+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15  3:02 linux-next: build warning after merge of the ftrace tree Stephen Rothwell
2019-11-15  3:43 ` Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2023-06-23  4:35 Stephen Rothwell
2023-06-23  6:53 ` Donglin Peng
2022-11-25  3:10 Stephen Rothwell
2021-10-28 12:23 Stephen Rothwell
2021-10-28 13:16 ` Steven Rostedt
2021-10-28 21:10   ` Stephen Rothwell
2021-10-28 21:29     ` Kalesh Singh
2021-10-28 22:36       ` Stephen Rothwell
2021-10-28 21:30     ` Steven Rostedt
2021-10-25 23:35 Stephen Rothwell
2021-10-26 12:15 ` Masami Hiramatsu
2021-10-25  4:39 Stephen Rothwell
2021-10-25  6:13 ` Masami Hiramatsu
2021-08-23  9:58 Stephen Rothwell
2021-08-23 14:00 ` Steven Rostedt
2021-08-24 10:53   ` Stephen Rothwell
2020-11-16  6:35 Stephen Rothwell
2020-11-16 17:43 ` Steven Rostedt
2020-11-16 19:24   ` Jonathan Corbet
2020-11-16 20:25     ` Steven Rostedt
2020-11-16 20:29       ` Jonathan Corbet
2020-11-16 20:35         ` Steven Rostedt
2020-08-05  4:21 Stephen Rothwell
2014-06-04  6:09 Stephen Rothwell
2014-06-04 16:26 ` Steven Rostedt
2014-06-04 16:49   ` Stephen Rothwell
2014-06-05  0:20   ` Fengguang Wu
2014-06-05  1:00     ` Steven Rostedt
2014-06-05  1:03       ` Fengguang Wu
2014-06-05  1:12         ` Steven Rostedt
2014-06-05  1:20           ` Steven Rostedt
2014-06-05  1:33           ` Fengguang Wu
2014-06-05  1:39             ` Steven Rostedt
2014-06-05  2:14               ` Fengguang Wu
2014-06-05  2:36                 ` Steven Rostedt
2014-06-05  2:50                   ` Fengguang Wu
2014-06-05  3:03                   ` Fengguang Wu
2014-06-05  3:13                     ` Steven Rostedt
2014-06-05  3:42                       ` Fengguang Wu
2014-06-05  2:38                 ` Steven Rostedt
2014-06-05  2:44                   ` Fengguang Wu
2014-06-05  2:46                 ` Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).