Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the crypto tree
@ 2019-11-15 23:19 Stephen Rothwell
  2019-11-18  7:58 ` Pascal Van Leeuwen
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2019-11-15 23:19 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Pascal van Leeuwen

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi all,

In commit

  8c2c43a5be3d ("crypto: inside-secure - Fixed authenc w/ (3)DES fails on Macchiatobin")

Fixes tag

  Fixes: 13a1bb93f7b1c9 ("crypto: inside-secure - Fixed warnings on

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: linux-next: Fixes tag needs some work in the crypto tree
  2019-11-15 23:19 linux-next: Fixes tag needs some work in the crypto tree Stephen Rothwell
@ 2019-11-18  7:58 ` Pascal Van Leeuwen
  2019-11-18  8:12   ` Stephen Rothwell
  0 siblings, 1 reply; 10+ messages in thread
From: Pascal Van Leeuwen @ 2019-11-18  7:58 UTC (permalink / raw)
  To: Stephen Rothwell, Herbert Xu, Linux Crypto List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

Stephen, Herbert,

My bad, I didn't know the Fixes tag should not be broken over
lines (and that rather conflicted with the 75 characters per
line rule here, which is why I did break it up).

I'm willing to fix that - except that I don't know how to create
a patch that _only_ fixes the commit description of something 
already pulled into the cryptodev tree?

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.org> On Behalf Of
> Stephen Rothwell
> Sent: Saturday, November 16, 2019 12:20 AM
> To: Herbert Xu <herbert@gondor.apana.org.au>; Linux Crypto List <linux-crypto@vger.kernel.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Pascal van Leeuwen <pascalvanl@gmail.com>
> Subject: linux-next: Fixes tag needs some work in the crypto tree
> 
> Hi all,
> 
> In commit
> 
>   8c2c43a5be3d ("crypto: inside-secure - Fixed authenc w/ (3)DES fails on Macchiatobin")
> 
> Fixes tag
> 
>   Fixes: 13a1bb93f7b1c9 ("crypto: inside-secure - Fixed warnings on
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.
> 
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: Fixes tag needs some work in the crypto tree
  2019-11-18  7:58 ` Pascal Van Leeuwen
@ 2019-11-18  8:12   ` Stephen Rothwell
  2019-11-18 13:04     ` Herbert Xu
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2019-11-18  8:12 UTC (permalink / raw)
  To: Pascal Van Leeuwen
  Cc: Herbert Xu, Linux Crypto List, Linux Next Mailing List,
	Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

Hi Pascal,

On Mon, 18 Nov 2019 07:58:42 +0000 Pascal Van Leeuwen <pvanleeuwen@verimatrix.com> wrote:
>
> My bad, I didn't know the Fixes tag should not be broken over
> lines (and that rather conflicted with the 75 characters per
> line rule here, which is why I did break it up).
> 
> I'm willing to fix that - except that I don't know how to create
> a patch that _only_ fixes the commit description of something 
> already pulled into the cryptodev tree?

Unless Herbert wants to rebase the crypto tree (and I think this is not
a good reason to do that), you should just consider this a learning
experience. :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: Fixes tag needs some work in the crypto tree
  2019-11-18  8:12   ` Stephen Rothwell
@ 2019-11-18 13:04     ` Herbert Xu
  0 siblings, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2019-11-18 13:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Pascal Van Leeuwen, Linux Crypto List, Linux Next Mailing List,
	Linux Kernel Mailing List

On Mon, Nov 18, 2019 at 07:12:23PM +1100, Stephen Rothwell wrote:
> 
> Unless Herbert wants to rebase the crypto tree (and I think this is not
> a good reason to do that), you should just consider this a learning
> experience. :-)

Right.  It just so happens that I screwed up one of the patches
applied prior to the one in question so I had to rebase the tree.
The problem should now be fixed.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Fixes tag needs some work in the crypto tree
@ 2019-12-11 20:37 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2019-12-11 20:37 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Iuliana Prodan

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

Hi all,

In commit

  7278fa25aa0e ("crypto: caam - do not reset pointer size from MCFGR register")

Fixes tag

  Fixes: a1cf573ee95 ("crypto: caam - select DMA address size at runtime")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Fixes tag needs some work in the crypto tree
@ 2019-08-02  6:02 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2019-08-02  6:02 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Alexander Sverdlin

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

Hi all,

In commit

  1b82feb6c5e1 ("crypto: qat - Silence smp_processor_id() warning")

Fixes tag

  Fixes: ed8ccaef52 ("crypto: qat - Add support for SRIOV")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: Fixes tag needs some work in the crypto tree
  2019-04-22 21:30 Stephen Rothwell
@ 2019-04-23  4:08 ` Herbert Xu
  0 siblings, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2019-04-23  4:08 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Brijesh Singh

On Tue, Apr 23, 2019 at 07:30:36AM +1000, Stephen Rothwell wrote:
> 
> In commit
> 
>   f5a2aeb8b254 ("crypto: ccp - Do not free psp_master when PLATFORM_INIT fails")
> 
> Fixes tag
> 
>   Fixes: 200664d5237f ("crypto: ccp: Add SEV support")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Thanks for the heads up Stephen.

I have taken a look and it seems to be a rephrasing of the original
commit subject which seems to make sense.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Fixes tag needs some work in the crypto tree
@ 2019-04-22 21:30 Stephen Rothwell
  2019-04-23  4:08 ` Herbert Xu
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2019-04-22 21:30 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Brijesh Singh

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

Hi all,

In commit

  f5a2aeb8b254 ("crypto: ccp - Do not free psp_master when PLATFORM_INIT fails")

Fixes tag

  Fixes: 200664d5237f ("crypto: ccp: Add SEV support")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: Fixes tag needs some work in the crypto tree
  2019-04-15 21:23 Stephen Rothwell
@ 2019-04-16  1:05 ` Herbert Xu
  0 siblings, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2019-04-16  1:05 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

On Tue, Apr 16, 2019 at 07:23:42AM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> In commit
> 
>   2e53582d158e ("crypto: mxc-scc - Remove broken driver")
> 
> Fixes tag
> 
>   Fixes: d293b640ebd ("crypto: mxc-scc - add basic driver for the...")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Thanks Stephen, it should be fixed now.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Fixes tag needs some work in the crypto tree
@ 2019-04-15 21:23 Stephen Rothwell
  2019-04-16  1:05 ` Herbert Xu
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2019-04-15 21:23 UTC (permalink / raw)
  To: Herbert Xu; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi Herbert,

In commit

  2e53582d158e ("crypto: mxc-scc - Remove broken driver")

Fixes tag

  Fixes: d293b640ebd ("crypto: mxc-scc - add basic driver for the...")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, back to index

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 23:19 linux-next: Fixes tag needs some work in the crypto tree Stephen Rothwell
2019-11-18  7:58 ` Pascal Van Leeuwen
2019-11-18  8:12   ` Stephen Rothwell
2019-11-18 13:04     ` Herbert Xu
  -- strict thread matches above, loose matches on Subject: below --
2019-12-11 20:37 Stephen Rothwell
2019-08-02  6:02 Stephen Rothwell
2019-04-22 21:30 Stephen Rothwell
2019-04-23  4:08 ` Herbert Xu
2019-04-15 21:23 Stephen Rothwell
2019-04-16  1:05 ` Herbert Xu

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git