From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D29C2D0CD for ; Tue, 17 Dec 2019 19:41:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 034FD2146E for ; Tue, 17 Dec 2019 19:41:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727836AbfLQTlH (ORCPT ); Tue, 17 Dec 2019 14:41:07 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:46666 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726742AbfLQTlG (ORCPT ); Tue, 17 Dec 2019 14:41:06 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 9425E20022; Tue, 17 Dec 2019 20:40:59 +0100 (CET) Date: Tue, 17 Dec 2019 20:40:58 +0100 From: Sam Ravnborg To: Randy Dunlap Cc: Andy Shevchenko , Stephen Rothwell , Linux Next Mailing List , Linus Walleij , Laurent Pinchart , Thierry Reding , Maarten Lankhorst , Sean Paul , David Airlie , Daniel Vetter , Maxime Ripard , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time Message-ID: <20191217194058.GA30852@ravnborg.org> References: <20191217140721.42432-1-andriy.shevchenko@linux.intel.com> <63f068fe-13b4-98d1-8e27-faa1bd0bdf23@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63f068fe-13b4-98d1-8e27-faa1bd0bdf23@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=JfrnYn6hAAAA:8 a=KKAkSRfTAAAA:8 a=7gkXJVJtAAAA:8 a=P1BnusSwAAAA:8 a=pGLkceISAAAA:8 a=QyXUC8HyAAAA:8 a=VwQbUJbxAAAA:8 a=e5mUnYsNAAAA:8 a=-g4Mg-S7RQq0A9TmIasA:9 a=CjuIK1q_8ugA:10 a=1CNFftbPRP8L7MoqJWF3:22 a=cvBusfyB2V15izCimMoJ:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=D0XLA9XvdZm18NrgonBM:22 a=AjGcO6oz07-iQ99wixmX:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tue, Dec 17, 2019 at 08:25:03AM -0800, Randy Dunlap wrote: > On 12/17/19 6:07 AM, Andy Shevchenko wrote: > > The initial commit followed by the fix didn't take into consideration the case > > > > CONFIG_DRM_PANEL=y > > CONFIG_BACKLIGHT_CLASS_DEVICE=m > > CONFIG_DRM_I915=y > > > > where symbol devm_of_find_backlight() is not reachable from DRM subsystem. > > Quick fix is to avoid drm_panel_of_backlight() from exporting in such case. > > > > Fixes: 907aa265fde6 ("drm/drm_panel: fix EXPORT of drm_panel_of_backlight") > > Reported-by: Randy Dunlap > > Cc: Linus Walleij > > Cc: Sam Ravnborg > > Cc: Laurent Pinchart > > Cc: Thierry Reding > > Cc: Maarten Lankhorst > > Cc: Sean Paul > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Maxime Ripard > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Andy Shevchenko > > Yes, that fixes the build error. Thanks. > > Acked-by: Randy Dunlap # build-tested Hi Andy - thanks for fixing this. And thanks Randy for verifying the fix. It passed my build test and is now pushed to drm-misc-next. Sam