linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: linux-next: manual merge of the y2038 tree with the vhost tree
Date: Mon, 6 Jan 2020 20:25:07 +1100	[thread overview]
Message-ID: <20200106202507.7f8037cc@canb.auug.org.au> (raw)
In-Reply-To: <CAK8P3a2ackxPwQxb-yeQ1pgJ5Hbh44NXDUCSfROc94kmmtx89A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

Hi Arnd,

On Mon, 6 Jan 2020 09:31:14 +0100 Arnd Bergmann <arnd@arndb.de> wrote:
>
> It doesn't. The rules used to be fairly complicated, but not
> (after my patches) basically any driver that has an .ioctl
> function must have a .compat_ioctl function and vice versa.
> 
> > index 54158766334b,fbbf18ac1d5d..000000000000
> > --- a/drivers/block/virtio_blk.c
> > +++ b/drivers/block/virtio_blk.c
> > @@@ -310,6 -404,10 +310,9 @@@ static int virtblk_getgeo(struct block_
> >   }
> >
> >   static const struct block_device_operations virtblk_fops = {
> >  -      .ioctl  = virtblk_ioctl,
> > + #ifdef CONFIG_COMPAT
> > +       .compat_ioctl = blkdev_compat_ptr_ioctl,
> > + #endif
> >         .owner  = THIS_MODULE,
> >         .getgeo = virtblk_getgeo,
> >   };  
> 
> Removing it would be better, but this version is not wrong.

Thanks.

I have adjusted my resolution from tomorrow to drop the CONFIG_COMPAT
section as well.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2020-01-06  9:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06  4:24 linux-next: manual merge of the y2038 tree with the vhost tree Stephen Rothwell
2020-01-06  8:31 ` Arnd Bergmann
2020-01-06  9:25   ` Stephen Rothwell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200106202507.7f8037cc@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=arnd@arndb.de \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).