From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Felipe Balbi <balbi@kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the usb-gadget tree
Date: Thu, 16 Jan 2020 12:58:51 +1100 [thread overview]
Message-ID: <20200116125851.474f3021@canb.auug.org.au> (raw)
In-Reply-To: <6b984328-b3f4-a23d-efb3-7e7955ad165a@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
Hi Bryan,
On Thu, 16 Jan 2020 01:45:25 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>
> On 16/01/2020 01:41, Stephen Rothwell wrote:
> > Hi Bryan,
> >
> > On Thu, 16 Jan 2020 01:19:22 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
> >>
> >> How should extra long fixes like this be divided up ?
> >
> > Just let them run on even if they are too long i.e. don't split them at all.
>
> That's what's in the git commit log though isn't it ?
When you add a Fixes: tag to a commit, you quote the subject line of
the commit you are fixing which, by definition, is a single line. We
want to keep it that way so it can be searched for easily.
So to create a fixes line you can use this:
git log -1 --format='Fixes: %h ("%s")' <commit being fixed>
i.e. in this case:
$ git log -1 --format='Fixes: %h (\"%s\")' 40d133d7f5426
Fixes: 40d133d7f542 ("usb: gadget: f_ncm: convert to new function interface with backward compatibility")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-16 1:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 20:07 linux-next: Fixes tag needs some work in the usb-gadget tree Stephen Rothwell
2020-01-16 1:19 ` Bryan O'Donoghue
2020-01-16 1:41 ` Stephen Rothwell
2020-01-16 1:45 ` Bryan O'Donoghue
2020-01-16 1:58 ` Stephen Rothwell [this message]
2020-01-16 2:08 ` Bryan O'Donoghue
2020-01-16 2:39 ` Stephen Rothwell
2020-01-16 13:07 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2020-03-15 20:12 Stephen Rothwell
2019-05-03 5:31 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116125851.474f3021@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=balbi@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).