Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Felipe Balbi <balbi@kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the usb-gadget tree
Date: Thu, 16 Jan 2020 13:39:30 +1100
Message-ID: <20200116133930.74afaa91@canb.auug.org.au> (raw)
In-Reply-To: <043cbd87-1d7d-e998-04a8-bbc9aec686df@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

Hi Bryan,

On Thu, 16 Jan 2020 02:08:55 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>
> On 16/01/2020 01:58, Stephen Rothwell wrote:
> > 
> > On Thu, 16 Jan 2020 01:45:25 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:  
> >>
> >> On 16/01/2020 01:41, Stephen Rothwell wrote:  
> >>> Hi Bryan,
> >>>
> >>> On Thu, 16 Jan 2020 01:19:22 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:  
> >>>>
> >>>> How should extra long fixes like this be divided up ?  
> >>>
> >>> Just let them run on even if they are too long i.e. don't split them at all.  
> >>
> >> That's what's in the git commit log though isn't it ?  
> > 
> > When you add a Fixes: tag to a commit, you quote the subject line of
> > the commit you are fixing which, by definition, is a single line.  We
> > want to keep it that way so it can be searched for easily.
> > 
> > So to create a fixes line you can use this:
> > 
> > git log -1 --format='Fixes: %h ("%s")' <commit being fixed>
> > 
> > i.e. in this case:
> > 
> > $ git log -1 --format='Fixes: %h (\"%s\")' 40d133d7f5426
> > Fixes: 40d133d7f542 ("usb: gadget: f_ncm: convert to new function interface with backward compatibility")
> >   
> 
> doh sorry still not seeing it
> 
> git remote -v
> usb-next	git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
> (fetch)
> 
> git fetch usb-next
> git show 5b24c28cfe13
> 
> that's a correctly formatted fixes right i.e. the same one as above
> 
> :(
> 
> not seeing the difference...

Now I see our confusion.  There is another version of this patch in
Felipe's tree as a different commit (6a6ae4e8e926) which has the Fixes
tag split ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 20:07 Stephen Rothwell
2020-01-16  1:19 ` Bryan O'Donoghue
2020-01-16  1:41   ` Stephen Rothwell
2020-01-16  1:45     ` Bryan O'Donoghue
2020-01-16  1:58       ` Stephen Rothwell
2020-01-16  2:08         ` Bryan O'Donoghue
2020-01-16  2:39           ` Stephen Rothwell [this message]
2020-01-16 13:07             ` Felipe Balbi
  -- strict thread matches above, loose matches on Subject: below --
2019-05-03  5:31 Stephen Rothwell

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116133930.74afaa91@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=balbi@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git