From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C76C33C9E for ; Fri, 17 Jan 2020 22:22:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DB0F21D7D for ; Fri, 17 Jan 2020 22:22:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PQGuifeg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727011AbgAQWWV (ORCPT ); Fri, 17 Jan 2020 17:22:21 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:28035 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726901AbgAQWWV (ORCPT ); Fri, 17 Jan 2020 17:22:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579299739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LvUJp7hWH4b8KBv58qMnYIc4CO2d+CINLvU+6GlKxQo=; b=PQGuifegfxxVohoX0LP7ElRfljmHDt+p0aAXnUhzKBrSy5FHijrNlEpT3e7zbTyLLfaOxr Sw4ADIIksccGB8Ni9Oe106rv2FKDgnipio4+LOsIAKf4kR0dz6PLX1CJLx+nWxZ5y3U4iM hwMsq6Jk/iV2S2ysN12pDc88xhfy5BQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-171-ZkFIqCMBPBmmHLtoZwDtSw-1; Fri, 17 Jan 2020 17:22:16 -0500 X-MC-Unique: ZkFIqCMBPBmmHLtoZwDtSw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 478CB10054E3; Fri, 17 Jan 2020 22:22:14 +0000 (UTC) Received: from treble (ovpn-123-54.rdu2.redhat.com [10.10.123.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F62B60BE1; Fri, 17 Jan 2020 22:22:12 +0000 (UTC) Date: Fri, 17 Jan 2020 16:22:10 -0600 From: Josh Poimboeuf To: Marco Elver Cc: David Sterba , Randy Dunlap , Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Linux Btrfs , Peter Zijlstra Subject: Re: linux-next: Tree for Dec 6 (objtool, lots in btrfs) Message-ID: <20200117222210.yygssfl2koxnafb4@treble> References: <20191213235054.6k2lcnwa63r26zwi@treble> <20191214054515.ougsr5ykhl3vvy57@treble> <20191217152511.GG3929@suse.cz> <20200117172629.yqowxl642hdx4vcm@treble> <20200117212649.opf4lt4w4jgwmrt7@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200117212649.opf4lt4w4jgwmrt7@treble> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Fri, Jan 17, 2020 at 03:26:49PM -0600, Josh Poimboeuf wrote: > On Fri, Jan 17, 2020 at 09:28:27PM +0100, Marco Elver wrote: > > On Fri, 17 Jan 2020 at 18:26, Josh Poimboeuf wrote: > > > > > > On Tue, Dec 17, 2019 at 04:25:11PM +0100, David Sterba wrote: > > > > On Fri, Dec 13, 2019 at 11:05:18PM -0800, Randy Dunlap wrote: > > > > > OK, that fixes most of them, but still leaves these 2: > > > > > > > > > > btrfs006.out:fs/btrfs/extent_io.o: warning: objtool: __set_extent_bit()+0x536: unreachable instruction > > > > > > > > Hard to read from the assembly what C statement is it referring to. I > > > > think there are also several functions inlined, I don't see anything > > > > suspicious inside __set_extent_bit itself. > > > > > > > > > btrfs006.out:fs/btrfs/relocation.o: warning: objtool: add_tree_block()+0x501: unreachable instruction > > > > > > > > Probably also heavily inlined, the function has like 50 lines, a few > > > > non-trivial function calls but the offset in the warning suggests a > > > > larger size. > > > > > > > > While browsing the callees I noticed that both have in common a function > > > > that is supposed to print and stop at fatal errors. They're > > > > extent_io_tree_panic (extent_io.c) and backref_tree_panic > > > > (relocation.c). Both call btrfs_panic which is a macro: > > > > > > > > 3239 #define btrfs_panic(fs_info, errno, fmt, args...) \ > > > > 3240 do { \ > > > > 3241 __btrfs_panic(fs_info, __func__, __LINE__, errno, fmt, ##args); \ > > > > 3242 BUG(); \ > > > > 3243 } while (0) > > > > > > > > There are no conditionals and BUG has the __noreturn annotation > > > > (unreachable()) so all is in place and I don't have better ideas what's > > > > causing the reports. > > > > > > I think KCSAN is somehow disabling GCC's detection of implicit noreturn > > > functions -- or at least some calls to them. So GCC is inserting dead > > > code after the calls. BUG() uses __builtin_unreachable(), so GCC should > > > know better. > > > > > > If this is specific to KCSAN then I might just disable these warnings > > > for KCSAN configs. > > > > I noticed that this is also a CC_OPTIMIZE_FOR_SIZE config. I recently > > sent some patches to turn some inlines into __always_inlines because > > CC_OPTIMIZE_FOR_SIZE decides to not inline functions that should > > always be inlined. > > > > I noticed that 'assfail' is a 'static inline' function and you > > mentioned earlier that GCC seems to not be able to determine if it > > returns or not. If CC_OPTIMIZE_FOR_SIZE decides to not inline, then > > maybe this could be a problem? It could also be the compiler having > > some trouble here with the CC_OPTIMIZE_FOR_SIZE + KCSAN combination. > > Even for a non-inlined static function, GCC typically detects when it's > implicitly "noreturn", and optimizes the call sites accordingly. And > that has also been true even for CC_OPTIMIZE_FOR_SIZE in the past. So > something changed apparently. (KCSAN was just a guess.) I'm actually seeing this issue pop up recently in other places, without KCSAN enabled. So it may just be a new GCC bug (albeit a very minor one). Sorry for blaming KCSAN :-) I'll need to dig some more. The easy fix would be something like: diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index eb8bd0258360..4db39fef3b56 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -655,7 +655,7 @@ alloc_extent_state_atomic(struct extent_state *prealloc) return prealloc; } -static void extent_io_tree_panic(struct extent_io_tree *tree, int err) +static void __noreturn extent_io_tree_panic(struct extent_io_tree *tree, int err) { struct inode *inode = tree->private_data; diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index d897a8e5e430..b7a94b1739ae 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -321,7 +321,7 @@ static struct rb_node *tree_search(struct rb_root *root, u64 bytenr) return NULL; } -static void backref_tree_panic(struct rb_node *rb_node, int errno, u64 bytenr) +static void __noreturn backref_tree_panic(struct rb_node *rb_node, int errno, u64 bytenr) { struct btrfs_fs_info *fs_info = NULL;