From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD3FC35247 for ; Mon, 3 Feb 2020 20:52:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94A9920720 for ; Mon, 3 Feb 2020 20:52:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726331AbgBCUwC (ORCPT ); Mon, 3 Feb 2020 15:52:02 -0500 Received: from fieldses.org ([173.255.197.46]:35694 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726287AbgBCUwC (ORCPT ); Mon, 3 Feb 2020 15:52:02 -0500 Received: by fieldses.org (Postfix, from userid 2815) id 374F31F65; Mon, 3 Feb 2020 15:52:01 -0500 (EST) Date: Mon, 3 Feb 2020 15:52:01 -0500 From: "J. Bruce Fields" To: Arnd Bergmann Cc: Stephen Rothwell , Andrew Morton , Linux Next Mailing List , Linux Kernel Mailing List , Roberto Bergantinos Corpas Subject: Re: linux-next: build failure after merge of the akpm-current tree Message-ID: <20200203205201.GA31794@fieldses.org> References: <20200131141309.367c9d8b@canb.auug.org.au> <20200201003230.GA32350@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Sat, Feb 01, 2020 at 08:54:01AM +0100, Arnd Bergmann wrote: > On Sat, Feb 1, 2020 at 1:32 AM J. Bruce Fields wrote: > > > > On Fri, Jan 31, 2020 at 02:13:09PM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the akpm-current tree, today's linux-next build (arm > > > multi_v7_defconfig) failed like this: > > > > > > net/sunrpc/auth_gss/svcauth_gss.c: In function 'gss_proxy_save_rsc': > > > net/sunrpc/auth_gss/svcauth_gss.c:1251:19: error: storage size of 'boot' isn't known > > > 1251 | struct timespec boot; > > > | ^~~~ > > > net/sunrpc/auth_gss/svcauth_gss.c:1273:3: error: implicit declaration of function 'getboottime'; did you mean 'getboottime64'? [-Werror=implicit-function-declaration] > > > 1273 | getboottime(&boot); > > > | ^~~~~~~~~~~ > > > | getboottime64 > > > net/sunrpc/auth_gss/svcauth_gss.c:1251:19: warning: unused variable 'boot' [-Wunused-variable] > > > 1251 | struct timespec boot; > > > | ^~~~ > > > > > > Caused by commit > > > > > > a415f20a18c9 ("sunrpc: expiry_time should be seconds not timeval") > > This commit uses the now-removed 'struct timespec' type and 'getboottime()' > function, so to fix the compilation error, the 64-bit replacements need to e > used as described in Documentation/core-api/timekeeping.rst > > > > from the nfsd tree interacting with commits > > > > > > de371b6c7b73 ("y2038: remove unused time32 interfaces") > > > aa7ff200a719 ("y2038: hide timeval/timespec/itimerval/itimerspec types") > > > > > > from the akpm-current tree. > > > > > > I have reverted the nfsd commit for today. A better solution is requested. > > > > Unfortunately that expiry time seems to be a signed 32-bit integer in > > both the kernel<->gss-proxy and the gss-proxy<->krb5 interfaces. > > > > I guess we'll have to come to an agreement with the krb5 developers. > > > > Simplest might be to agree that the thing's unsigned. The expiry > > shouldn't ever need to be decades in the future, so unsigned mod 2^32 > > arithmetic should work forever. > > Can you be more specific which interface you are referring to? > My change to gss_import_v1_context() is now part of mainline > as of 294ec5b87a8a ("sunrpc: convert to time64_t for expiry"), > is anything else needed there? Oops, thanks, I was looking at a branch without that patch and forgot that it changed that field to unsigned. Looking at gss-proxy: it gets this expiration time from the krb5 libraries with a call to gss_inquire_context(..., &lifetime_rec, ...) where lifetime_rec is uint32_t. Treating this as a 64-bit time makes everything work till 2106, but, for what it's worth, keeping it a u32 would make it correct forever (since mod-2^32 subtraction will still give a reasonable answer). --b.