From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: Tree for Feb 6 (objtool warning)
Date: Thu, 6 Feb 2020 12:04:07 -0600 [thread overview]
Message-ID: <20200206180407.vr5dyg2h73hmceh3@treble> (raw)
In-Reply-To: <8a8a76cd-81d6-ffeb-08d8-e8de427caa45@infradead.org>
On Thu, Feb 06, 2020 at 08:10:20AM -0800, Randy Dunlap wrote:
> On 2/5/20 8:09 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Please do not add any v5.7 material to your linux-next included
> > branches until after v5.6-rc1 has been released.
> >
> > Changes since 20200205:
> >
>
> drivers/pinctrl/pinctrl-ingenic.o: warning: objtool: ingenic_pinconf_set() falls through to next function ingenic_pinconf_group_set()
Thanks Randy. I'm able to recreate with the config. Objtool is
confused by the unreachable() statement in ingenic_pinconf_set().
I think a BUG() would be more appropriate anyway. Will post a proper
patch.
diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c
index 96f04d121ebd..6b61ac6cd4d2 100644
--- a/drivers/pinctrl/pinctrl-ingenic.c
+++ b/drivers/pinctrl/pinctrl-ingenic.c
@@ -2158,7 +2158,7 @@ static int ingenic_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
break;
default:
- unreachable();
+ BUG();
}
}
next prev parent reply other threads:[~2020-02-06 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 4:09 linux-next: Tree for Feb 6 Stephen Rothwell
2020-02-06 16:10 ` linux-next: Tree for Feb 6 (objtool warning) Randy Dunlap
2020-02-06 18:04 ` Josh Poimboeuf [this message]
2020-02-06 16:59 ` linux-next: Tree for Feb 6 (amdgpu) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206180407.vr5dyg2h73hmceh3@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).