From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DED5C352A2 for ; Fri, 7 Feb 2020 07:58:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5140D20838 for ; Fri, 7 Feb 2020 07:58:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z4HSOvs6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726936AbgBGH6p (ORCPT ); Fri, 7 Feb 2020 02:58:45 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:50861 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726130AbgBGH6m (ORCPT ); Fri, 7 Feb 2020 02:58:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581062320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HenEqyaWD9A3GA5daQn5LKIiUsd/BikWwsStjqnEW1M=; b=Z4HSOvs6k7Lqqs3eFoI5RaYZ7lzopGgOsysKNn2w2LPBwCLqtFb3NxaZRIfOdkUKkWIjLd DNa7T0PLRKzJwfrxkqphRhLyMeT2afBc/hq0lTJAjeO+SnfueuZkQIpbzUc0udhkq4MsJ3 12HIoxU710H6zXaB0X9aWuKrvZXEkNI= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-292-joHybFGBN_Wy9ZPmvJflrQ-1; Fri, 07 Feb 2020 02:58:38 -0500 X-MC-Unique: joHybFGBN_Wy9ZPmvJflrQ-1 Received: by mail-qk1-f200.google.com with SMTP id i135so855940qke.14 for ; Thu, 06 Feb 2020 23:58:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HenEqyaWD9A3GA5daQn5LKIiUsd/BikWwsStjqnEW1M=; b=sgTwl9X2VW2DWjxHxwk/HodL2PauhnKTKjdf9J5cWS520DA8MzjLevJzkKgo7OQuSi IMvo+6CZCtBFZXhcxI6dhstOuRGGOoeyVncqsxmKqnXNERFU8cNPP5k/3lF5zi3UtNuK BcjwBN4zuG1gAGkcYSa1Wu+eDWsRKFluWZ1ncdijjvQHqT4vmiYQy7Pw80u4kBJb2IEb 92fTOM9j2Jt5UiDYv3wc/X9WH5yxWt9d4P+Dm3DPk1p6J/3e+S6QluqZnSxZ234mJI6i nPivuCfn7MWySw2KViJnuUZhiIZKp/JHa9CeLFjo9T+NQTH70vv95w9M0CTG+1F14Bhg jIig== X-Gm-Message-State: APjAAAVgjSnxMgqagAQzdfRel3ndYtNtQarRzpFVnt5hztwY3JNT90h1 Y6eycO2O1/FfhVXruMFEjjRLiaYIaFWvygmTVehOdGPKAnlHKjJB1wmBdrVLUa0PNuIEChVoypX Lpzy8rcAmbOBdqgG2aiFTPw== X-Received: by 2002:aed:34c1:: with SMTP id x59mr6453461qtd.236.1581062318423; Thu, 06 Feb 2020 23:58:38 -0800 (PST) X-Google-Smtp-Source: APXvYqziMqz1E8IKbTESJfX9C1no83ZH/Toj/qyo6qUx6yX4UiOkZkQZ1T+NzcXp4I3jI9TAHXN8Bw== X-Received: by 2002:aed:34c1:: with SMTP id x59mr6453447qtd.236.1581062318154; Thu, 06 Feb 2020 23:58:38 -0800 (PST) Received: from redhat.com (bzq-79-176-41-183.red.bezeqint.net. [79.176.41.183]) by smtp.gmail.com with ESMTPSA id g77sm906726qke.129.2020.02.06.23.58.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 23:58:37 -0800 (PST) Date: Fri, 7 Feb 2020 02:58:32 -0500 From: "Michael S. Tsirkin" To: Christian Borntraeger Cc: eperezma@redhat.com, "virtualization@lists.linux-foundation.org" , Stephen Rothwell , Linux Next Mailing List , "linux-kernel@vger.kernel.org" , kvm list , Halil Pasic , Cornelia Huck Subject: Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot Message-ID: <20200207025806-mutt-send-email-mst@kernel.org> References: <20200107042401-mutt-send-email-mst@kernel.org> <20200107065434-mutt-send-email-mst@kernel.org> <20200120012724-mutt-send-email-mst@kernel.org> <2a63b15f-8cf5-5868-550c-42e2cfd92c60@de.ibm.com> <1ade56b5-083f-bb6f-d3e0-3ddcf78f4d26@de.ibm.com> <20200206171349-mutt-send-email-mst@kernel.org> <5c860fa1-cef5-b389-4ebf-99a62afa0fe8@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c860fa1-cef5-b389-4ebf-99a62afa0fe8@de.ibm.com> Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Fri, Feb 07, 2020 at 08:47:14AM +0100, Christian Borntraeger wrote: > Also adding Cornelia. > > > On 06.02.20 23:17, Michael S. Tsirkin wrote: > > On Thu, Feb 06, 2020 at 04:12:21PM +0100, Christian Borntraeger wrote: > >> > >> > >> On 06.02.20 15:22, eperezma@redhat.com wrote: > >>> Hi Christian. > >>> > >>> Could you try this patch on top of ("38ced0208491 vhost: use batched version by default")? > >>> > >>> It will not solve your first random crash but it should help with the lost of network connectivity. > >>> > >>> Please let me know how does it goes. > >> > >> > >> 38ced0208491 + this seem to be ok. > >> > >> Not sure if you can make out anything of this (and the previous git bisect log) > > > > Yes it does - that this is just bad split-up of patches, and there's > > still a real bug that caused worse crashes :) > > > > So I just pushed batch-v4. > > I expect that will fail, and bisect to give us > > vhost: batching fetches > > Can you try that please? > > > > yes. > > eccb852f1fe6bede630e2e4f1a121a81e34354ab is the first bad commit > commit eccb852f1fe6bede630e2e4f1a121a81e34354ab > Author: Michael S. Tsirkin > Date: Mon Oct 7 06:11:18 2019 -0400 > > vhost: batching fetches > > With this patch applied, new and old code perform identically. > > Lots of extra optimizations are now possible, e.g. > we can fetch multiple heads with copy_from/to_user now. > We can get rid of maintaining the log array. Etc etc. > > Signed-off-by: Michael S. Tsirkin > > drivers/vhost/test.c | 2 +- > drivers/vhost/vhost.c | 39 ++++++++++++++++++++++++++++++++++----- > drivers/vhost/vhost.h | 4 +++- > 3 files changed, 38 insertions(+), 7 deletions(-) > And the symptom is still the same - random crashes after a bit of traffic, right? > > >