From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A8CC35254 for ; Mon, 10 Feb 2020 18:45:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22F2420715 for ; Mon, 10 Feb 2020 18:45:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UV4IcU34" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727054AbgBJSpf (ORCPT ); Mon, 10 Feb 2020 13:45:35 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:20963 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726816AbgBJSpf (ORCPT ); Mon, 10 Feb 2020 13:45:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581360334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W5raNMTAVRb/PEnA4MMky/l8xEhbFC7BwZGHg9uA2fk=; b=UV4IcU34/Toh4aisvoGEFtf+7pgNugoaudZKjfiwCBJUimFNhfD/TnBq4XhfWWcq74mKTX SsqpYtGG+uamaoasC9WXnCgFOaKzp66uYam2NQQKkaRB+2INSXrVO6BdaXVppKJHW0W+LK zKprCu+tQSgB7RujSQ7mdFOLZ/1/Opo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-6Pd3NwZwP12W-w5F_Q55Zw-1; Mon, 10 Feb 2020 13:45:19 -0500 X-MC-Unique: 6Pd3NwZwP12W-w5F_Q55Zw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B95C2192299C; Mon, 10 Feb 2020 18:45:17 +0000 (UTC) Received: from treble (ovpn-122-45.rdu2.redhat.com [10.10.122.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 65CDE1001281; Mon, 10 Feb 2020 18:45:16 +0000 (UTC) Date: Mon, 10 Feb 2020 12:45:14 -0600 From: Josh Poimboeuf To: Peter Zijlstra Cc: Randy Dunlap , Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: Tree for Feb 7 (objtool warning) Message-ID: <20200210184514.phyq462bvpxwdiss@treble> References: <20200207115949.7bd62ec3@canb.auug.org.au> <20200210102951.GD14879@hirez.programming.kicks-ass.net> <20200210172603.ujtupdib5gcpmo6v@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200210172603.ujtupdib5gcpmo6v@treble> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, Feb 10, 2020 at 11:26:03AM -0600, Josh Poimboeuf wrote: > On Mon, Feb 10, 2020 at 11:29:51AM +0100, Peter Zijlstra wrote: > > On Fri, Feb 07, 2020 at 08:17:25AM -0800, Randy Dunlap wrote: > > > on x86_64: > > > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: i915_gem_execbuffer2_ioctl()+0x6c7: call to gen8_canonical_addr() with UACCESS enabled > > > > > CONFIG_CC_OPTIMIZE_FOR_SIZE=y > > > CONFIG_64BIT=y > > > > That's just really sad, stupid compiler. > > > > Something like so I suppose... > > This looks familiar... here's the approach we decided on before, before > I subsequently dropped the ball: > > https://lkml.kernel.org/r/20190923141657.p6kpqro3q4p4umwi@treble Though that patch looks broken because it masks off the UPDATE bit in the first loop (via PIN_OFFSET_MASK) before checking UPDATE in the second loop. -- Josh