linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the mips-fixes tree
@ 2020-02-19 20:36 Stephen Rothwell
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2020-02-19 20:36 UTC (permalink / raw)
  To: James Hogan
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	周琰杰 (Zhou Yanjie),
	Paul Burton

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

Hi all,

In commit

  eb41113870c9 ("MIPS: X1000: Fix clock of watchdog node.")

Fixes tag

  Fixes: 7a16ccd300c2 ("[v8,1/4] MIPS: Ingenic: Add Ingenic X1000 support.").

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Fixes tag needs some work in the mips-fixes tree
  2020-09-03  8:42 Stephen Rothwell
@ 2020-09-03 10:01 ` Thomas Bogendoerfer
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Bogendoerfer @ 2020-09-03 10:01 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Huang Pei

On Thu, Sep 03, 2020 at 06:42:59PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   f8a005e1632c ("MIPS: add missing MSACSR and upper MSA initialization")
> 
> Fixes tag
> 
>   Fixes: cc97ab235f ("MIPS: Simplify FP context initialization")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

it's fixed now.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: Fixes tag needs some work in the mips-fixes tree
@ 2020-09-03  8:42 Stephen Rothwell
  2020-09-03 10:01 ` Thomas Bogendoerfer
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2020-09-03  8:42 UTC (permalink / raw)
  To: Thomas Bogendoerfer
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Huang Pei

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi all,

In commit

  f8a005e1632c ("MIPS: add missing MSACSR and upper MSA initialization")

Fixes tag

  Fixes: cc97ab235f ("MIPS: Simplify FP context initialization")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Fixes tag needs some work in the mips-fixes tree
  2020-02-27 13:43 ` Paul Cercueil
@ 2020-02-27 14:02   ` Thomas Bogendoerfer
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Bogendoerfer @ 2020-02-27 14:02 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: Stephen Rothwell, James Hogan, Linux Next Mailing List,
	Linux Kernel Mailing List

On Thu, Feb 27, 2020 at 10:43:44AM -0300, Paul Cercueil wrote:
> Le jeu., févr. 27, 2020 at 07:17, Stephen Rothwell <sfr@canb.auug.org.au> a
> écrit :
> >Hi all,
> >
> >In commit
> >
> >  3944dee0c6cd ("MIPS: Fix CONFIG_MIPS_CMDLINE_DTB_EXTEND handling")
> >
> >Fixes tag
> >
> >  Fixes: 7784cac69735 ("MIPS: cmdline: Clean up boot_command_line
> >
> >has these problem(s):
> >
> >  - Subject has leading but no trailing parentheses
> >  - Subject has leading but no trailing quotes
> >
> >Please do not split Fixes tags over more than one line.
> 
> My fault, sorry. I did not know they could not be splitted.

I've fixed it.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Fixes tag needs some work in the mips-fixes tree
  2020-02-26 20:17 Stephen Rothwell
@ 2020-02-27 13:43 ` Paul Cercueil
  2020-02-27 14:02   ` Thomas Bogendoerfer
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Cercueil @ 2020-02-27 13:43 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: James Hogan, Linux Next Mailing List, Linux Kernel Mailing List,
	Thomas Bogendoerfer

Hi Stephen,


Le jeu., févr. 27, 2020 at 07:17, Stephen Rothwell 
<sfr@canb.auug.org.au> a écrit :
> Hi all,
> 
> In commit
> 
>   3944dee0c6cd ("MIPS: Fix CONFIG_MIPS_CMDLINE_DTB_EXTEND handling")
> 
> Fixes tag
> 
>   Fixes: 7784cac69735 ("MIPS: cmdline: Clean up boot_command_line
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.

My fault, sorry. I did not know they could not be splitted.

Cheers,
-Paul

> 
> --
> Cheers,
> Stephen Rothwell



^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: Fixes tag needs some work in the mips-fixes tree
@ 2020-02-26 20:17 Stephen Rothwell
  2020-02-27 13:43 ` Paul Cercueil
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2020-02-26 20:17 UTC (permalink / raw)
  To: James Hogan
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Paul Cercueil, Thomas Bogendoerfer

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Hi all,

In commit

  3944dee0c6cd ("MIPS: Fix CONFIG_MIPS_CMDLINE_DTB_EXTEND handling")

Fixes tag

  Fixes: 7784cac69735 ("MIPS: cmdline: Clean up boot_command_line

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-09-03 10:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 20:36 linux-next: Fixes tag needs some work in the mips-fixes tree Stephen Rothwell
2020-02-26 20:17 Stephen Rothwell
2020-02-27 13:43 ` Paul Cercueil
2020-02-27 14:02   ` Thomas Bogendoerfer
2020-09-03  8:42 Stephen Rothwell
2020-09-03 10:01 ` Thomas Bogendoerfer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).