From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CF37C52D20 for ; Thu, 27 Feb 2020 14:25:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F9AC24656 for ; Thu, 27 Feb 2020 14:25:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388707AbgB0OZW (ORCPT ); Thu, 27 Feb 2020 09:25:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:37384 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730260AbgB0OZV (ORCPT ); Thu, 27 Feb 2020 09:25:21 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70CB124656; Thu, 27 Feb 2020 14:25:20 +0000 (UTC) Date: Thu, 27 Feb 2020 09:25:18 -0500 From: Steven Rostedt To: Geert Uytterhoeven Cc: Masami Hiramatsu , Randy Dunlap , Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH] bootconfig: Fix CONFIG_BOOTTIME_TRACING dependency issue Message-ID: <20200227092518.2096344e@gandalf.local.home> In-Reply-To: References: <20200225220551.d9a409bc04b77cdf48eae3ea@kernel.org> <158264140162.23842.11237423518607465535.stgit@devnote2> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, 27 Feb 2020 10:18:08 +0100 Geert Uytterhoeven wrote: > Hi Hiramatsu-san, > > On Tue, Feb 25, 2020 at 4:47 PM Masami Hiramatsu wrote: > > Since commit d8a953ddde5e ("bootconfig: Set CONFIG_BOOT_CONFIG=n by > > default") also changed the CONFIG_BOOTTIME_TRACING to select > > CONFIG_BOOT_CONFIG to show the boot-time tracing on the menu, > > it introduced wrong dependencies with BLK_DEV_INITRD as below. > > > > WARNING: unmet direct dependencies detected for BOOT_CONFIG > > Depends on [n]: BLK_DEV_INITRD [=n] > > Selected by [y]: > > - BOOTTIME_TRACING [=y] && TRACING_SUPPORT [=y] && FTRACE [=y] && TRACING [=y] > > > > This makes the CONFIG_BOOT_CONFIG selects CONFIG_BLK_DEV_INITRD to > > fix this error and make CONFIG_BOOTTIME_TRACING=n by default, so > > that both boot-time tracing and boot configuration off but those > > appear on the menu list. > > > > Fixes: d8a953ddde5e ("bootconfig: Set CONFIG_BOOT_CONFIG=n by default") > > Reported-by: Randy Dunlap > > Signed-off-by: Masami Hiramatsu > > --- > > init/Kconfig | 2 +- > > kernel/trace/Kconfig | 1 - > > 2 files changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/init/Kconfig b/init/Kconfig > > index a84e7aa89a29..8b4c3e8c05ea 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -1217,7 +1217,7 @@ endif > > > > config BOOT_CONFIG > > bool "Boot config support" > > - depends on BLK_DEV_INITRD > > + select BLK_DEV_INITRD > > help > > Extra boot config allows system admin to pass a config file as > > complemental extension of kernel cmdline when booting. > > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > > index 795c3e02d3f1..402eef84c859 100644 > > --- a/kernel/trace/Kconfig > > +++ b/kernel/trace/Kconfig > > @@ -145,7 +145,6 @@ config BOOTTIME_TRACING > > bool "Boot-time Tracing support" > > depends on TRACING > > Why not "depends on BLK_DEV_INITRD?" here? > > /me tries to contain the bloat introduced by the bootconfig stuff. Because people like me will be scratching my head trying to figure out why I don't see Boot-time Tracing support ;-) -- Steve > > > select BOOT_CONFIG > > - default y > > help > > Enable developer to setup ftrace subsystem via supplemental > > kernel cmdline at boot time for debugging (tracing) driver > > Gr{oetje,eeting}s, > > Geert >