From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB145C10F25 for ; Mon, 9 Mar 2020 23:17:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A221F24654 for ; Mon, 9 Mar 2020 23:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583795862; bh=wa+lBkf3egB7zRHwcS9hbPziO+9VWjfRhmzJ9OncfhU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=I0QtF4aFjON7+xWAYsH3XkYho4+HejWUkjIfMt6+DBtDKgb9U5/9lLnCpqS6uNOwt 5Ycqlh9jBoab8kXvm8vO2JSM8OSNHXKzLCPDFN/xG777KY4ZKYLwD/o1mDeO1wHdo3 K6NZJ1xavM3brUjAh3oP8HOp5i3VANZMpSyhiq+A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbgCIXRm (ORCPT ); Mon, 9 Mar 2020 19:17:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:40156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbgCIXRm (ORCPT ); Mon, 9 Mar 2020 19:17:42 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 94F312146E; Mon, 9 Mar 2020 23:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583795861; bh=wa+lBkf3egB7zRHwcS9hbPziO+9VWjfRhmzJ9OncfhU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G1JR/s2UTlzLt0tpi1/04f6wBI8VwOzSxJwSrp4qLheDI2MPWk4mavivfdGql7bnb 4stwQkgd84rA/09sXtz9CV/avYAGmLRbLshkkMg5tRN4WAspUiEcDVXk/GY0jy2Mfy XgnNmQyL7nmLbFHZLb69XKfpE31I2SYP30OKRhgo= Received: by pali.im (Postfix) id 9A556BE0; Tue, 10 Mar 2020 00:17:39 +0100 (CET) Date: Tue, 10 Mar 2020 00:17:39 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Stephen Rothwell Cc: Al Viro , Linux Next Mailing List , Linux Kernel Mailing List , Namjae Jeon , Sungjong Seo , Greg Kroah-Hartman , Christoph Hellwig Subject: Re: linux-next: build warning after merge of the vfs tree Message-ID: <20200309231739.2w45cleifsmwbfd6@pali> References: <20200310095918.3ea6432f@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310095918.3ea6432f@canb.auug.org.au> User-Agent: NeoMutt/20180716 Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tuesday 10 March 2020 09:59:18 Stephen Rothwell wrote: > Hi all, > > After merging the vfs tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > warning: same module names found: > fs/exfat/exfat.ko > drivers/staging/exfat/exfat.ko > > Introduced by commit > > b9d1e2e6265f ("exfat: add Kconfig and Makefile") > > and not fixed by commit > > 1a3c0509ce83 ("staging: exfat: make staging/exfat and fs/exfat mutually exclusive") Hello Stephen! exfat.ko from fs/exfat subdirectory is a rewrite/cleanup of staging exfat driver. It means that fs/exfat replaces staging/exfat and so after fs/exfat is merged, the old staging/exfat code is not needed anymore. Therefore I think that instead of hacking Kconfig/Makefile files to define mutually exclusivity, it is better to remove staging/exfat code. Removal of old staging code should be easy and should fix this problem. Any objections? Or other ideas?