From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A6CC2BB1D for ; Fri, 13 Mar 2020 07:05:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9765E2073E for ; Fri, 13 Mar 2020 07:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584083123; bh=tqKsW6Mr4WeKn5Qa2yJbaOvMlWLU8u/M28vVtB9y87c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=v6fi5+UdVJpzTqNBYq36GuQZJdHudXCQNx0hiGBc6Kk47tMMGVESmGZL7pQWYX+z+ yxWfpbITvqJoWjdi+fBKpOdD0Ge//DxypZBqphtxPEwYjjNoh6YonVVIxUlGar56H0 Ol5iETikb8/NVsakVs95msMzlLfByf1F9CHNUe9s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726216AbgCMHFX (ORCPT ); Fri, 13 Mar 2020 03:05:23 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:57750 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726060AbgCMHFX (ORCPT ); Fri, 13 Mar 2020 03:05:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=+GIAeKVn6/6mS7zEjp0He9SbnOKS6iiO5n3vZgWytUg=; b=lZQmOUoAaK3wdVVuBwmtNxtSiy oboOZIBjmB5yRXLnwUeC+LV/HKzvVZvCeF2t8XuzwPAU+iHV5RbJKXIyd2+wcbrhX73PES2ujSSyo C38tcZp2WSs0oyVbGFfl1A/Ult/3Bmfu5Iq+qRbYC81pVBbuS7EplLkQ5stIAbG1AMHS4jaWR3P2A GsVAGAwnL2c9kIXb7PHl7motzuNky5BsD8KwRBMsCmFbaRHMzQP8h+sXQ4l+VldTTieKYxxNzb1pF gfDatKwA8z2JcCx+L79iABKfTuyzFF973oqGn9mWNJnDp4ThQNzTjQwCo1uYU7J/U9Zw9tGK6mSjr EmbvzO2Q==; Received: from ip5f5ad4e9.dynamic.kabel-deutschland.de ([95.90.212.233] helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCeNi-0008CX-OU; Fri, 13 Mar 2020 07:05:19 +0000 Date: Fri, 13 Mar 2020 08:05:14 +0100 From: Mauro Carvalho Chehab To: Marco Felsch Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Hans Verkuil Subject: Re: linux-next: build failure after merge of the v4l-dvb tree Message-ID: <20200313080514.3f65c8d9@coco.lan> In-Reply-To: <20200313064807.op4ghjsc22du3q4e@pengutronix.de> References: <20200313131903.3975cdd2@canb.auug.org.au> <20200313064807.op4ghjsc22du3q4e@pengutronix.de> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Em Fri, 13 Mar 2020 07:48:07 +0100 Marco Felsch escreveu: > Hi Stephen, > > On 20-03-13 13:19, Stephen Rothwell wrote: > > Hi all, > > > > After merging the v4l-dvb tree, today's linux-next build (arm > > multi_v7_defconfig) failed like this: > > > > ERROR: modpost: "fwnode_get_name" [drivers/media/v4l2-core/v4l2-fwnode.ko] undefined! > > > > Caused by commit > > > > dfc22c073b78 ("media: v4l2-fwnode: add initial connector parsing support") > > > > I have used the v4l-dvb tree from next-20200312 for today. > > I'm sorry for that. I put my branch on our 0day to test most of the > compile configs. Obviously this casae wasn't covered.. > > @Sakari > I will send a patch to fix this by adding: > EXPORT_SYMBOL_GPL(fwnode_get_name). There is already such patch at next-20200312: $ git show a7914d1072fb8ddeb2ec87bba1d28812483a3565 commit a7914d1072fb8ddeb2ec87bba1d28812483a3565 Author: Heikki Krogerus Date: Mon Mar 2 16:53:51 2020 +0300 device property: Export fwnode_get_name() This makes it possible to take advantage of the function in the device drivers. Signed-off-by: Heikki Krogerus Acked-by: Rafael J. Wysocki Link: https://lore.kernel.org/r/20200302135353.56659-8-heikki.krogerus@linux.intel.com Signed-off-by: Greg Kroah-Hartman diff --git a/drivers/base/property.c b/drivers/base/property.c index 511f6d7acdfe..5f35c0ccf5e0 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -566,6 +566,7 @@ const char *fwnode_get_name(const struct fwnode_handle *fwnode) { return fwnode_call_ptr_op(fwnode, get_name); } +EXPORT_SYMBOL_GPL(fwnode_get_name); /** * fwnode_get_name_prefix - Return the prefix of node for printing purposes Thanks, Mauro