[-- Attachment #1: Type: text/plain, Size: 166 bytes --] Hi Jens, Commit 290a40cb336c ("nvme: don't enable AEN if not supported") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
On 8/5/18 3:51 PM, Stephen Rothwell wrote:
> Hi Jens,
>
> Commit
>
> 290a40cb336c ("nvme: don't enable AEN if not supported")
>
> is missing a Signed-off-by from its committer.
It's because I'm an idiot and cherry picked the commit. Not only is
it missing the SOB, but it'll also show up twice if pulled. I'll likely
just have to rebase to get rid of this, and then pull in the right
-rc instead... Will do that tomorrow.
--
Jens Axboe
[-- Attachment #1: Type: text/plain, Size: 170 bytes --] Hi Jens, Commit 6f7ceaa0559b ("block: remove the bioset_integrity_free export") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
On Sun, Dec 16, 2018 at 05:26:49PM +1100, Stephen Rothwell wrote:
> Hi Jens,
>
> Commit
>
> 6f7ceaa0559b ("block: remove the bioset_integrity_free export")
>
> is missing a Signed-off-by from its author.
Ooops. Jens, in case you still feel ok ammending the tree:
Signed-off-by: Christoph Hellwig <hch@lst.de>
On 12/16/18 3:18 AM, Christoph Hellwig wrote:
> On Sun, Dec 16, 2018 at 05:26:49PM +1100, Stephen Rothwell wrote:
>> Hi Jens,
>>
>> Commit
>>
>> 6f7ceaa0559b ("block: remove the bioset_integrity_free export")
>>
>> is missing a Signed-off-by from its author.
>
> Ooops. Jens, in case you still feel ok ammending the tree:
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I guess I can do that, would like to squash a commit too.
--
Jens Axboe
[-- Attachment #1: Type: text/plain, Size: 162 bytes --] Hi all, Commit 04bc2bcccbd5 ("aoe: list new maintainer for aoe driver") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #1: Type: text/plain, Size: 262 bytes --] On 5/22/19 3:50 PM, Stephen Rothwell wrote: > Hi all, > > Commit > > 04bc2bcccbd5 ("aoe: list new maintainer for aoe driver") > > is missing a Signed-off-by from its author. Will get this fixed up, waiting for Ed to respond. -- Jens Axboe [-- Attachment #2: pEpkey.asc --] [-- Type: application/pgp-keys, Size: 18097 bytes --]
[-- Attachment #1: Type: text/plain, Size: 191 bytes --] Hi all, Commit d038dd815fc5 ("nvmet-fc: fix typo in comment") is missing a Signed-off-by from its committer. (Yeah, I know its a trivial patch) -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #1: Type: text/plain, Size: 163 bytes --] Hi all, Commit d3cac64c498c ("io_uring: fix NULL-mm for linked reqs") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #1: Type: text/plain, Size: 181 bytes --] Hi all, Commit 03d99e5d63da ("nvme-fcloop: add sysfs attribute to inject command drop") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #1: Type: text/plain, Size: 399 bytes --] Hi all, Commits 36962a1e4186 ("io_uring: create common fixed_rsrc_data allocation routines") 5bc97865b3b6 ("io_uring: create common fixed_rsrc_ref_node handling routines") b2315a2cda1f ("io_uring: generalize io_queue_rsrc_removal") a63c1259317d ("io_uring: rename file related variables to rsrc") are missing a Signed-off-by from their author. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
On 1/25/21 2:43 AM, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> 36962a1e4186 ("io_uring: create common fixed_rsrc_data allocation routines")
> 5bc97865b3b6 ("io_uring: create common fixed_rsrc_ref_node handling routines")
> b2315a2cda1f ("io_uring: generalize io_queue_rsrc_removal")
> a63c1259317d ("io_uring: rename file related variables to rsrc")
>
> are missing a Signed-off-by from their author.
Fixed up, thanks.
--
Jens Axboe
[-- Attachment #1: Type: text/plain, Size: 184 bytes --] Hi all, Commit 1020bfa8a80b ("nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST.") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #1: Type: text/plain, Size: 180 bytes --] Hi all, Commit c2c6c067c050 ("io_uring: remove structures from include/linux/io_uring.h") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
On 3/18/21 5:16 PM, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> c2c6c067c050 ("io_uring: remove structures from include/linux/io_uring.h")
>
> is missing a Signed-off-by from its author.
Stefan, let me know if you're OK with me adding that, not sure how I missed
that.
--
Jens Axboe
Am 19.03.21 um 00:25 schrieb Jens Axboe:
> On 3/18/21 5:16 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commit
>>
>> c2c6c067c050 ("io_uring: remove structures from include/linux/io_uring.h")
>>
>> is missing a Signed-off-by from its author.
>
> Stefan, let me know if you're OK with me adding that, not sure how I missed
> that.
Yes, sure :-)
I guess you removed it while adding 'Link:'
You may want to remove cc: stable from 3aab52c9a708f7183460d368700181ef0c2a09e6
("io_uring: imply MSG_NOSIGNAL for send[msg]()/recv[msg]() calls")
for now.
I'll want to do some more test with it on 5.12,
I guess we'd then have to backport it to stable as part of the
io_thread worker backport. I'll post some more details later
to the io-uring list.
Thanks!
metze
On 3/19/21 2:02 AM, Stefan Metzmacher wrote: > > Am 19.03.21 um 00:25 schrieb Jens Axboe: >> On 3/18/21 5:16 PM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Commit >>> >>> c2c6c067c050 ("io_uring: remove structures from include/linux/io_uring.h") >>> >>> is missing a Signed-off-by from its author. >> >> Stefan, let me know if you're OK with me adding that, not sure how I missed >> that. > > Yes, sure :-) > I guess you removed it while adding 'Link:' That was b4, I don't add those manually. But maybe it stripped those too, annoying... > You may want to remove cc: stable from 3aab52c9a708f7183460d368700181ef0c2a09e6 > ("io_uring: imply MSG_NOSIGNAL for send[msg]()/recv[msg]() calls") > for now. > > I'll want to do some more test with it on 5.12, > I guess we'd then have to backport it to stable as part of the > io_thread worker backport. I'll post some more details later > to the io-uring list. Sure, let's do that. I also dropped the short link sever as well for now. I do like it on principle, but it does have a risk of breaking valid use cases. -- Jens Axboe
Am 19.03.21 um 14:08 schrieb Jens Axboe:
> On 3/19/21 2:02 AM, Stefan Metzmacher wrote:
>>
>> Am 19.03.21 um 00:25 schrieb Jens Axboe:
>>> On 3/18/21 5:16 PM, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Commit
>>>>
>>>> c2c6c067c050 ("io_uring: remove structures from include/linux/io_uring.h")
>>>>
>>>> is missing a Signed-off-by from its author.
>>>
>>> Stefan, let me know if you're OK with me adding that, not sure how I missed
>>> that.
>>
>> Yes, sure :-)
>> I guess you removed it while adding 'Link:'
>
> That was b4, I don't add those manually. But maybe it stripped those too,
> annoying...
>
>> You may want to remove cc: stable from 3aab52c9a708f7183460d368700181ef0c2a09e6
>> ("io_uring: imply MSG_NOSIGNAL for send[msg]()/recv[msg]() calls")
>> for now.
>>
>> I'll want to do some more test with it on 5.12,
>> I guess we'd then have to backport it to stable as part of the
>> io_thread worker backport. I'll post some more details later
>> to the io-uring list.
>
> Sure, let's do that. I also dropped the short link sever as well for now.
> I do like it on principle, but it does have a risk of breaking valid
> use cases.
Thanks, I'll resubmit that with the MSG_WAITALL logic.
metze
[-- Attachment #1: Type: text/plain, Size: 205 bytes --] Hi all, Commit 6fa6517fe62e ("ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
On 4/11/21 4:34 PM, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 6fa6517fe62e ("ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present")
>
> is missing a Signed-off-by from its author.
Sowjana, please reply that you're OK with me adding your Signed-off-by to that
patch.
--
Jens Axboe
On 4/11/21 7:14 PM, Jens Axboe wrote:
> On 4/11/21 4:34 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commit
>>
>> 6fa6517fe62e ("ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present")
>>
>> is missing a Signed-off-by from its author.
> Sowjana, please reply that you're OK with me adding your Signed-off-by to that
> patch.
>
Sorry I should have checked that. Thanks Jens. Sure I am OK with it.
Thank you
Sowjanya
On 4/11/21 8:26 PM, Sowjanya Komatineni wrote:
>
> On 4/11/21 7:14 PM, Jens Axboe wrote:
>> On 4/11/21 4:34 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Commit
>>>
>>> 6fa6517fe62e ("ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present")
>>>
>>> is missing a Signed-off-by from its author.
>> Sowjana, please reply that you're OK with me adding your Signed-off-by to that
>> patch.
>>
> Sorry I should have checked that. Thanks Jens. Sure I am OK with it.
Added, thanks.
--
Jens Axboe
[-- Attachment #1: Type: text/plain, Size: 180 bytes --] Hi all, Commit f6e8bd59c4e8 ("nvmet: move ka_work initialization to nvmet_alloc_ctrl") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #1: Type: text/plain, Size: 167 bytes --] Hi all, Commit 9d3b8813895d ("block: change the refcounting for partitions") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #1: Type: text/plain, Size: 199 bytes --] Hi all, Commit d6d6742772d7 ("nvme: fix RCU hole that allowed for endless looping in multipath round robin") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
Chris,
can you give the signoff for this one so that we have it on record?
On Wed, Mar 30, 2022 at 08:11:02AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> d6d6742772d7 ("nvme: fix RCU hole that allowed for endless looping in multipath round robin")
>
> is missing a Signed-off-by from its author.
>
> --
> Cheers,
> Stephen Rothwell
---end quoted text---
[-- Attachment #1: Type: text/plain, Size: 172 bytes --] Hi all, Commit 32389bb813f9 ("md: stop using for_each_mddev in md_notify_reboot") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
On Wed, Jul 20, 2022 at 11:16:59PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 32389bb813f9 ("md: stop using for_each_mddev in md_notify_reboot")
>
> is missing a Signed-off-by from its author.
In case this can still be fixed:
Signed-off-by: Christoph Hellwig <hch@lst.de>
On 7/20/22 7:21 AM, Christoph Hellwig wrote:
> On Wed, Jul 20, 2022 at 11:16:59PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commit
>>
>> 32389bb813f9 ("md: stop using for_each_mddev in md_notify_reboot")
>>
>> is missing a Signed-off-by from its author.
>
> In case this can still be fixed:
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
At least we have it documented here, I don't think we need to rebase
both repos.
--
Jens Axboe
[-- Attachment #1: Type: text/plain, Size: 166 bytes --] Hi all, Commit 24337ddf1ff4 ("io_uring: Enable KASAN for request cache") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
On 1/22/23 2:08 PM, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 24337ddf1ff4 ("io_uring: Enable KASAN for request cache")
>
> is missing a Signed-off-by from its committer.
Fixed up, thanks.
--
Jens Axboe
[-- Attachment #1: Type: text/plain, Size: 400 bytes --] Hi Jens, On Sun, 22 Jan 2023 14:30:15 -0700 Jens Axboe <axboe@kernel.dk> wrote: > > On 1/22/23 2:08 PM, Stephen Rothwell wrote: > > > > Commit > > > > 24337ddf1ff4 ("io_uring: Enable KASAN for request cache") > > > > is missing a Signed-off-by from its committer. > > Fixed up, thanks. Thanks. Except you misspelled "Signed-off-by" :-) -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
On 1/22/23 2:34 PM, Stephen Rothwell wrote:
> Hi Jens,
>
> On Sun, 22 Jan 2023 14:30:15 -0700 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 1/22/23 2:08 PM, Stephen Rothwell wrote:
>>>
>>> Commit
>>>
>>> 24337ddf1ff4 ("io_uring: Enable KASAN for request cache")
>>>
>>> is missing a Signed-off-by from its committer.
>>
>> Fixed up, thanks.
>
> Thanks.
>
> Except you misspelled "Signed-off-by" :-)
Hah, damnit! I never type that by hand, except for here... Anyway,
fixed THAT one up too.
--
Jens Axboe