From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Wireless <linux-wireless@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
Date: Wed, 15 Apr 2020 11:06:49 +1000 [thread overview]
Message-ID: <20200415110649.39e26be3@canb.auug.org.au> (raw)
In-Reply-To: <5b17fefe-f99d-2e4c-ded2-93fd3554687c@lwfinger.net>
[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]
Hi Larry,
On Tue, 14 Apr 2020 19:36:28 -0500 Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
> On 4/14/20 5:08 PM, Stephen Rothwell wrote:
> >
> > In commit
> >
> > ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
> >
> > Fixes tag
> >
> > Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject
> > Just use
> > git log -1 --format='Fixes: %h ("%s")'
>
> I do not understand what you want here. The subject describes what was fixed.
> The error has been in the driver since it was merged. The Fixes: line is a
> description of the commit that introduced the driver file with the error.
The subject I was referring to is the subject quoted in the Fixes tag,
not the subject of the fixing commit. So:
Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
Its not very important, just a consistency thing - I wouldn't bother
rebasing just to fix this, just for the future ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-04-15 1:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 22:08 linux-next: Fixes tag needs some work in the wireless-drivers-next tree Stephen Rothwell
2020-04-15 0:36 ` Larry Finger
2020-04-15 1:06 ` Stephen Rothwell [this message]
2020-04-15 4:45 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2020-08-18 22:33 Stephen Rothwell
2020-08-19 6:52 ` Kalle Valo
2020-08-19 8:13 ` Stephen Rothwell
2020-09-24 16:11 ` Kalle Valo
2020-08-02 22:03 Stephen Rothwell
2020-08-04 13:17 ` Kalle Valo
2020-07-14 10:59 Stephen Rothwell
2020-07-14 17:49 ` Kalle Valo
2020-05-18 13:01 Stephen Rothwell
2020-05-19 8:50 ` Kalle Valo
2020-01-27 0:42 Stephen Rothwell
2020-01-29 14:05 ` Kalle Valo
2019-07-01 21:33 Stephen Rothwell
2019-07-02 4:26 ` dundi
2019-06-30 21:44 Stephen Rothwell
2019-07-01 10:35 ` Lorenzo Bianconi
2019-05-27 21:48 Stephen Rothwell
2019-05-01 21:50 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415110649.39e26be3@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=Larry.Finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).