From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: linux-next: build warning after merge of the v4l-dvb tree
Date: Fri, 17 Apr 2020 09:01:15 +0200 [thread overview]
Message-ID: <20200417090115.3cccc9bd@coco.lan> (raw)
In-Reply-To: <7faaec92dc9b5870b33c6dbb440de0698b5a70e7.camel@collabora.com>
Em Fri, 17 Apr 2020 02:13:47 -0300
Ezequiel Garcia <ezequiel@collabora.com> escreveu:
> Hi Stephen,
>
> On Fri, 2020-04-17 at 10:22 +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the v4l-dvb tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > WARNING: unmet direct dependencies detected for MEDIA_CONTROLLER_REQUEST_API
> > Depends on [n]: MEDIA_SUPPORT [=m] && MEDIA_CONTROLLER [=y] && STAGING_MEDIA [=n]
> > Selected by [m]:
> > - VIDEO_VIVID [=m] && MEDIA_SUPPORT [=m] && MEDIA_TEST_SUPPORT [=y] && V4L_TEST_DRIVERS [=y] && VIDEO_DEV [=m] && VIDEO_V4L2 [=m] && !SPARC32 &&
> > !SPARC64 && FB [=y] && HAS_DMA [=y]
> >
>
> Ugh, my bad. MEDIA_CONTROLLER_REQUEST_API can't
> depend on staging, after this recently merged commit:
>
> "media: Kconfig: Don't expose the Request API option"
>
> So, we should fix that with:
>
> diff --git a/drivers/media/mc/Kconfig b/drivers/media/mc/Kconfig
> index 7c9628f37196..4815b9dde9af 100644
> --- a/drivers/media/mc/Kconfig
> +++ b/drivers/media/mc/Kconfig
> @@ -14,7 +14,7 @@ config MEDIA_CONTROLLER_DVB
>
> config MEDIA_CONTROLLER_REQUEST_API
> bool
> - depends on MEDIA_CONTROLLER && STAGING_MEDIA
> + depends on MEDIA_CONTROLLER
> help
> DO NOT ENABLE THIS OPTION UNLESS YOU KNOW WHAT YOU'RE DOING.
>
> Mauro what do you think?
Dropped the dependency and applied on media.
I also addressed the "select PCI" issue, with causes troubles on
s390 random configs (due to HAS_PCI=n on s390).
Thanks,
Mauro
next prev parent reply other threads:[~2020-04-17 7:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 0:22 linux-next: build warning after merge of the v4l-dvb tree Stephen Rothwell
2020-04-17 5:13 ` Ezequiel Garcia
2020-04-17 7:01 ` Mauro Carvalho Chehab [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-10 23:46 Stephen Rothwell
2021-05-21 0:48 ` Stephen Rothwell
2021-03-23 5:56 Stephen Rothwell
2021-02-08 12:37 Stephen Rothwell
2021-02-08 16:42 ` Ezequiel Garcia
2021-02-08 16:46 ` Sakari Ailus
2021-02-08 16:57 ` Ezequiel Garcia
2021-02-08 17:40 ` Mauro Carvalho Chehab
2021-02-08 18:53 ` Ezequiel Garcia
2021-02-15 10:20 ` Mauro Carvalho Chehab
2021-02-15 10:42 ` Mauro Carvalho Chehab
2021-02-14 22:44 ` Stephen Rothwell
2021-02-08 0:32 Stephen Rothwell
2021-02-08 6:30 ` Mauro Carvalho Chehab
2021-02-08 8:33 ` Geert Uytterhoeven
2021-02-08 8:49 ` Mauro Carvalho Chehab
2021-02-08 8:52 ` Geert Uytterhoeven
2021-02-08 9:14 ` Mauro Carvalho Chehab
2021-01-13 4:10 Stephen Rothwell
2021-01-20 6:14 ` Stephen Rothwell
2020-11-18 5:29 Stephen Rothwell
2020-11-26 6:54 ` Stephen Rothwell
2020-11-27 10:11 ` Sean Young
2020-05-21 2:07 Stephen Rothwell
2020-04-15 1:29 Stephen Rothwell
2019-01-31 23:25 Stephen Rothwell
2011-03-17 0:29 Stephen Rothwell
2010-12-31 0:59 Stephen Rothwell
2010-10-08 0:49 Stephen Rothwell
2010-10-08 3:13 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417090115.3cccc9bd@coco.lan \
--to=mchehab@kernel.org \
--cc=ezequiel@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).