linux-next: Fixes tag needs some work in the vhost tree

linux-next: Fixes tag needs some work in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

Hi all,

In commit

  ab8be610c87d ("virtio-blk: handle block_device_operations callbacks after hot unplug")

Fixes tag

  Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3

has these problem(s):

  - missing subject

Should be

Fixes: 48e4043d4529 ("virtio: add virtio disk geometry feature")

Please don't split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the vhost tree

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

On Sat, May 02, 2020 at 10:30:18AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   ab8be610c87d ("virtio-blk: handle block_device_operations callbacks after hot unplug")
> 
> Fixes tag
> 
>   Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3
> 
> has these problem(s):
> 
>   - missing subject
> 
> Should be
> 
> Fixes: 48e4043d4529 ("virtio: add virtio disk geometry feature")
> 
> Please don't split Fixes tags over more than one line.

Got it, thanks for letting me know. I'll keep the tag on one line in the
future.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hi all,

In commit

  5be8d7869e2d ("Bluetooth: virtio_bt: fix an error code in probe()")

Fixes tag

  Fixes: 212a6e51a630 ("Bluetooth: virtio_bt: fix device removal")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: bdbbdac22c63 ("Bluetooth: virtio_bt: fix device removal")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

Hi all,

In commit

  f89ef240d5d0 ("virtio_ring: check desc == NULL when using indirect with packed")

Fixes tag

  Fixes: 1ce9e6055fa ("virtio_ring: introduce packed ring support")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

Hi all,

In commit

  71a6465aadf4 ("virtio: don't fail on !of_device_is_compatible")

Fixes tag

  Fixes: 694a1116b405 (&quot;virtio: Bind virtio device to device-tree node&quot;)<br>

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Something weird happened here - the tags seem to be partly repeasted and
"html-ized".

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hi all,

In commit

  3dfa449593a9 ("vdpa/mlx5: Avoid executing set_vq_ready() if device is reset")

Fixes tag

  Fixes: 9c90709cf8e7 ("vdpa/mlx5: Add multiqueue support")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support")



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

Hi all,

In commit

  155cb8a4e63c ("vhost: Fix the calculation in vhost_overflow()")

Fixes tag

  Fixes: ec33d031a14b ("vhost: detect 32 bit integer wrap around“)

has these problem(s):

  - Subject has leading but no trailing quotes (actually leading ascii
    double quote, but a trailing Unicode double quote)
    Just use
	git log -1 --format='Fixes: %h ("%s")'

This is probably is not worth rebasing to fix.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

Hi all,

n commit

  a9d064524fc3 ("vhost-vdpa: protect concurrent access to vhost device iotlb")

Fixes tag

  Fixes: 4c8cf318("vhost: introduce vDPA-based backend")

has these problem(s):

  - missing space between the SHA1 and the subject
  - SHA1 should be at least 12 digits long

Probably not worth rebaseing to fix, but can be avoided in the futre
by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the vhost tree

[si-wei liu]

Thanks Stephen, the SHA1 referenced is not correct. A v2 patch is posted.

Thanks,
-Siwei


On 10/1/2020 3:32 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>    c9795f8fbb41 ("vhost-vdpa: fix page pinning leakage in error path")
>
> Fixes tag
>
>    Fixes: 20453a45fb06 ("vhost: introduce vDPA-based backend")
>
> has these problem(s):
>
>    - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend")
>

linux-next: Fixes tag needs some work in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

Hi all,

In commit

  c9795f8fbb41 ("vhost-vdpa: fix page pinning leakage in error path")

Fixes tag

  Fixes: 20453a45fb06 ("vhost: introduce vDPA-based backend")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]