linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the nfs tree
@ 2020-05-14 22:33 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2020-05-14 22:33 UTC (permalink / raw)
  To: Trond Myklebust
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Olga Kornievskaia

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

In commit

  1ce8dbb6a593 ("NFSv3: fix rpc receive buffer size for MOUNT call")

Fixes tag

  Fixes: e3d3ab64dd66 ("SUNRPC: Use au_rslack when computing reply buffer size")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 2c94b8eca1a2 ("SUNRPC: Use au_rslack when computing reply buffer size")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Fixes tag needs some work in the nfs tree
@ 2021-06-03 22:20 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2021-06-03 22:20 UTC (permalink / raw)
  To: Trond Myklebust
  Cc: Anna Schumaker, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Hi all,

In commit

  476bdb04c501 ("NFS: Fix use-after-free in nfs4_init_client()")

Fixes tag

  Fixes: 8dcbec6d20 ("NFSv41: Handle EXCHID4_FLAG_CONFIRMED_R during NFSv4.1 migration")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: Fixes tag needs some work in the nfs tree
  2021-01-10  2:14 Stephen Rothwell
@ 2021-01-10 17:13 ` Trond Myklebust
  0 siblings, 0 replies; 10+ messages in thread
From: Trond Myklebust @ 2021-01-10 17:13 UTC (permalink / raw)
  To: sfr; +Cc: smayhew, linux-next, linux-kernel

Hi Stephen,

On Sun, 2021-01-10 at 13:14 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   2cc8aca9d547 ("NFS: Adjust fs_context error logging")
> 
> Fixes tag
> 
>   Fixes: Fixes: ce8866f0913f ("NFS: Attach supplementary error
> information to fs_context.")
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> See duplicate "Fixes: " :-(
> 

Sorry, that was my fault. I added the 'Fixes' tag when I applied the
patch. and failed to notice the copy-paste error.
I'll fix up the commit changelog.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com



^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Fixes tag needs some work in the nfs tree
@ 2021-01-10  2:14 Stephen Rothwell
  2021-01-10 17:13 ` Trond Myklebust
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2021-01-10  2:14 UTC (permalink / raw)
  To: Trond Myklebust
  Cc: Scott Mayhew, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

Hi all,

In commit

  2cc8aca9d547 ("NFS: Adjust fs_context error logging")

Fixes tag

  Fixes: Fixes: ce8866f0913f ("NFS: Attach supplementary error information to fs_context.")

has these problem(s):

  - No SHA1 recognised

See duplicate "Fixes: " :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Fixes tag needs some work in the nfs tree
@ 2020-12-14 10:38 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2020-12-14 10:38 UTC (permalink / raw)
  To: Trond Myklebust
  Cc: Dan Aloni, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi all,

In commit

  526a842bec1d ("sunrpc: fix xs_read_xdr_buf for partial pages receive")

Fixes tag

  Fixes: 277e4ab7d53 ("SUNRPC: Simplify TCP receive code by switching to

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").
  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Fixes tag needs some work in the nfs tree
@ 2020-08-04 22:10 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2020-08-04 22:10 UTC (permalink / raw)
  To: Trond Myklebust
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Scott Mayhew

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

Hi all,

In commit

  8c8f8e3106bb ("nfs: nfs_file_write() should check for writeback errors")

Fixes tag

  Fixes: 6fbda89b257f ("NFS: Replace custom error reporting mechanism with

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  67dd23f9e6fb ("nfs: ensure correct writeback errors are returned on close()")

Fixes tag

  Fixes: 6fbda89b257f ("NFS: Replace custom error reporting mechanism with

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Pleas do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Fixes tag needs some work in the nfs tree
@ 2020-04-21 22:05 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2020-04-21 22:05 UTC (permalink / raw)
  To: Trond Myklebust
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Xiyu Yang, Xin Tan

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

In commit

  115677dcbc45 ("SUNRPC: Remove unreachable error condition")

Fixes tag

  Fixes: 7f554890587c ("SUNRPC: Allow addition of new transports to a

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: Fixes tag needs some work in the nfs tree
  2020-04-03 21:55 Stephen Rothwell
@ 2020-04-03 22:22 ` Trond Myklebust
  0 siblings, 0 replies; 10+ messages in thread
From: Trond Myklebust @ 2020-04-03 22:22 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On Sat, 2020-04-04 at 08:55 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   52381893a2be ("NFS: Beware when dereferencing the delegation cred")
> 
> Fixes tag
> 
>   Fixes: 5f4adff16fa2 ("NFSv4: nfs_update_inplace_delegation() should
> update delegation cred")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 57f188e04773 ("NFSv4: nfs_update_inplace_delegation() should
> update delegation cred")
> 

Doh! The price of juggling too many kernel branches and backports at
the same time. Thanks Stephen!

Cheers
  Trond

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Fixes tag needs some work in the nfs tree
@ 2020-04-03 21:55 Stephen Rothwell
  2020-04-03 22:22 ` Trond Myklebust
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2020-04-03 21:55 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi all,

In commit

  52381893a2be ("NFS: Beware when dereferencing the delegation cred")

Fixes tag

  Fixes: 5f4adff16fa2 ("NFSv4: nfs_update_inplace_delegation() should update delegation cred")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 57f188e04773 ("NFSv4: nfs_update_inplace_delegation() should update delegation cred")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Fixes tag needs some work in the nfs tree
@ 2019-11-19 20:47 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2019-11-19 20:47 UTC (permalink / raw)
  To: Trond Myklebust
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chuck Lever

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

Hi all,

In commit

  e8d70b321ecc ("SUNRPC: Fix another issue with MIC buffer space")

Fixes tag

  Fixes: 5f1bc39979d ("SUNRPC: Fix buffer handling of GSS MIC ... ")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-06-03 22:20 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-14 22:33 linux-next: Fixes tag needs some work in the nfs tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2021-06-03 22:20 Stephen Rothwell
2021-01-10  2:14 Stephen Rothwell
2021-01-10 17:13 ` Trond Myklebust
2020-12-14 10:38 Stephen Rothwell
2020-08-04 22:10 Stephen Rothwell
2020-04-21 22:05 Stephen Rothwell
2020-04-03 21:55 Stephen Rothwell
2020-04-03 22:22 ` Trond Myklebust
2019-11-19 20:47 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).