From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8040BC433E0 for ; Tue, 19 May 2020 08:48:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E1D8207FB for ; Tue, 19 May 2020 08:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589878097; bh=x7OQkshLeaeILqov6KC6RjMQZFcU2fWWtNRyiJhfUsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=v3VzNQ4LsNR6qLxRVj7dH+poPSyHHzK4A/u41vqc4fnZCJ+jxXPN1B6wFfqy3uZ/5 LQBzVcTM6hiLWdg9lXctwzu1vcxPc5M6hL0wXjp6dUroFNNev7IDciLmGkdDZj7Mv8 CqHzG1yXUCsca7qldOpnaMbGkYezbRR+etAVVvbo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727084AbgESIsQ (ORCPT ); Tue, 19 May 2020 04:48:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:33752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726388AbgESIsQ (ORCPT ); Tue, 19 May 2020 04:48:16 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 42103204EA; Tue, 19 May 2020 08:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589878096; bh=x7OQkshLeaeILqov6KC6RjMQZFcU2fWWtNRyiJhfUsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AJHKy3Rf9ITJIkRnpPGw//PzJ0vIyHs16EzBi2MG10syNZYqNHdlQU1570zoyMvuY LjGVVCfL1bTirDsLTLJwvmIapsxzevHdnjpOA0QcJpDz1pUypHB3aCAPu4A3vuBquo gUWu7Ic9M0EMXuRtZ+7R94SpWc1VWcQVnUQcQTmY= Date: Tue, 19 May 2020 11:48:12 +0300 From: Leon Romanovsky To: Danil Kipnis Cc: linux-rdma@vger.kernel.org, jgg@ziepe.ca, linux-next@vger.kernel.org, jinpu.wang@cloud.ionos.com, dledford@redhat.com, axboe@kernel.dk, linux-block@vger.kernel.org, bvanassche@acm.org, rdunlap@infradead.org Subject: Re: [PATCH 1/1] rnbd/rtrs: pass max segment size from blk user to the rdma library Message-ID: <20200519084812.GP188135@unreal> References: <20200519080136.885628-1-danil.kipnis@cloud.ionos.com> <20200519080136.885628-2-danil.kipnis@cloud.ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519080136.885628-2-danil.kipnis@cloud.ionos.com> Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tue, May 19, 2020 at 10:01:36AM +0200, Danil Kipnis wrote: > When Block Device Layer is disabled, BLK_MAX_SEGMENT_SIZE is undefined. > The rtrs is a transport library and should compile independently of the > block layer. The desired max segment size should be passed down by the > user. > > Introduce max_segment_size parameter for the rtrs_clt_open() call. > > Signed-off-by: Danil Kipnis > Reported-by: Randy Dunlap > --- Please, add fixes line. Thanks