linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Danil Kipnis <danil.kipnis@cloud.ionos.com>
Cc: linux-rdma@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Jinpu Wang <jinpu.wang@cloud.ionos.com>,
	Doug Ledford <dledford@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH 1/1] rnbd/rtrs: pass max segment size from blk user to the rdma library
Date: Tue, 19 May 2020 18:42:11 +0300	[thread overview]
Message-ID: <20200519154211.GS188135@unreal> (raw)
In-Reply-To: <CAHg0Huw9HiNz1jYcypiirbB6encMcBOuGMLDE+9m0wGp0B6VfA@mail.gmail.com>

On Tue, May 19, 2020 at 11:14:26AM +0200, Danil Kipnis wrote:
> Hi Leon
>
> On Tue, May 19, 2020 at 10:48 AM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Tue, May 19, 2020 at 10:01:36AM +0200, Danil Kipnis wrote:
> > > When Block Device Layer is disabled, BLK_MAX_SEGMENT_SIZE is undefined.
> > > The rtrs is a transport library and should compile independently of the
> > > block layer. The desired max segment size should be passed down by the
> > > user.
> > >
> > > Introduce max_segment_size parameter for the rtrs_clt_open() call.
> > >
> > > Signed-off-by: Danil Kipnis <danil.kipnis@cloud.ionos.com>
> > > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > > ---
> >
> > Please, add fixes line.
> I'm new to this for-next fix up procedure. What tree the commit I
> should reference with the fixes line should come from? Should I split
> this commit so that I can reference the commits which add separate
> files in the original patchset here
> https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/?h=for-next
> ? And also if I have to fix yet another issue - how do I then
> reference the commit this patch creates if applied?
> Thank you!

NP,

You need to configure your email client to properly honor replies,
e.g. add extra blank line between your reply and the email body.
It will make your replies more clear.

Regarding fixes:
1. There should not blank line between Fixes line and SOBs.
2. You can use one Fixes line (use latest).
3. Patches are usually divided for logical units.

Thanks

>
> >
> > Thanks

  reply	other threads:[~2020-05-19 15:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18 10:57 linux-next: Tree for May 18 Stephen Rothwell
2020-05-18 15:00 ` linux-next: Tree for May 18 (drivers/infiniband/ulp/rtrs/rtrs-clt.c) Randy Dunlap
2020-05-19  6:55   ` Danil Kipnis
2020-05-19  8:01   ` [PATCH 0/1] Fix RTRS compilation with block layer disabled Danil Kipnis
2020-05-19  8:01     ` [PATCH 1/1] rnbd/rtrs: pass max segment size from blk user to the rdma library Danil Kipnis
2020-05-19  8:48       ` Leon Romanovsky
2020-05-19  9:14         ` Danil Kipnis
2020-05-19 15:42           ` Leon Romanovsky [this message]
2020-05-19 11:14         ` [PATCH v2] " Danil Kipnis
2020-05-19 15:04           ` Randy Dunlap
2020-05-19 23:44           ` Jason Gunthorpe
2020-05-21 16:12             ` Randy Dunlap
2020-05-21 20:00               ` Jason Gunthorpe
2020-05-19  8:45     ` [PATCH 0/1] Fix RTRS compilation with block layer disabled Leon Romanovsky
2020-05-19 23:34     ` Jason Gunthorpe
2020-05-18 15:42 ` linux-next: Tree for May 18 (input/misc/iqs269a.c & regmap) Randy Dunlap
2020-05-18 16:20   ` Jeff LaBundy
2020-05-22 18:22     ` Randy Dunlap
2020-05-22 21:49       ` Dmitry Torokhov
2020-05-18 16:41 ` linux-next: Tree for May 18 (x86/mm/pgtable.c) Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519154211.GS188135@unreal \
    --to=leon@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=danil.kipnis@cloud.ionos.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --subject='Re: [PATCH 1/1] rnbd/rtrs: pass max segment size from blk user to the rdma library' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).