Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build warning after merge of the v4l-dvb tree
@ 2020-05-21  2:07 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2020-05-21  2:07 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

Hi all,

After merging the v4l-dvb tree, today's linux-next build (x86_84
allmodconfig) produced this warning:

drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: warning: 'atomisp_mrfld_power' defined but not used [-Wunused-function]
  764 | static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable)
      |            ^~~~~~~~~~~~~~~~~~~

Introduced by commit

  95d1f398c4dc ("media: atomisp: keep the ISP powered on when setting it")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: build warning after merge of the v4l-dvb tree
  2020-04-17  5:13 ` Ezequiel Garcia
@ 2020-04-17  7:01   ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 10+ messages in thread
From: Mauro Carvalho Chehab @ 2020-04-17  7:01 UTC (permalink / raw)
  To: Ezequiel Garcia
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, linux-media, Hans Verkuil

Em Fri, 17 Apr 2020 02:13:47 -0300
Ezequiel Garcia <ezequiel@collabora.com> escreveu:

> Hi Stephen,
> 
> On Fri, 2020-04-17 at 10:22 +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the v4l-dvb tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> > 
> > WARNING: unmet direct dependencies detected for MEDIA_CONTROLLER_REQUEST_API
> >   Depends on [n]: MEDIA_SUPPORT [=m] && MEDIA_CONTROLLER [=y] && STAGING_MEDIA [=n]
> >   Selected by [m]:
> >   - VIDEO_VIVID [=m] && MEDIA_SUPPORT [=m] && MEDIA_TEST_SUPPORT [=y] && V4L_TEST_DRIVERS [=y] && VIDEO_DEV [=m] && VIDEO_V4L2 [=m] && !SPARC32 &&
> > !SPARC64 && FB [=y] && HAS_DMA [=y]
> >   
> 
> Ugh, my bad. MEDIA_CONTROLLER_REQUEST_API can't
> depend on staging, after this recently merged commit:
> 
> "media: Kconfig: Don't expose the Request API option"
> 
> So, we should fix that with:
> 
> diff --git a/drivers/media/mc/Kconfig b/drivers/media/mc/Kconfig
> index 7c9628f37196..4815b9dde9af 100644
> --- a/drivers/media/mc/Kconfig
> +++ b/drivers/media/mc/Kconfig
> @@ -14,7 +14,7 @@ config MEDIA_CONTROLLER_DVB
>  
>  config MEDIA_CONTROLLER_REQUEST_API
>         bool
> -       depends on MEDIA_CONTROLLER && STAGING_MEDIA
> +       depends on MEDIA_CONTROLLER
>         help
>           DO NOT ENABLE THIS OPTION UNLESS YOU KNOW WHAT YOU'RE DOING.
>  
> Mauro what do you think?

Dropped the dependency and applied on media.

I also addressed the "select PCI" issue, with causes troubles on
s390 random configs (due to HAS_PCI=n on s390).

Thanks,
Mauro

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: build warning after merge of the v4l-dvb tree
  2020-04-17  0:22 Stephen Rothwell
@ 2020-04-17  5:13 ` Ezequiel Garcia
  2020-04-17  7:01   ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 10+ messages in thread
From: Ezequiel Garcia @ 2020-04-17  5:13 UTC (permalink / raw)
  To: Stephen Rothwell, Mauro Carvalho Chehab
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, linux-media,
	Hans Verkuil

Hi Stephen,

On Fri, 2020-04-17 at 10:22 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the v4l-dvb tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> WARNING: unmet direct dependencies detected for MEDIA_CONTROLLER_REQUEST_API
>   Depends on [n]: MEDIA_SUPPORT [=m] && MEDIA_CONTROLLER [=y] && STAGING_MEDIA [=n]
>   Selected by [m]:
>   - VIDEO_VIVID [=m] && MEDIA_SUPPORT [=m] && MEDIA_TEST_SUPPORT [=y] && V4L_TEST_DRIVERS [=y] && VIDEO_DEV [=m] && VIDEO_V4L2 [=m] && !SPARC32 &&
> !SPARC64 && FB [=y] && HAS_DMA [=y]
> 

Ugh, my bad. MEDIA_CONTROLLER_REQUEST_API can't
depend on staging, after this recently merged commit:

"media: Kconfig: Don't expose the Request API option"

So, we should fix that with:

diff --git a/drivers/media/mc/Kconfig b/drivers/media/mc/Kconfig
index 7c9628f37196..4815b9dde9af 100644
--- a/drivers/media/mc/Kconfig
+++ b/drivers/media/mc/Kconfig
@@ -14,7 +14,7 @@ config MEDIA_CONTROLLER_DVB
 
 config MEDIA_CONTROLLER_REQUEST_API
        bool
-       depends on MEDIA_CONTROLLER && STAGING_MEDIA
+       depends on MEDIA_CONTROLLER
        help
          DO NOT ENABLE THIS OPTION UNLESS YOU KNOW WHAT YOU'RE DOING.
 
Mauro what do you think?


^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: build warning after merge of the v4l-dvb tree
@ 2020-04-17  0:22 Stephen Rothwell
  2020-04-17  5:13 ` Ezequiel Garcia
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2020-04-17  0:22 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ezequiel Garcia


[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

Hi all,

After merging the v4l-dvb tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

WARNING: unmet direct dependencies detected for MEDIA_CONTROLLER_REQUEST_API
  Depends on [n]: MEDIA_SUPPORT [=m] && MEDIA_CONTROLLER [=y] && STAGING_MEDIA [=n]
  Selected by [m]:
  - VIDEO_VIVID [=m] && MEDIA_SUPPORT [=m] && MEDIA_TEST_SUPPORT [=y] && V4L_TEST_DRIVERS [=y] && VIDEO_DEV [=m] && VIDEO_V4L2 [=m] && !SPARC32 && !SPARC64 && FB [=y] && HAS_DMA [=y]

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: build warning after merge of the v4l-dvb tree
@ 2020-04-15  1:29 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2020-04-15  1:29 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

Hi all,

After merging the v4l-dvb tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

WARNING: unmet direct dependencies detected for CEC_CORE
  Depends on [m]: MEDIA_SUPPORT [=m]
  Selected by [y]:
  - DRM_TEGRA [=y] && HAS_IOMEM [=y] && (ARCH_TEGRA [=y] || ARM [=y] && COMPILE_TEST [=n]) && COMMON_CLK [=y] && DRM [=y] && OF [=y] && CEC_NOTIFIER [=y]
  Selected by [m]:
  - VIDEO_SAMSUNG_S5P_CEC [=m] && MEDIA_SUPPORT [=m] && MEDIA_PLATFORM_SUPPORT [=y] && CEC_PLATFORM_DRIVERS [=y] && (ARCH_EXYNOS [=y] || COMPILE_TEST [=n])
  - DRM_EXYNOS_HDMI [=y] && HAS_IOMEM [=y] && DRM_EXYNOS [=m] && (DRM_EXYNOS_MIXER [=y] || DRM_EXYNOS5433_DECON [=n]) && CEC_NOTIFIER [=y]
  - DRM_I2C_ADV7511_CEC [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_BRIDGE [=y] && DRM_I2C_ADV7511 [=m]
  - DRM_DW_HDMI [=m] && HAS_IOMEM [=y] && DRM [=y] && DRM_BRIDGE [=y] && CEC_NOTIFIER [=y]

There have been so many Kconfig changes today that I cannot figure out
what caused this, sorry.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: build warning after merge of the v4l-dvb tree
@ 2019-01-31 23:25 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2019-01-31 23:25 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Pawel Osciak,
	Paul Kocialkowski, Hans Verkuil


[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi all,

After merging the v4l-dvb tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/media/common/videobuf2/videobuf2-core.c: In function '__vb2_dqbuf':
drivers/media/common/videobuf2/videobuf2-core.c:1772:15: warning: unused variable 'i' [-Wunused-variable]
  unsigned int i;
               ^

Introduced by commit

  2cc1802f62e5 ("media: vb2: Keep dma-buf buffers mapped until they are freed")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: build warning after merge of the v4l-dvb tree
@ 2011-03-17  0:29 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2011-03-17  0:29 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-next, linux-kernel, Manjunatha Halli


[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

Hi Mauro,

After merging the v4l-dvb tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/media/radio/wl128x/fmdrv_common.c: In function 'recv_tasklet':
drivers/media/radio/wl128x/fmdrv_common.c:274: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'

Introduced by commit 38b9da379627 ("[media] drivers:media:radio: wl128x:
FM Driver Common sources").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: build warning after merge of the v4l-dvb tree
@ 2010-12-31  0:59 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2010-12-31  0:59 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-next, linux-kernel


[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

Hi Mauro,

After merging the v4l-dvb tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/media/video/ivtv/ivtv-i2c.c: In function 'get_key_adaptec':
drivers/media/video/ivtv/ivtv-i2c.c:170: warning: cast from pointer to integer of different size
drivers/media/video/ivtv/ivtv-i2c.c:171: warning: cast from pointer to integer of different size

Introduced by commit e1e2c57565635310209566a31a300e593f74cc22 ("[media]
ivtv: Add Adaptec Remote Controller").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: build warning after merge of the v4l-dvb tree
  2010-10-08  0:49 Stephen Rothwell
@ 2010-10-08  3:13 ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 10+ messages in thread
From: Mauro Carvalho Chehab @ 2010-10-08  3:13 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

Em 07-10-2010 21:49, Stephen Rothwell escreveu:
> Hi Mauro,
> 
> After merging the kvm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/media/video/videobuf-dma-sg.c: In function 'videobuf_pages_to_sg':
> drivers/media/video/videobuf-dma-sg.c:119: warning: comparison of distinct pointer types lacks a cast
> drivers/media/video/videobuf-dma-sg.c:120: warning: comparison of distinct pointer types lacks a cast
> 
> Commit ecc736735ecf922d7f31d34417f7c42f8ec9eb67 ("V4L/DVB:
> videobuf-dma-sg: Fix a warning due to the usage of min(PAGE_SIZE, arg)")
> tried to fix it (presumably on a 32 bit build), but is not correct for 64
> bits .
> 
Hi Stephen,

Thanks. I have already a fix for it, using min_t(size_t, PAGE_SIZE, arg).
I'll add it probably tomorrow for the linux-next tree.

Thanks,
Mauro

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: build warning after merge of the v4l-dvb tree
@ 2010-10-08  0:49 Stephen Rothwell
  2010-10-08  3:13 ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2010-10-08  0:49 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-next, linux-kernel


[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

Hi Mauro,

After merging the kvm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/media/video/videobuf-dma-sg.c: In function 'videobuf_pages_to_sg':
drivers/media/video/videobuf-dma-sg.c:119: warning: comparison of distinct pointer types lacks a cast
drivers/media/video/videobuf-dma-sg.c:120: warning: comparison of distinct pointer types lacks a cast

Commit ecc736735ecf922d7f31d34417f7c42f8ec9eb67 ("V4L/DVB:
videobuf-dma-sg: Fix a warning due to the usage of min(PAGE_SIZE, arg)")
tried to fix it (presumably on a 32 bit build), but is not correct for 64
bits .

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, back to index

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-21  2:07 linux-next: build warning after merge of the v4l-dvb tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2020-04-17  0:22 Stephen Rothwell
2020-04-17  5:13 ` Ezequiel Garcia
2020-04-17  7:01   ` Mauro Carvalho Chehab
2020-04-15  1:29 Stephen Rothwell
2019-01-31 23:25 Stephen Rothwell
2011-03-17  0:29 Stephen Rothwell
2010-12-31  0:59 Stephen Rothwell
2010-10-08  0:49 Stephen Rothwell
2010-10-08  3:13 ` Mauro Carvalho Chehab

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git