linux-next: Fixes tag needs some work in the block tree

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

Hi all,

In commit

  dc35ada4251f ("block: fix a warning when blkdev.h is included for !CONFIG_BLOCK builds")

Fixes tag

  Fixes: 956d510ee78 ("block: add disk/bio-based accounting helpers")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

Hi all,

In commit

  1c22e0295a5e ("nvmet: nul-terminate the NQNs passed in the connect command")

Fixes tag

  Fixes: a07b4970f464 "nvmet: add a generic NVMe target")

has these problem(s):

  - Subject has trailing but no leading parentheses.
    Just use
        git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Hi all,

In commit

  71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()")

Fixes tag

  Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: b39f35ebe86d ("md: don't quiesce in mddev_suspend()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Yu Kuai]

Hi,

在 2023/08/15 7:19, Stephen Rothwell 写道:
> Hi all,
> 
> In commit
> 
>    71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()")
> 
> Fixes tag
> 
>    Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()")
> 
> has these problem(s):
> 
>    - Target SHA1 does not exist

Sorry about this, the commit was picked from previous md-next branch,
and I didn't know that it will change...

Is there any way that I can fix this ?

Thanks,
Kuai

> 
> Maybe you meant
> 
> Fixes: b39f35ebe86d ("md: don't quiesce in mddev_suspend()")
> 

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 8/14/23 9:21 PM, Yu Kuai wrote:
> Hi,
> 
> ? 2023/08/15 7:19, Stephen Rothwell ??:
>> Hi all,
>>
>> In commit
>>
>>    71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()")
>>
>> Fixes tag
>>
>>    Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()")
>>
>> has these problem(s):
>>
>>    - Target SHA1 does not exist
> 
> Sorry about this, the commit was picked from previous md-next branch,
> and I didn't know that it will change...

It's most likely not your fault, I'm guessing Song rebased that branch
and this is why the sha changed. Song?

> Is there any way that I can fix this ?

Only way to fix this is if I rewind my branch and Song updates his
branch to not have this issue, and then sends a new pull request.

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Song Liu]

On Tue, Aug 15, 2023 at 11:08 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 8/14/23 9:21 PM, Yu Kuai wrote:
> > Hi,
> >
> > ? 2023/08/15 7:19, Stephen Rothwell ??:
> >> Hi all,
> >>
> >> In commit
> >>
> >>    71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()")
> >>
> >> Fixes tag
> >>
> >>    Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()")
> >>
> >> has these problem(s):
> >>
> >>    - Target SHA1 does not exist
> >
> > Sorry about this, the commit was picked from previous md-next branch,
> > and I didn't know that it will change...
>
> It's most likely not your fault, I'm guessing Song rebased that branch
> and this is why the sha changed. Song?

Yeah, it is my fault. I am really sorry for this issue.

>
> > Is there any way that I can fix this ?
>
> Only way to fix this is if I rewind my branch and Song updates his
> branch to not have this issue, and then sends a new pull request.

Yes please. Let's fix this.

Song

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 8/15/23 9:58 AM, Song Liu wrote:
> On Tue, Aug 15, 2023 at 11:08?PM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 8/14/23 9:21 PM, Yu Kuai wrote:
>>> Hi,
>>>
>>> ? 2023/08/15 7:19, Stephen Rothwell ??:
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>    71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()")
>>>>
>>>> Fixes tag
>>>>
>>>>    Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()")
>>>>
>>>> has these problem(s):
>>>>
>>>>    - Target SHA1 does not exist
>>>
>>> Sorry about this, the commit was picked from previous md-next branch,
>>> and I didn't know that it will change...
>>
>> It's most likely not your fault, I'm guessing Song rebased that branch
>> and this is why the sha changed. Song?
> 
> Yeah, it is my fault. I am really sorry for this issue.
> 
>>
>>> Is there any way that I can fix this ?
>>
>> Only way to fix this is if I rewind my branch and Song updates his
>> branch to not have this issue, and then sends a new pull request.
> 
> Yes please. Let's fix this.

Please send a new one, I've dropped the old one.

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Song Liu]

On Wed, Aug 16, 2023 at 12:07 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 8/15/23 9:58 AM, Song Liu wrote:
> > On Tue, Aug 15, 2023 at 11:08?PM Jens Axboe <axboe@kernel.dk> wrote:
> >>
> >> On 8/14/23 9:21 PM, Yu Kuai wrote:
> >>> Hi,
> >>>
> >>> ? 2023/08/15 7:19, Stephen Rothwell ??:
> >>>> Hi all,
> >>>>
> >>>> In commit
> >>>>
> >>>>    71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()")
> >>>>
> >>>> Fixes tag
> >>>>
> >>>>    Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()")
> >>>>
> >>>> has these problem(s):
> >>>>
> >>>>    - Target SHA1 does not exist
> >>>
> >>> Sorry about this, the commit was picked from previous md-next branch,
> >>> and I didn't know that it will change...
> >>
> >> It's most likely not your fault, I'm guessing Song rebased that branch
> >> and this is why the sha changed. Song?
> >
> > Yeah, it is my fault. I am really sorry for this issue.
> >
> >>
> >>> Is there any way that I can fix this ?
> >>
> >> Only way to fix this is if I rewind my branch and Song updates his
> >> branch to not have this issue, and then sends a new pull request.
> >
> > Yes please. Let's fix this.
>
> Please send a new one, I've dropped the old one.

Is this the for-6.6/block branch? I haven't seen the change yet. The top
commit on the branch (as I see) is

306d74055754 ("ublk: Switch to memdup_user_nul() helper")

Thanks,
Song

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 8/15/23 10:17 AM, Song Liu wrote:
> On Wed, Aug 16, 2023 at 12:07?AM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 8/15/23 9:58 AM, Song Liu wrote:
>>> On Tue, Aug 15, 2023 at 11:08?PM Jens Axboe <axboe@kernel.dk> wrote:
>>>>
>>>> On 8/14/23 9:21 PM, Yu Kuai wrote:
>>>>> Hi,
>>>>>
>>>>> ? 2023/08/15 7:19, Stephen Rothwell ??:
>>>>>> Hi all,
>>>>>>
>>>>>> In commit
>>>>>>
>>>>>>    71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()")
>>>>>>
>>>>>> Fixes tag
>>>>>>
>>>>>>    Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()")
>>>>>>
>>>>>> has these problem(s):
>>>>>>
>>>>>>    - Target SHA1 does not exist
>>>>>
>>>>> Sorry about this, the commit was picked from previous md-next branch,
>>>>> and I didn't know that it will change...
>>>>
>>>> It's most likely not your fault, I'm guessing Song rebased that branch
>>>> and this is why the sha changed. Song?
>>>
>>> Yeah, it is my fault. I am really sorry for this issue.
>>>
>>>>
>>>>> Is there any way that I can fix this ?
>>>>
>>>> Only way to fix this is if I rewind my branch and Song updates his
>>>> branch to not have this issue, and then sends a new pull request.
>>>
>>> Yes please. Let's fix this.
>>
>> Please send a new one, I've dropped the old one.
> 
> Is this the for-6.6/block branch? I haven't seen the change yet. The top
> commit on the branch (as I see) is
> 
> 306d74055754 ("ublk: Switch to memdup_user_nul() helper")

Where are you looking? It's at:

commit 66a6a5d0ec852eaced589da066376e69397cd71e (origin/for-6.6/block, for-6.6/block)
Author: Ruan Jinjie <ruanjinjie@huawei.com>
Date:   Tue Aug 15 19:48:14 2023 +0800

    ublk: Switch to memdup_user_nul() helper

since about 15 min ago.

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Song Liu]

On Wed, Aug 16, 2023 at 12:20 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 8/15/23 10:17 AM, Song Liu wrote:
> > On Wed, Aug 16, 2023 at 12:07?AM Jens Axboe <axboe@kernel.dk> wrote:
> >>
> >> On 8/15/23 9:58 AM, Song Liu wrote:
> >>> On Tue, Aug 15, 2023 at 11:08?PM Jens Axboe <axboe@kernel.dk> wrote:
> >>>>
> >>>> On 8/14/23 9:21 PM, Yu Kuai wrote:
> >>>>> Hi,
> >>>>>
> >>>>> ? 2023/08/15 7:19, Stephen Rothwell ??:
> >>>>>> Hi all,
> >>>>>>
> >>>>>> In commit
> >>>>>>
> >>>>>>    71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()")
> >>>>>>
> >>>>>> Fixes tag
> >>>>>>
> >>>>>>    Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()")
> >>>>>>
> >>>>>> has these problem(s):
> >>>>>>
> >>>>>>    - Target SHA1 does not exist
> >>>>>
> >>>>> Sorry about this, the commit was picked from previous md-next branch,
> >>>>> and I didn't know that it will change...
> >>>>
> >>>> It's most likely not your fault, I'm guessing Song rebased that branch
> >>>> and this is why the sha changed. Song?
> >>>
> >>> Yeah, it is my fault. I am really sorry for this issue.
> >>>
> >>>>
> >>>>> Is there any way that I can fix this ?
> >>>>
> >>>> Only way to fix this is if I rewind my branch and Song updates his
> >>>> branch to not have this issue, and then sends a new pull request.
> >>>
> >>> Yes please. Let's fix this.
> >>
> >> Please send a new one, I've dropped the old one.
> >
> > Is this the for-6.6/block branch? I haven't seen the change yet. The top
> > commit on the branch (as I see) is
> >
> > 306d74055754 ("ublk: Switch to memdup_user_nul() helper")
>
> Where are you looking? It's at:

I am looking at

https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git

It appears to be some lag from git server?

Thanks,
Song

>
> commit 66a6a5d0ec852eaced589da066376e69397cd71e (origin/for-6.6/block, for-6.6/block)
> Author: Ruan Jinjie <ruanjinjie@huawei.com>
> Date:   Tue Aug 15 19:48:14 2023 +0800
>
>     ublk: Switch to memdup_user_nul() helper
>
> since about 15 min ago.

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 8/15/23 10:26 AM, Song Liu wrote:
> On Wed, Aug 16, 2023 at 12:20?AM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 8/15/23 10:17 AM, Song Liu wrote:
>>> On Wed, Aug 16, 2023 at 12:07?AM Jens Axboe <axboe@kernel.dk> wrote:
>>>>
>>>> On 8/15/23 9:58 AM, Song Liu wrote:
>>>>> On Tue, Aug 15, 2023 at 11:08?PM Jens Axboe <axboe@kernel.dk> wrote:
>>>>>>
>>>>>> On 8/14/23 9:21 PM, Yu Kuai wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> ? 2023/08/15 7:19, Stephen Rothwell ??:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> In commit
>>>>>>>>
>>>>>>>>    71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()")
>>>>>>>>
>>>>>>>> Fixes tag
>>>>>>>>
>>>>>>>>    Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()")
>>>>>>>>
>>>>>>>> has these problem(s):
>>>>>>>>
>>>>>>>>    - Target SHA1 does not exist
>>>>>>>
>>>>>>> Sorry about this, the commit was picked from previous md-next branch,
>>>>>>> and I didn't know that it will change...
>>>>>>
>>>>>> It's most likely not your fault, I'm guessing Song rebased that branch
>>>>>> and this is why the sha changed. Song?
>>>>>
>>>>> Yeah, it is my fault. I am really sorry for this issue.
>>>>>
>>>>>>
>>>>>>> Is there any way that I can fix this ?
>>>>>>
>>>>>> Only way to fix this is if I rewind my branch and Song updates his
>>>>>> branch to not have this issue, and then sends a new pull request.
>>>>>
>>>>> Yes please. Let's fix this.
>>>>
>>>> Please send a new one, I've dropped the old one.
>>>
>>> Is this the for-6.6/block branch? I haven't seen the change yet. The top
>>> commit on the branch (as I see) is
>>>
>>> 306d74055754 ("ublk: Switch to memdup_user_nul() helper")
>>
>> Where are you looking? It's at:
> 
> I am looking at
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> 
> It appears to be some lag from git server?

That's just a backup, I always pull and push from git.kernel.dk. The
korg one will lag about an hour, depending on when things are pushed.
I've never used the korg one as the canonical location.

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Song Liu]

On Wed, Aug 16, 2023 at 12:31 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 8/15/23 10:26 AM, Song Liu wrote:
> > On Wed, Aug 16, 2023 at 12:20?AM Jens Axboe <axboe@kernel.dk> wrote:
> >>
> >> On 8/15/23 10:17 AM, Song Liu wrote:
> >>> On Wed, Aug 16, 2023 at 12:07?AM Jens Axboe <axboe@kernel.dk> wrote:
> >>>>
> >>>> On 8/15/23 9:58 AM, Song Liu wrote:
> >>>>> On Tue, Aug 15, 2023 at 11:08?PM Jens Axboe <axboe@kernel.dk> wrote:
> >>>>>>
> >>>>>> On 8/14/23 9:21 PM, Yu Kuai wrote:
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>> ? 2023/08/15 7:19, Stephen Rothwell ??:
> >>>>>>>> Hi all,
> >>>>>>>>
> >>>>>>>> In commit
> >>>>>>>>
> >>>>>>>>    71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()")
> >>>>>>>>
> >>>>>>>> Fixes tag
> >>>>>>>>
> >>>>>>>>    Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()")
> >>>>>>>>
> >>>>>>>> has these problem(s):
> >>>>>>>>
> >>>>>>>>    - Target SHA1 does not exist
> >>>>>>>
> >>>>>>> Sorry about this, the commit was picked from previous md-next branch,
> >>>>>>> and I didn't know that it will change...
> >>>>>>
> >>>>>> It's most likely not your fault, I'm guessing Song rebased that branch
> >>>>>> and this is why the sha changed. Song?
> >>>>>
> >>>>> Yeah, it is my fault. I am really sorry for this issue.
> >>>>>
> >>>>>>
> >>>>>>> Is there any way that I can fix this ?
> >>>>>>
> >>>>>> Only way to fix this is if I rewind my branch and Song updates his
> >>>>>> branch to not have this issue, and then sends a new pull request.
> >>>>>
> >>>>> Yes please. Let's fix this.
> >>>>
> >>>> Please send a new one, I've dropped the old one.
> >>>
> >>> Is this the for-6.6/block branch? I haven't seen the change yet. The top
> >>> commit on the branch (as I see) is
> >>>
> >>> 306d74055754 ("ublk: Switch to memdup_user_nul() helper")
> >>
> >> Where are you looking? It's at:
> >
> > I am looking at
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> >
> > It appears to be some lag from git server?
>
> That's just a backup, I always pull and push from git.kernel.dk. The
> korg one will lag about an hour, depending on when things are pushed.
> I've never used the korg one as the canonical location.

Got it. I will update my git config.

Here is the updated PR:


The following changes since commit 66a6a5d0ec852eaced589da066376e69397cd71e:

  ublk: Switch to memdup_user_nul() helper (2023-08-15 10:06:54 -0600)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git
tags/md-next-20230814-resend

for you to fetch changes up to 0d0bd28c500173bfca78aa840f8f36d261ef1765:

  md/raid5-cache: fix null-ptr-deref for r5l_flush_stripe_to_raid()
(2023-08-15 09:40:27 -0700)

----------------------------------------------------------------
Li Lingfeng (1):
      md: Hold mddev->reconfig_mutex when trying to get mddev->sync_thread

WANG Xuerui (5):
      raid6: remove the <linux/export.h> include from recov.c
      raid6: guard the tables.c include of <linux/export.h> with __KERNEL__
      raid6: test: cosmetic cleanups for the test Makefile
      raid6: test: make sure all intermediate and artifact files are .gitignored
      raid6: test: only check for Altivec if building on powerpc hosts

Yu Kuai (3):
      md/raid5-cache: fix a deadlock in r5l_exit_log()
      md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()
      md/raid5-cache: fix null-ptr-deref for r5l_flush_stripe_to_raid()

Zhang Shurong (1):
      md: raid1: fix potential OOB in raid1_remove_disk()

 drivers/md/md-cluster.c   |  8 ++++----
 drivers/md/md.c           |  9 +++++----
 drivers/md/md.h           |  2 +-
 drivers/md/raid1.c        |  8 ++++++--
 drivers/md/raid10.c       |  3 +--
 drivers/md/raid5-cache.c  | 14 ++++++++------
 drivers/md/raid5.c        |  2 +-
 lib/raid6/mktables.c      |  2 ++
 lib/raid6/recov.c         |  1 -
 lib/raid6/test/.gitignore |  3 +++
 lib/raid6/test/Makefile   | 50
++++++++++++++++++++++++++------------------------
 11 files changed, 57 insertions(+), 45 deletions(-)
 create mode 100644 lib/raid6/test/.gitignore


Thanks,
Song

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 8/15/23 10:51 AM, Song Liu wrote:
> On Wed, Aug 16, 2023 at 12:31?AM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 8/15/23 10:26 AM, Song Liu wrote:
>>> On Wed, Aug 16, 2023 at 12:20?AM Jens Axboe <axboe@kernel.dk> wrote:
>>>>
>>>> On 8/15/23 10:17 AM, Song Liu wrote:
>>>>> On Wed, Aug 16, 2023 at 12:07?AM Jens Axboe <axboe@kernel.dk> wrote:
>>>>>>
>>>>>> On 8/15/23 9:58 AM, Song Liu wrote:
>>>>>>> On Tue, Aug 15, 2023 at 11:08?PM Jens Axboe <axboe@kernel.dk> wrote:
>>>>>>>>
>>>>>>>> On 8/14/23 9:21 PM, Yu Kuai wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> ? 2023/08/15 7:19, Stephen Rothwell ??:
>>>>>>>>>> Hi all,
>>>>>>>>>>
>>>>>>>>>> In commit
>>>>>>>>>>
>>>>>>>>>>    71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()")
>>>>>>>>>>
>>>>>>>>>> Fixes tag
>>>>>>>>>>
>>>>>>>>>>    Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()")
>>>>>>>>>>
>>>>>>>>>> has these problem(s):
>>>>>>>>>>
>>>>>>>>>>    - Target SHA1 does not exist
>>>>>>>>>
>>>>>>>>> Sorry about this, the commit was picked from previous md-next branch,
>>>>>>>>> and I didn't know that it will change...
>>>>>>>>
>>>>>>>> It's most likely not your fault, I'm guessing Song rebased that branch
>>>>>>>> and this is why the sha changed. Song?
>>>>>>>
>>>>>>> Yeah, it is my fault. I am really sorry for this issue.
>>>>>>>
>>>>>>>>
>>>>>>>>> Is there any way that I can fix this ?
>>>>>>>>
>>>>>>>> Only way to fix this is if I rewind my branch and Song updates his
>>>>>>>> branch to not have this issue, and then sends a new pull request.
>>>>>>>
>>>>>>> Yes please. Let's fix this.
>>>>>>
>>>>>> Please send a new one, I've dropped the old one.
>>>>>
>>>>> Is this the for-6.6/block branch? I haven't seen the change yet. The top
>>>>> commit on the branch (as I see) is
>>>>>
>>>>> 306d74055754 ("ublk: Switch to memdup_user_nul() helper")
>>>>
>>>> Where are you looking? It's at:
>>>
>>> I am looking at
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
>>>
>>> It appears to be some lag from git server?
>>
>> That's just a backup, I always pull and push from git.kernel.dk. The
>> korg one will lag about an hour, depending on when things are pushed.
>> I've never used the korg one as the canonical location.
> 
> Got it. I will update my git config.
> 
> Here is the updated PR:
> 
> 
> The following changes since commit 66a6a5d0ec852eaced589da066376e69397cd71e:
> 
>   ublk: Switch to memdup_user_nul() helper (2023-08-15 10:06:54 -0600)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git
> tags/md-next-20230814-resend

Pulled.

-- 
Jens Axboe

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

Hi all,

[Also in the device-mapper tree]

In commit

  900095bfbbf6 ("nvme-fabrics: error out to unlock the mutex")

Fixes tag

  Fixes: f0cebf82004d ("nvme-fabrics: prevent overriding of existing host")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: ae8bd606e09b ("nvme-fabrics: prevent overriding of existing host")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Chaitanya Kulkarni]

On 6/18/23 15:22, Stephen Rothwell wrote:
> Hi all,
>
> [Also in the device-mapper tree]
>
> In commit
>
>    900095bfbbf6 ("nvme-fabrics: error out to unlock the mutex")
>
> Fixes tag
>
>    Fixes: f0cebf82004d ("nvme-fabrics: prevent overriding of existing host")
sorry I didn't understand this with above tag I could format a patch
that leads to above subject line :-

nvme (nvme-6.5) # git format-patch f0cebf82004d -1
0001-nvme-fabrics-prevent-overriding-of-existing-host.patch
  directory
nvme (nvme-6.5) # cat 
0001-nvme-fabrics-prevent-overriding-of-existing-host.patch
 From f0cebf82004d610be3ef47abf315ddf95aa2dcd1 Mon Sep 17 00:00:00 2001
From: Max Gurtovoy <mgurtovoy@nvidia.com>
Date: Fri, 12 May 2023 18:41:55 +0300
Subject: [PATCH] nvme-fabrics: prevent overriding of existing host

When first connecting a target using the "default" host parameters,
setting the hostid from the command line during a subsequent connection
establishment would override the "default" hostid parameter. This would
cause an existing connection that is already using the host definitions
to lose its hostid.

To address this issue, the code has been modified to allow only 1:1
mapping between hostnqn and hostid. This will maintain unambiguous host
identification. Any non 1:1 mapping will be rejected during connection
establishment.

Tested-by: Noam Gottlieb <ngottlieb@nvidia.com>
Reviewed-by: Israel Rukshin <israelr@nvidia.com>
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---

> has these problem(s):
>
>    - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: ae8bd606e09b ("nvme-fabrics: prevent overriding of existing host")
>

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi all,

In commit

  3dbd53c7be1c ("swim3: fix the floppy_locked_ioctl prototype")

Fixes tag

  Fixes: b60f7635788a ("swim3: fix the floppy_locked_ioctl prototype")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 05bdb9965305 ("block: replace fmode_t with a block-specific type for block open flags")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Hi all,

In commit

  aa939e415c6c ("blk-mq: remove hybrid polling")

Fixes tags

  Fixes: 9650b453a3d4b1, "block: ignore RWF_HIPRI hint for sync dio"
  Fixes: d729cf9acb93119, "io_uring: don't sleep when polling for I/O"

have these problem(s):

  - missing space between the SHA1 and the subject
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

So:

Fixes: 9650b453a3d4 ("block: ignore RWF_HIPRI hint for sync dio")
Fixes: d729cf9acb93 ("io_uring: don't sleep when polling for I/O")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 3/20/23 3:28 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   aa939e415c6c ("blk-mq: remove hybrid polling")
> 
> Fixes tags
> 
>   Fixes: 9650b453a3d4b1, "block: ignore RWF_HIPRI hint for sync dio"
>   Fixes: d729cf9acb93119, "io_uring: don't sleep when polling for I/O"

Oops, too much copying. Fixed them up.

-- 
Jens Axboe

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

Hi all,

In commit

  4b49197f9fbd ("block: mq-deadline: Rename deadline_is_seq_writes()")

Fixes tag

  Fixes: 015d02f4853 ("block: mq-deadline: Do not break sequential write streams to zoned HDDs")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Damien Le Moal]

On 11/29/22 06:27, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   4b49197f9fbd ("block: mq-deadline: Rename deadline_is_seq_writes()")
> 
> Fixes tag
> 
>   Fixes: 015d02f4853 ("block: mq-deadline: Do not break sequential write streams to zoned HDDs")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").

Oops. Sorry about that. It seems I cannot count up to 12 anymore :)
It should be:

Fixes: 015d02f48537 ("block: mq-deadline: Do not break sequential write
streams to zoned HDDs")

Jens, can you fix this ?

-- 
Damien Le Moal
Western Digital Research

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 11/28/22 4:39?PM, Damien Le Moal wrote:
> On 11/29/22 06:27, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>>   4b49197f9fbd ("block: mq-deadline: Rename deadline_is_seq_writes()")
>>
>> Fixes tag
>>
>>   Fixes: 015d02f4853 ("block: mq-deadline: Do not break sequential write streams to zoned HDDs")
>>
>> has these problem(s):
>>
>>   - SHA1 should be at least 12 digits long
>>     This can be fixed for the future by setting core.abbrev to 12 (or
>>     more) or (for git v2.11 or later) just making sure it is not set
>>     (or set to "auto").
> 
> Oops. Sorry about that. It seems I cannot count up to 12 anymore :)
> It should be:
> 
> Fixes: 015d02f48537 ("block: mq-deadline: Do not break sequential write
> streams to zoned HDDs")
> 
> Jens, can you fix this ?

Sure, it's not that important though as it's just missing one digit. For
the record, this is what I have in my .gitconfig :

[alias]
fixes = log -1 --format=fixes

[pretty]
fixes = Fixes: %h (\"%s\")

[core]
abbrev = 12

and then you just do 'git fixes <sha>' and it spits out the line for the
commit without needing to count anything and eliminates this error.


-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Damien Le Moal]

On 11/29/22 11:30, Jens Axboe wrote:
> On 11/28/22 4:39?PM, Damien Le Moal wrote:
>> On 11/29/22 06:27, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>>   4b49197f9fbd ("block: mq-deadline: Rename deadline_is_seq_writes()")
>>>
>>> Fixes tag
>>>
>>>   Fixes: 015d02f4853 ("block: mq-deadline: Do not break sequential write streams to zoned HDDs")
>>>
>>> has these problem(s):
>>>
>>>   - SHA1 should be at least 12 digits long
>>>     This can be fixed for the future by setting core.abbrev to 12 (or
>>>     more) or (for git v2.11 or later) just making sure it is not set
>>>     (or set to "auto").
>>
>> Oops. Sorry about that. It seems I cannot count up to 12 anymore :)
>> It should be:
>>
>> Fixes: 015d02f48537 ("block: mq-deadline: Do not break sequential write
>> streams to zoned HDDs")
>>
>> Jens, can you fix this ?
> 
> Sure, it's not that important though as it's just missing one digit. For
> the record, this is what I have in my .gitconfig :
> 
> [alias]
> fixes = log -1 --format=fixes
> 
> [pretty]
> fixes = Fixes: %h (\"%s\")
> 
> [core]
> abbrev = 12
> 
> and then you just do 'git fixes <sha>' and it spits out the line for the
> commit without needing to count anything and eliminates this error.

Thanks for the info. Will try this !

-- 
Damien Le Moal
Western Digital Research

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Hi all,

In commit

  5509e85fd887 ("nvme: use command_id instead of req->tag in trace_nvme_complete_rq()")

Fixes tag

  Fixes: e7006de6c238 ("nvme: code command_id with a genctr for use authentication after release")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

So

Fixes: e7006de6c238 ("nvme: code command_id with a genctr for use-after-free validation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Hi all,

In commit

  1da6baa4e4c2 ("io_uring: move io_uring_get_opcode out of TP_printk")

Fixes tag

  Fixes: 033b87d2 ("io_uring: use the text representation of ops in trace")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 6/22/22 5:21 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   1da6baa4e4c2 ("io_uring: move io_uring_get_opcode out of TP_printk")
> 
> Fixes tag
> 
>   Fixes: 033b87d2 ("io_uring: use the text representation of ops in trace")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").

I'll rebase on -rc4 anyway, I'll fix thie one up.

Dylan, here's what I use for adding Fixes tags:

[pretty]
        fixes = Fixes: %h (\"%s\")

and then I just do:

git fixes 033b87d2
Fixes: 033b87d24f72 ("io_uring: use the text representation of ops in trace")

to generate it.

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Dylan Yudaken]

On Wed, 2022-06-22 at 17:44 -0600, Jens Axboe wrote:
> On 6/22/22 5:21 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   1da6baa4e4c2 ("io_uring: move io_uring_get_opcode out of
> > TP_printk")
> > 
> > Fixes tag
> > 
> >   Fixes: 033b87d2 ("io_uring: use the text representation of ops in
> > trace")
> > 
> > has these problem(s):
> > 
> >   - SHA1 should be at least 12 digits long
> >     This can be fixed for the future by setting core.abbrev to 12
> > (or
> >     more) or (for git v2.11 or later) just making sure it is not
> > set
> >     (or set to "auto").
> 
> I'll rebase on -rc4 anyway, I'll fix thie one up.
> 
> Dylan, here's what I use for adding Fixes tags:
> 
> [pretty]
>         fixes = Fixes: %h (\"%s\")
> 
> and then I just do:
> 
> git fixes 033b87d2
> Fixes: 033b87d24f72 ("io_uring: use the text representation of ops in
> trace")
> 
> to generate it.
> 

Thanks! I'll automate it next time as obviously by hand is nuts

Dylan

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hi all,

In commit

  57668f0a4cc4 ("raid5: introduce MD_BROKEN")

Fixes tag

  Fixes: fb73b357fb9 ("raid5: block failing device if raid will be failed")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

Hi all,

In commit

  15583a563cd5 ("block: restore the old set_task_ioprio() behaviour wrt PF_EXITING")

Fixes tags

  Fixes: 5fc11eebb4 (block: open code create_task_io_context in set_task_ioprio)
  Fixes: a957b61254 (block: fix error in handling dead task for ioprio setting)

have this problem:

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

Hi all,

In commit

  c30cf83999ad ("crytpo: fix crc64 testmgr digest byte order")

Fixes tag

  Fixes: commit f3813f4b287e4 ("crypto: add rocksoft 64b crc guard tag framework")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 3/22/22 2:49 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   c30cf83999ad ("crytpo: fix crc64 testmgr digest byte order")
> 
> Fixes tag
> 
>   Fixes: commit f3813f4b287e4 ("crypto: add rocksoft 64b crc guard tag framework")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected

And misspelled commit title - I fixed both up, thanks Stephen.

-- 
Jens Axboe

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Hi all,

In commit

  3a605e32a7f8 ("nvme: drop unused variable ctrl in nvme_setup_cmd")

Fixes tag

  Fixes: 292ddf67bbd5 ("nvme: increment request genctr on completion")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: e4fdb2b167ed ("nvme: increment request genctr on completion")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi all,

In commit

  2fc428f6b7ca ("block, bfq: fix UAF problem in bfqg_stats_init()")

Fixes tag

  Fixes: commit fd41e60331b ("bfq-iosched: stop using blkg->stat_bytes and ->stat_ios")

has these problem(s):

  - leading word 'commit' unexpected
  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

Hi all,

In commit

  071e5f53b789 ("block: always initialize bio->bi_pool")

Fixes tag

  Fixes: Fixes: a4aa1b0494ea ("bio: optimize initialization of a bio")

has these problem(s):

  - Extra "Fixes:" word

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

Hi all,

In commit

  1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")

Fixes tag

  Fixes: 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

or

Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Sergey Shtylyov]

Hello!

On 5/19/21 1:01 AM, Stephen Rothwell wrote:

[...]
> In commit
> 
>   1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")
> 
> Fixes tag
> 
>   Fixes: 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Maybe you meant
> 
> Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

   This one!

> or
> 
> Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")

   Perhaps this could be fixed still, Jens?

MBR, Sergey

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 5/19/21 1:25 PM, Sergey Shtylyov wrote:
> Hello!
> 
> On 5/19/21 1:01 AM, Stephen Rothwell wrote:
> 
> [...]
>> In commit
>>
>>   1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")
>>
>> Fixes tag
>>
>>   Fixes: 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
>>
>> has these problem(s):
>>
>>   - Subject does not match target commit subject
>>     Just use
>> 	git log -1 --format='Fixes: %h ("%s")'
>>
>> Maybe you meant
>>
>> Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
> 
>    This one!
> 
>> or
>>
>> Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")
> 
>    Perhaps this could be fixed still, Jens?

Yep, I fixed it up, thanks.

-- 
Jens Axboe

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

In commit

  48145b62563a ("nvme: fix controller ioctl through ns_head")

Fixes tag

  Fixes: 3557a4409701 ("nvme: don't bother to look up a namespace for

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Minwoo Im]

Hello,

Sorry for the late reply, and appreciate pointing that out :)
I will keep that in mind.

Thanks!

On Thu, May 6, 2021 at 7:23 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   48145b62563a ("nvme: fix controller ioctl through ns_head")
>
> Fixes tag
>
>   Fixes: 3557a4409701 ("nvme: don't bother to look up a namespace for
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
>
> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

Hi all,

In commit

  284e4cdb0c0b ("nvme-hwmon: Return error code when registration fails")

Fixes tag

  Fixes: ec420cdcfab4 ("nvme/hwmon: rework to avoid devm allocation")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: ed7770f66286 ("nvme-hwmon: rework to avoid devm allocation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 3/4/21 4:52 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   284e4cdb0c0b ("nvme-hwmon: Return error code when registration fails")
> 
> Fixes tag
> 
>   Fixes: ec420cdcfab4 ("nvme/hwmon: rework to avoid devm allocation")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: ed7770f66286 ("nvme-hwmon: rework to avoid devm allocation")

Christoph, since there's multiple commits with issues, mind resending
a fixed branch? Then I'll drop the one I pulled today.


-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Christoph Hellwig]

On Thu, Mar 04, 2021 at 05:26:42PM -0700, Jens Axboe wrote:
> Christoph, since there's multiple commits with issues, mind resending
> a fixed branch? Then I'll drop the one I pulled today.

I've fixed the commit id and dropped the patch without the author
signoff, but your branch still has the current patches.

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 3/5/21 12:46 AM, Christoph Hellwig wrote:
> On Thu, Mar 04, 2021 at 05:26:42PM -0700, Jens Axboe wrote:
>> Christoph, since there's multiple commits with issues, mind resending
>> a fixed branch? Then I'll drop the one I pulled today.
> 
> I've fixed the commit id and dropped the patch without the author
> signoff, but your branch still has the current patches.

Killed it this morning, please resend it. Plan on shipping to Linus
today so we ensure we hit -rc2.

-- 
Jens Axboe

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi all,

In commit

  179d16007236 ("block: remove superfluous param in blk_fill_rwbs()")

Fixes tag

  Fixes: 1b9a9ab78b0 ("blktrace: use op accessors")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Chaitanya Kulkarni]

On 2/22/21 13:01, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>   179d16007236 ("block: remove superfluous param in blk_fill_rwbs()")
>
> Fixes tag
>
>   Fixes: 1b9a9ab78b0 ("blktrace: use op accessors")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
>
> -- Cheers, Stephen Rothwell

Yes, it was my fault it should be 1b9a9ab78b0a the last 'a' is missing.

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

In commit

  76676c992506 ("io_uring: fix io_rsrc_ref_quiesce races")

Fixes tag

  Fixes: 0ce4a72632317 ("io_uring: don't hold uring_lock when calling io_run_task_work*")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: a4f2225d1cb2 ("io_uring: don't hold uring_lock when calling io_run_task_work*")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 2/19/21 9:51 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   76676c992506 ("io_uring: fix io_rsrc_ref_quiesce races")
> 
> Fixes tag
> 
>   Fixes: 0ce4a72632317 ("io_uring: don't hold uring_lock when calling io_run_task_work*")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: a4f2225d1cb2 ("io_uring: don't hold uring_lock when calling io_run_task_work*")

Fixed it up, thanks Stephen.

-- 
Jens Axboe

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

Hi all,

In commit

  8a0c014cd205 ("floppy: reintroduce O_NDELAY fix")

Fixes tag

  Fixes: 09954bad4 ("floppy: refactor open() flags handling")

has these problem(s):

  - SHA1 should be at least 12 digits long

Fixes tag

  Fixes: f2791e7ead ("Revert "floppy: refactor open() flags handling"")

has these problem(s):

  - SHA1 should be at least 12 digits long

These can be fixed for future commits by setting core.abbrev to 12
(or more) or (for git v2.11 or later) just making sure it is not set
(or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

In commit

  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")

Fixes tag

  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Paolo Valente]

> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
> 
> Hi all,
> 
> In commit
> 
>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
> 
> Fixes tag
> 
>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
> 
> has these problem(s):
> 
>  - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
> 

Hi Jens,
how to proceed in such a case (with patches already applied by you)?
Shall I send you a v2 with only this change?

Thanks,
Paolo

> -- 
> Cheers,
> Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 1/25/21 11:35 AM, Paolo Valente wrote:
> 
> 
>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
>>
>> Hi all,
>>
>> In commit
>>
>>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
>>
>> Fixes tag
>>
>>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
>>
>> has these problem(s):
>>
>>  - Target SHA1 does not exist
>>
>> Maybe you meant
>>
>> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
>>
> 
> Hi Jens,
> how to proceed in such a case (with patches already applied by you)?
> Shall I send you a v2 with only this change?

We just have to ignore it... But in the future, always double check that
you are using the right shas, not some sha from an internal tree.

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Jan Kara]

On Mon 25-01-21 11:39:50, Jens Axboe wrote:
> On 1/25/21 11:35 AM, Paolo Valente wrote:
> > 
> > 
> >> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
> >>
> >> Hi all,
> >>
> >> In commit
> >>
> >>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
> >>
> >> Fixes tag
> >>
> >>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
> >>
> >> has these problem(s):
> >>
> >>  - Target SHA1 does not exist
> >>
> >> Maybe you meant
> >>
> >> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
> >>
> > 
> > Hi Jens,
> > how to proceed in such a case (with patches already applied by you)?
> > Shall I send you a v2 with only this change?
> 
> We just have to ignore it... But in the future, always double check that
> you are using the right shas, not some sha from an internal tree.

FWIW I have a commit hook in my git tree that just refuses a commit with
unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
merge...

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 1/26/21 6:29 AM, Jan Kara wrote:
> On Mon 25-01-21 11:39:50, Jens Axboe wrote:
>> On 1/25/21 11:35 AM, Paolo Valente wrote:
>>>
>>>
>>>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
>>>>
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
>>>>
>>>> Fixes tag
>>>>
>>>>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
>>>>
>>>> has these problem(s):
>>>>
>>>>  - Target SHA1 does not exist
>>>>
>>>> Maybe you meant
>>>>
>>>> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
>>>>
>>>
>>> Hi Jens,
>>> how to proceed in such a case (with patches already applied by you)?
>>> Shall I send you a v2 with only this change?
>>
>> We just have to ignore it... But in the future, always double check that
>> you are using the right shas, not some sha from an internal tree.
> 
> FWIW I have a commit hook in my git tree that just refuses a commit with
> unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
> merge...

That's not a bad idea, would help catch it upfront. Can you share the
hook?

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Jan Kara]

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

On Tue 26-01-21 08:47:55, Jens Axboe wrote:
> On 1/26/21 6:29 AM, Jan Kara wrote:
> > On Mon 25-01-21 11:39:50, Jens Axboe wrote:
> >> On 1/25/21 11:35 AM, Paolo Valente wrote:
> >>>
> >>>
> >>>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
> >>>>
> >>>> Hi all,
> >>>>
> >>>> In commit
> >>>>
> >>>>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
> >>>>
> >>>> Fixes tag
> >>>>
> >>>>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
> >>>>
> >>>> has these problem(s):
> >>>>
> >>>>  - Target SHA1 does not exist
> >>>>
> >>>> Maybe you meant
> >>>>
> >>>> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
> >>>>
> >>>
> >>> Hi Jens,
> >>> how to proceed in such a case (with patches already applied by you)?
> >>> Shall I send you a v2 with only this change?
> >>
> >> We just have to ignore it... But in the future, always double check that
> >> you are using the right shas, not some sha from an internal tree.
> > 
> > FWIW I have a commit hook in my git tree that just refuses a commit with
> > unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
> > merge...
> 
> That's not a bad idea, would help catch it upfront. Can you share the
> hook?

Sure, attached. Note that the hook just gets commit ID from the Fixes tag
and formats it with 12 commit ID digits and appropriate commit subject.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

[-- Attachment #2: commit-msg --]
[-- Type: text/plain, Size: 700 bytes --]

#!/bin/sh
#
# Called by "git commit" with one argument, the name of the file
# that has the commit message.  The hook should exit with non-zero
# status after issuing an appropriate message if it wants to stop the
# commit.  The hook is allowed to edit the commit message file.

# Process all Fixes tags, check commit IDs and set appropriate commit titles.

for COMMIT in $(sed -n -e 's/^Fixes: \([0-9a-z]*\).*/\1/p' "$1"); do
	GOOD=$(git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" $COMMIT -- 2>/dev/null)
	if [ -z "$GOOD" ]; then
		echo "Unknown commit: $COMMIT"
		exit 1
	fi
	echo "Setting fixes tag: $GOOD"
	sed -i -e "s/^Fixes: $COMMIT.*/Fixes: $GOOD/" "$1"
done

exit 0

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 1/26/21 9:01 AM, Jan Kara wrote:
> On Tue 26-01-21 08:47:55, Jens Axboe wrote:
>> On 1/26/21 6:29 AM, Jan Kara wrote:
>>> On Mon 25-01-21 11:39:50, Jens Axboe wrote:
>>>> On 1/25/21 11:35 AM, Paolo Valente wrote:
>>>>>
>>>>>
>>>>>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
>>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> In commit
>>>>>>
>>>>>>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
>>>>>>
>>>>>> Fixes tag
>>>>>>
>>>>>>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
>>>>>>
>>>>>> has these problem(s):
>>>>>>
>>>>>>  - Target SHA1 does not exist
>>>>>>
>>>>>> Maybe you meant
>>>>>>
>>>>>> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
>>>>>>
>>>>>
>>>>> Hi Jens,
>>>>> how to proceed in such a case (with patches already applied by you)?
>>>>> Shall I send you a v2 with only this change?
>>>>
>>>> We just have to ignore it... But in the future, always double check that
>>>> you are using the right shas, not some sha from an internal tree.
>>>
>>> FWIW I have a commit hook in my git tree that just refuses a commit with
>>> unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
>>> merge...
>>
>> That's not a bad idea, would help catch it upfront. Can you share the
>> hook?
> 
> Sure, attached. Note that the hook just gets commit ID from the Fixes tag
> and formats it with 12 commit ID digits and appropriate commit subject.

Thanks, that looks great, and also fixes up short shas.


-- 
Jens Axboe

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hi all,

In commit

  358e7cbf87b4 ("s390/dasd: fix hanging device offline processing")

Fixes tag

  Fixes: 47825e05d93e ("s390/dasd: fix endless loop after read unit address configuration")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 41995342b40c ("s390/dasd: fix endless loop after read unit address configuration")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 12/17/20 1:38 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   358e7cbf87b4 ("s390/dasd: fix hanging device offline processing")
> 
> Fixes tag
> 
>   Fixes: 47825e05d93e ("s390/dasd: fix endless loop after read unit address configuration")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 41995342b40c ("s390/dasd: fix endless loop after read unit address configuration")

Thanks, I fixed it up.

-- 
Jens Axboe

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Hi all,

In commit

  573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")

Fixes tag

  Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")

has these problem(s):

  - SHA1 should be at least 12 digits long

For the future, this can be fixed by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 12/1/20 2:02 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")
> 
> Fixes tag
> 
>   Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
> 
> For the future, this can be fixed by setting core.abbrev to 12 (or more)
> or (for git v2.11 or later) just making sure it is not set (or set to
> "auto").

It's in Linus's tree, not in -next. The ship has sailed...

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

Hi Jens,

On Tue, 1 Dec 2020 14:09:24 -0700 Jens Axboe <axboe@kernel.dk> wrote:
>
> On 12/1/20 2:02 PM, Stephen Rothwell wrote:
> > 
> > In commit
> > 
> >   573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")
> > 
> > Fixes tag
> > 
> >   Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")
> > 
> > has these problem(s):
> > 
> >   - SHA1 should be at least 12 digits long
> > 
> > For the future, this can be fixed by setting core.abbrev to 12 (or more)
> > or (for git v2.11 or later) just making sure it is not set (or set to
> > "auto").  
> 
> It's in Linus's tree, not in -next. The ship has sailed...

Ummm, 573cc9d095bc is only in your tree as far as I can see ...
however, I don't really expect these short SHA1 issues to be fixed up
(as that would require rebasing your tree), just that people will try
not to do the same in the future.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 12/1/20 2:44 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Tue, 1 Dec 2020 14:09:24 -0700 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 12/1/20 2:02 PM, Stephen Rothwell wrote:
>>>
>>> In commit
>>>
>>>   573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")
>>>
>>> Fixes tag
>>>
>>>   Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")
>>>
>>> has these problem(s):
>>>
>>>   - SHA1 should be at least 12 digits long
>>>
>>> For the future, this can be fixed by setting core.abbrev to 12 (or more)
>>> or (for git v2.11 or later) just making sure it is not set (or set to
>>> "auto").  
>>
>> It's in Linus's tree, not in -next. The ship has sailed...
> 
> Ummm, 573cc9d095bc is only in your tree as far as I can see ...
> however, I don't really expect these short SHA1 issues to be fixed up
> (as that would require rebasing your tree), just that people will try
> not to do the same in the future.

Hmm yes, but that's because I botched something up. I'll take a look!

-- 
Jens Axboe

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Hi all,

In commit

  107673613884 ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")

Fixes tag

  Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")

has these problem(s):

  - SHA1 should be at least 12 digits long

For the future, this can be fixed by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Hi all,

In commit

  10988d55ae96 ("md/raid10: Change the return type of raid10_handle_discard to int")

Fixes tag

  fixes: 8f694215ae4c (md/raid10: improve raid10 discard request)

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 828d14fd7a6c ("md/raid10: improve raid10 discard request")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Hi all,

In commit

  64d452b3560b ("nvme-loop: set ctrl state connecting after init")

Fixes tag

  Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live queues")

has these problem(s):

  - Target SHA1 does not exist

I can't easily find what commit is meant :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Hi all,

[Just adding cc's]

On Thu, 30 Jul 2020 08:08:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In commit
> 
>   64d452b3560b ("nvme-loop: set ctrl state connecting after init")
> 
> Fixes tag
> 
>   Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live queues")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> I can't easily find what commit is meant :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 7/29/20 4:12 PM, Stephen Rothwell wrote:
> Hi all,
> 
> [Just adding cc's]
> 
> On Thu, 30 Jul 2020 08:08:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> In commit
>>
>>   64d452b3560b ("nvme-loop: set ctrl state connecting after init")
>>
>> Fixes tag
>>
>>   Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live queues")
>>
>> has these problem(s):
>>
>>   - Target SHA1 does not exist
>>
>> I can't easily find what commit is meant :-(

Yeah, it's obviously garbage, the commit doesn't even exist, let alone the sha.

Chaitanya, where's this from??

-- 
Jens Axboe

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi all,

In commit

  8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")

Fixes tag

  Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Pavel Begunkov]

On 29/06/2020 01:05, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
> 
> Fixes tag
> 
>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")

Jens, could you please fix this up after me?
full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a

> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 

-- 
Pavel Begunkov

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 6/29/20 10:21 AM, Pavel Begunkov wrote:
> On 29/06/2020 01:05, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
>>
>> Fixes tag
>>
>>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")
> 
> Jens, could you please fix this up after me?
> full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a

I don't think that's a grave enough concern to rebase, it's just "missing" a
single digit of the sha.

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Hi all,

On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>
> On 6/29/20 10:21 AM, Pavel Begunkov wrote:
> > On 29/06/2020 01:05, Stephen Rothwell wrote:  
> >> Hi all,
> >>
> >> In commit
> >>
> >>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
> >>
> >> Fixes tag
> >>
> >>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")  
> > 
> > Jens, could you please fix this up after me?
> > full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a  
> 
> I don't think that's a grave enough concern to rebase, it's just "missing" a
> single digit of the sha.

Yeah, its more of a "please fix your git config". :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 6/29/20 4:36 PM, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 6/29/20 10:21 AM, Pavel Begunkov wrote:
>>> On 29/06/2020 01:05, Stephen Rothwell wrote:  
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
>>>>
>>>> Fixes tag
>>>>
>>>>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")  
>>>
>>> Jens, could you please fix this up after me?
>>> full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a  
>>
>> I don't think that's a grave enough concern to rebase, it's just "missing" a
>> single digit of the sha.
> 
> Yeah, its more of a "please fix your git config". :-)

Agree! But I'm guessing that Pavel did this manually, which I end up
doing a lot too... And then mistakes happen.

-- 
Jens Axboe

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Hi all,

In commit

  cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")

Fixes tag

  Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 6/26/20 5:07 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> 
> Fixes tag
> 
>   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.

Gah, that's b4 messing it up. I've actually seen this before, but
I caught it. If you look at the actual commit, this is what the b4
output ends up being for the fixes line:

[snip]
io_kiocb's result and iopoll_completed")

Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize

even though it's correct in the email. I'm guessing some issue having to
do with the longer line?

CC Konstantin.

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Konstantin Ryabitsev]

On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
> On 6/26/20 5:07 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> > 
> > Fixes tag
> > 
> >   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> > 
> > has these problem(s):
> > 
> >   - Subject has leading but no trailing parentheses
> >   - Subject has leading but no trailing quotes
> > 
> > Please do not split Fixes tags over more than one line.
> 
> Gah, that's b4 messing it up. I've actually seen this before, but
> I caught it. If you look at the actual commit, this is what the b4
> output ends up being for the fixes line:
> 
> [snip]
> io_kiocb's result and iopoll_completed")
> 
> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> 
> even though it's correct in the email. I'm guessing some issue having to
> do with the longer line?

Yeah, I'll try to see if there's something I can do here, but it's going 
to be largely guesswork. Here's the original email:

https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw

The Fixes: footer really does get split into two. It's not that hard to 
add logic just for the Fixes tag (since it conveniently follows a set 
pattern), but finding a universal fix for split footers will be more 
difficult.

I'll see what I can do.

-K

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 6/26/20 7:56 PM, Konstantin Ryabitsev wrote:
> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
>> On 6/26/20 5:07 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>>   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
>>>
>>> Fixes tag
>>>
>>>   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>
>>> has these problem(s):
>>>
>>>   - Subject has leading but no trailing parentheses
>>>   - Subject has leading but no trailing quotes
>>>
>>> Please do not split Fixes tags over more than one line.
>>
>> Gah, that's b4 messing it up. I've actually seen this before, but
>> I caught it. If you look at the actual commit, this is what the b4
>> output ends up being for the fixes line:
>>
>> [snip]
>> io_kiocb's result and iopoll_completed")
>>
>> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>
>> even though it's correct in the email. I'm guessing some issue having to
>> do with the longer line?
> 
> Yeah, I'll try to see if there's something I can do here, but it's going 
> to be largely guesswork. Here's the original email:
> 
> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw
> 
> The Fixes: footer really does get split into two. It's not that hard to 
> add logic just for the Fixes tag (since it conveniently follows a set 
> pattern), but finding a universal fix for split footers will be more 
> difficult.

Right, but that's what git format-patch does when the line is long. Do
we have other tags where that's a concern? If not, then the fix should
be solid I think.

> I'll see what I can do.

Thanks!

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

Hi Jens,

On Fri, 26 Jun 2020 20:25:31 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>
> Right, but that's what git format-patch does when the line is long.

I just tested, and "git format-patch" (for me) does *not* split those lines.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 6/26/20 11:12 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Fri, 26 Jun 2020 20:25:31 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> Right, but that's what git format-patch does when the line is long.
> 
> I just tested, and "git format-patch" (for me) does *not* split those lines.

Huh, I could have sworn it's done that for me in the past, just like it
splits the Subject: line into multiple lines as well (that I just did
verify that it still does).

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]

Hi Konstantin,

On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
>
> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
> > On 6/26/20 5:07 PM, Stephen Rothwell wrote:  
> > > Hi all,
> > > 
> > > In commit
> > > 
> > >   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> > > 
> > > Fixes tag
> > > 
> > >   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> > > 
> > > has these problem(s):
> > > 
> > >   - Subject has leading but no trailing parentheses
> > >   - Subject has leading but no trailing quotes
> > > 
> > > Please do not split Fixes tags over more than one line.  
> > 
> > Gah, that's b4 messing it up. I've actually seen this before, but
> > I caught it. If you look at the actual commit, this is what the b4
> > output ends up being for the fixes line:
> > 
> > [snip]
> > io_kiocb's result and iopoll_completed")
> > 
> > Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> > 
> > even though it's correct in the email. I'm guessing some issue having to
> > do with the longer line?  
> 
> Yeah, I'll try to see if there's something I can do here, but it's going 
> to be largely guesswork. Here's the original email:
> 
> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw
> 
> The Fixes: footer really does get split into two. It's not that hard to 
> add logic just for the Fixes tag (since it conveniently follows a set 
> pattern), but finding a universal fix for split footers will be more 
> difficult.
> 
> I'll see what I can do.

But (what am I missing?) the Fixes: tag has been split over 2 lines in
the original message ... on lore and my copy.  There is nothing for b4
to do here, the author needs to do this right.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Pavel Begunkov]

On 27/06/2020 08:01, Stephen Rothwell wrote:
> Hi Konstantin,
> 
> On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
>>
>> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
>>> On 6/26/20 5:07 PM, Stephen Rothwell wrote:  
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
>>>>
>>>> Fixes tag
>>>>
>>>>   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>>
>>>> has these problem(s):
>>>>
>>>>   - Subject has leading but no trailing parentheses
>>>>   - Subject has leading but no trailing quotes
>>>>
>>>> Please do not split Fixes tags over more than one line.  
>>>
>>> Gah, that's b4 messing it up. I've actually seen this before, but
>>> I caught it. If you look at the actual commit, this is what the b4
>>> output ends up being for the fixes line:
>>>
>>> [snip]
>>> io_kiocb's result and iopoll_completed")
>>>
>>> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>
>>> even though it's correct in the email. I'm guessing some issue having to
>>> do with the longer line?  
>>
>> Yeah, I'll try to see if there's something I can do here, but it's going 
>> to be largely guesswork. Here's the original email:
>>
>> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw
>>
>> The Fixes: footer really does get split into two. It's not that hard to 
>> add logic just for the Fixes tag (since it conveniently follows a set 
>> pattern), but finding a universal fix for split footers will be more 
>> difficult.
>>
>> I'll see what I can do.
> 
> But (what am I missing?) the Fixes: tag has been split over 2 lines in
> the original message ... on lore and my copy.  There is nothing for b4
> to do here, the author needs to do this right.

Yes, it was split from the beginning. It's really a shame it can't handle
multi-line tags, but well, I'll keep that in mind.

Though, it's curious how

```
Fixes ("line1
line2")
```

became 
```
line2")

Fixes ("line1
```

And that's what the rest of the thread is about.

-- 
Pavel Begunkov

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

Hi all,

In commit

  2f95fa5c955d ("block, bfq: fix use-after-free in bfq_idle_slice_timer_body")

Fixes tag

  Fixes: aee69d78d ("block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi all,

In commit

  f131f240623a ("io_uring: cq entries should be equal to (or greater) than sq entries")

Fixes tag

  Fixes: 95d8765bd9f2 ("io_uring: allow application controlled CQ ring size")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: f3cbc97703c5 ("io_uring: allow application controlled CQ ring size")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Hi all,

In commit

  1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings")

Fixes tag

  Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Bart Van Assche]

On 10/7/19 1:16 PM, Stephen Rothwell wrote:
> In commit
> 
>    1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings")
> 
> Fixes tag
> 
>    Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).
> 
> has these problem(s):
> 
>    - Subject has leading but no trailing quotes
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Hi Stephen,

The above fixes tag follows the recommended format except that it is 
followed by a kernel version number. Is there a recommended format for 
embedding the kernel version number in a Fixes: tag? I think that 
information is useful. I haven't found any recommendations for how to do 
that in Documentation/process/submitting-patches.rst.

Thanks,

Bart.

Re: linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

Hi Bart,

On Thu, 10 Oct 2019 10:36:36 -0700 Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 10/7/19 1:16 PM, Stephen Rothwell wrote:
> > 
> >    Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).
> 
> The above fixes tag follows the recommended format except that it is 
> followed by a kernel version number. Is there a recommended format for 
> embedding the kernel version number in a Fixes: tag? I think that 
> information is useful. I haven't found any recommendations for how to do 
> that in Documentation/process/submitting-patches.rst.

I have not seen any recommended way to do that, but there is no
necessity to embed the version as it can easily be derived:

$ git describe --contains e34cbd307477
v4.10-rc1~153^2~94

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi all,

In commit

  8776f3fa15a5 ("io_uring: fix wrong sequence setting logic")

Fixes tag

  Fixes: de0617e4671 ("io_uring: add support for marking commands as draining")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi all,

In commit

  8f3858763d33 ("nvme: fix NULL deref for fabrics options")

Fixes tag

  Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").
  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also do not
include blank lines among the tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the block tree

[Jens Axboe]

On 7/11/19 3:35 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    8f3858763d33 ("nvme: fix NULL deref for fabrics options")
> 
> Fixes tag
> 
>    Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests
> 
> has these problem(s):
> 
>    - SHA1 should be at least 12 digits long
>      Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>      or later) just making sure it is not set (or set to "auto").
>    - Subject has leading but no trailing parentheses
>    - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.  Also do not
> include blank lines among the tags.

I should have caught that. Since it's top-of-tree and recent, I'll
amend it.

-- 
Jens Axboe

Re: linux-next: Fixes tag needs some work in the block tree

[Minwoo Im]

On 19-07-11 16:03:22, Jens Axboe wrote:
> On 7/11/19 3:35 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >    8f3858763d33 ("nvme: fix NULL deref for fabrics options")
> > 
> > Fixes tag
> > 
> >    Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests
> > 
> > has these problem(s):
> > 
> >    - SHA1 should be at least 12 digits long
> >      Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> >      or later) just making sure it is not set (or set to "auto").
> >    - Subject has leading but no trailing parentheses
> >    - Subject has leading but no trailing quotes
> > 
> > Please do not split Fixes tags over more than one line.  Also do not
> > include blank lines among the tags.

I'm sorry for noises here.  I will keep that in mind.

Thanks Stephen,

> 
> I should have caught that. Since it's top-of-tree and recent, I'll
> amend it.

Jens,  I will do it from the next time.  Thanks for ammend.

linux-next: Fixes tag needs some work in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Hi Jens,

In commit

  8f4e80da764e ("block: bounce: make sure that bvec table is updated")

Fixes tag

  Fixes: 6dc4f100c ("block: allow bio_for_each_segment_all() to iterate over multi-page bvec")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]