From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Christoph Hellwig <hch@lst.de>,
Randy Dunlap <rdunlap@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mark Brown <broonie@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Michal Hocko <mhocko@suse.cz>,
mm-commits@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
the arch/x86 maintainers <x86@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: mmotm 2020-05-13-20-30 uploaded (objtool warnings)
Date: Fri, 29 May 2020 21:14:34 +0100 [thread overview]
Message-ID: <20200529201434.GH23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200529200856.GG23230@ZenIV.linux.org.uk>
On Fri, May 29, 2020 at 09:08:56PM +0100, Al Viro wrote:
> On Fri, May 29, 2020 at 12:31:04PM -0700, Linus Torvalds wrote:
> > On Fri, May 29, 2020 at 9:50 AM Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > >
> > > From staring at the asm I think the generated code is correct, it's just
> > > that the nested likelys with ftrace profiling cause GCC to converge the
> > > error/success paths. But objtool doesn't do register value tracking so
> > > it's not smart enough to know that it's safe.
> >
> > I'm surprised that gcc doesn't end up doing the obvious CSE and then
> > branch following and folding it all away in the end, but your patch is
> > obviously the right thing to do regardless, so ack on that.
> >
> > Al - I think this had best go into your uaccess cleanup branch with
> > that csum-wrapper update, to avoid any unnecessary conflicts or
> > dependencies.
>
> Sure, just let me verify that other branches don't introduce anything
> of that sort...
... they don't.
OK, folded, rebuild #for-next, pushed both out...
next prev parent reply other threads:[~2020-05-29 20:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200513175005.1f4839360c18c0238df292d1@linux-foundation.org>
2020-05-14 3:31 ` mmotm 2020-05-13-20-30 uploaded Andrew Morton
2020-05-14 15:30 ` mmotm 2020-05-13-20-30 uploaded (gpu/drm/bridge/sil-sii8620) Randy Dunlap
2020-05-14 15:32 ` mmotm 2020-05-13-20-30 uploaded (objtool warnings) Randy Dunlap
2020-05-14 15:33 ` Randy Dunlap
2020-05-28 15:54 ` Josh Poimboeuf
2020-05-28 17:04 ` Josh Poimboeuf
2020-05-28 17:20 ` Peter Zijlstra
2020-05-29 13:57 ` Christoph Hellwig
2020-05-29 14:35 ` Peter Zijlstra
2020-05-29 14:53 ` Peter Zijlstra
2020-05-29 15:33 ` Peter Zijlstra
2020-05-29 16:05 ` Josh Poimboeuf
2020-05-29 16:12 ` Peter Zijlstra
2020-05-29 16:50 ` Josh Poimboeuf
2020-05-29 16:54 ` Peter Zijlstra
2020-05-29 17:25 ` [PATCH] x86/uaccess: Remove redundant likely/unlikely annotations Josh Poimboeuf
2020-05-29 18:29 ` Randy Dunlap
2020-05-29 19:31 ` mmotm 2020-05-13-20-30 uploaded (objtool warnings) Linus Torvalds
2020-05-29 20:08 ` Al Viro
2020-05-29 20:14 ` Al Viro [this message]
2020-05-15 23:30 ` mmotm 2020-05-15-16-29 uploaded Andrew Morton
2020-05-16 5:53 ` Stephen Rothwell
2020-05-18 23:15 ` Stephen Rothwell
2020-05-20 4:48 ` mmotm 2020-05-19-21-47 uploaded Andrew Morton
2020-05-22 3:43 ` mmotm 2020-05-21-20-42 uploaded Andrew Morton
2020-05-22 16:26 ` mmotm 2020-05-21-20-42 uploaded (atomisp) Randy Dunlap
2020-05-23 3:36 ` mmotm 2020-05-22-20-35 uploaded Andrew Morton
2020-05-23 15:08 ` mmotm 2020-05-22-20-35 uploaded (phy/intel/phy-intel-combo.c) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529201434.GH23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=hch@lst.de \
--cc=jpoimboe@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).