Hi all, After merging the akpm-current tree, today's linux-next build (sparc defconfig) failed like this: In file included from include/linux/mm.h:32:0, from include/linux/memblock.h:13, from arch/sparc/mm/srmmu.c:14: include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel' #define pte_offset_kernel pte_offset_kernel ^ arch/sparc/mm/srmmu.c:144:8: note: in expansion of macro 'pte_offset_kernel' pte_t *pte_offset_kernel(pmd_t *dir, unsigned long address) ^~~~~~~~~~~~~~~~~ include/linux/pgtable.h:70:22: note: previous definition of 'pte_offset_kernel' was here static inline pte_t *pte_offset_kernel(pmd_t *pmd, unsigned long address) ^~~~~~~~~~~~~~~~~ Caused by commit 292aa65ed13a ("mm: consolidate pte_index() and pte_offset_*() definitions") I used the (missing part of the) patch from next-20200608: From: Stephen Rothwell Date: Tue, 9 Jun 2020 22:36:14 +1000 Subject: [PATCH] update sparc32 for "mm: consolidate pte_index() and pte_offset_*() definitions" Signed-off-by: Stephen Rothwell --- arch/sparc/mm/srmmu.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c index 989da22ba8e9..0070f8b9a753 100644 --- a/arch/sparc/mm/srmmu.c +++ b/arch/sparc/mm/srmmu.c @@ -140,16 +140,6 @@ void pmd_set(pmd_t *pmdp, pte_t *ptep) set_pte((pte_t *)&pmd_val(*pmdp), __pte(SRMMU_ET_PTD | ptp)); } -/* Find an entry in the third-level page table.. */ -pte_t *pte_offset_kernel(pmd_t *dir, unsigned long address) -{ - void *pte; - - pte = __nocache_va((pmd_val(*dir) & SRMMU_PTD_PMASK) << 4); - return (pte_t *) pte + - ((address >> PAGE_SHIFT) & (PTRS_PER_PTE - 1)); -} - /* * size: bytes to allocate in the nocache area. * align: bytes, number to align at. -- 2.26.2 -- Cheers, Stephen Rothwell