* linux-next: build failures after merge of the vfs tree
@ 2020-06-16 0:33 Stephen Rothwell
2020-06-16 0:34 ` Stephen Rothwell
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2020-06-16 0:33 UTC (permalink / raw)
To: Al Viro; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]
Hi all,
After merging the vfs tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/dma/uniphier-xdmac.c: In function 'uniphier_xdmac_prep_dma_memcpy':
drivers/dma/uniphier-xdmac.c:293:7: error: implicit declaration of function 'kzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
293 | xd = kzalloc(struct_size(xd, nodes, nr), GFP_NOWAIT);
| ^~~~~~~
| kvzalloc
drivers/dma/uniphier-xdmac.c:293:5: warning: assignment to 'struct uniphier_xdmac_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
293 | xd = kzalloc(struct_size(xd, nodes, nr), GFP_NOWAIT);
| ^
drivers/dma/uniphier-xdmac.c: In function 'uniphier_xdmac_prep_slave_sg':
drivers/dma/uniphier-xdmac.c:349:5: warning: assignment to 'struct uniphier_xdmac_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
349 | xd = kzalloc(struct_size(xd, nodes, sg_len), GFP_NOWAIT);
| ^
drivers/dma/uniphier-xdmac.c:373:4: error: implicit declaration of function 'kfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
373 | kfree(xd);
| ^~~~~
| kvfree
Also, from the arm multi_v7_defconfig build:
drivers/dma/st_fdma.c: In function 'st_fdma_free_desc':
drivers/dma/st_fdma.c:233:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
233 | kfree(fdesc);
| ^~~~~
| vfree
drivers/dma/st_fdma.c: In function 'st_fdma_alloc_desc':
drivers/dma/st_fdma.c:242:10: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
242 | fdesc = kzalloc(struct_size(fdesc, node, sg_len), GFP_NOWAIT);
| ^~~~~~~
| vzalloc
drivers/dma/st_fdma.c:242:8: warning: assignment to 'struct st_fdma_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
242 | fdesc = kzalloc(struct_size(fdesc, node, sg_len), GFP_NOWAIT);
| ^
Caused by commit
f0187db056dc ("iov_iter: Move unnecessary inclusion of crypto/hash.h")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: linux-next: build failures after merge of the vfs tree
2020-06-16 0:33 linux-next: build failures after merge of the vfs tree Stephen Rothwell
@ 2020-06-16 0:34 ` Stephen Rothwell
2020-06-16 1:05 ` Herbert Xu
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2020-06-16 0:34 UTC (permalink / raw)
To: Al Viro; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Herbert Xu
[-- Attachment #1: Type: text/plain, Size: 2469 bytes --]
[Just adding Herbert to cc]
On Tue, 16 Jun 2020 10:33:30 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the vfs tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/dma/uniphier-xdmac.c: In function 'uniphier_xdmac_prep_dma_memcpy':
> drivers/dma/uniphier-xdmac.c:293:7: error: implicit declaration of function 'kzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
> 293 | xd = kzalloc(struct_size(xd, nodes, nr), GFP_NOWAIT);
> | ^~~~~~~
> | kvzalloc
> drivers/dma/uniphier-xdmac.c:293:5: warning: assignment to 'struct uniphier_xdmac_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 293 | xd = kzalloc(struct_size(xd, nodes, nr), GFP_NOWAIT);
> | ^
> drivers/dma/uniphier-xdmac.c: In function 'uniphier_xdmac_prep_slave_sg':
> drivers/dma/uniphier-xdmac.c:349:5: warning: assignment to 'struct uniphier_xdmac_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 349 | xd = kzalloc(struct_size(xd, nodes, sg_len), GFP_NOWAIT);
> | ^
> drivers/dma/uniphier-xdmac.c:373:4: error: implicit declaration of function 'kfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
> 373 | kfree(xd);
> | ^~~~~
> | kvfree
>
> Also, from the arm multi_v7_defconfig build:
>
> drivers/dma/st_fdma.c: In function 'st_fdma_free_desc':
> drivers/dma/st_fdma.c:233:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
> 233 | kfree(fdesc);
> | ^~~~~
> | vfree
> drivers/dma/st_fdma.c: In function 'st_fdma_alloc_desc':
> drivers/dma/st_fdma.c:242:10: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
> 242 | fdesc = kzalloc(struct_size(fdesc, node, sg_len), GFP_NOWAIT);
> | ^~~~~~~
> | vzalloc
> drivers/dma/st_fdma.c:242:8: warning: assignment to 'struct st_fdma_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 242 | fdesc = kzalloc(struct_size(fdesc, node, sg_len), GFP_NOWAIT);
> | ^
>
> Caused by commit
>
> f0187db056dc ("iov_iter: Move unnecessary inclusion of crypto/hash.h")
>
> I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: linux-next: build failures after merge of the vfs tree
2020-06-16 0:34 ` Stephen Rothwell
@ 2020-06-16 1:05 ` Herbert Xu
2020-06-16 3:38 ` Al Viro
0 siblings, 1 reply; 15+ messages in thread
From: Herbert Xu @ 2020-06-16 1:05 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Al Viro, Linux Next Mailing List, Linux Kernel Mailing List, netdev
On Tue, Jun 16, 2020 at 10:34:40AM +1000, Stephen Rothwell wrote:
> [Just adding Herbert to cc]
>
> On Tue, 16 Jun 2020 10:33:30 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the vfs tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
Thanks Stephen, here is an incremental patch to fix these up.
---8<---
Because linux/uio.h included crypto/hash.h a number of header
files that should have been included weren't. This patch adds
linux/slab.h where kmalloc/kfree are used, as well as a forward
declaration in linux/socket.h for struct file.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: f0187db056dc ("iov_iter: Move unnecessary inclusion of...")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c
index 67087dbe2f9f..962b6e05287b 100644
--- a/drivers/dma/st_fdma.c
+++ b/drivers/dma/st_fdma.c
@@ -15,6 +15,7 @@
#include <linux/platform_device.h>
#include <linux/interrupt.h>
#include <linux/remoteproc.h>
+#include <linux/slab.h>
#include "st_fdma.h"
diff --git a/drivers/dma/uniphier-xdmac.c b/drivers/dma/uniphier-xdmac.c
index 7b2f8a8c2d31..16b19654873d 100644
--- a/drivers/dma/uniphier-xdmac.c
+++ b/drivers/dma/uniphier-xdmac.c
@@ -12,6 +12,7 @@
#include <linux/of.h>
#include <linux/of_dma.h>
#include <linux/platform_device.h>
+#include <linux/slab.h>
#include "dmaengine.h"
#include "virt-dma.h"
diff --git a/include/linux/socket.h b/include/linux/socket.h
index 04d2bc97f497..e9cb30d8cbfb 100644
--- a/include/linux/socket.h
+++ b/include/linux/socket.h
@@ -10,6 +10,7 @@
#include <linux/compiler.h> /* __user */
#include <uapi/linux/socket.h>
+struct file;
struct pid;
struct cred;
struct socket;
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: linux-next: build failures after merge of the vfs tree
2020-06-16 1:05 ` Herbert Xu
@ 2020-06-16 3:38 ` Al Viro
2020-06-16 14:38 ` Herbert Xu
0 siblings, 1 reply; 15+ messages in thread
From: Al Viro @ 2020-06-16 3:38 UTC (permalink / raw)
To: Herbert Xu
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, netdev
On Tue, Jun 16, 2020 at 11:05:02AM +1000, Herbert Xu wrote:
> On Tue, Jun 16, 2020 at 10:34:40AM +1000, Stephen Rothwell wrote:
> > [Just adding Herbert to cc]
> >
> > On Tue, 16 Jun 2020 10:33:30 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the vfs tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
>
> Thanks Stephen, here is an incremental patch to fix these up.
Folded and pushed
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build failures after merge of the vfs tree
2020-06-16 3:38 ` Al Viro
@ 2020-06-16 14:38 ` Herbert Xu
2020-06-16 15:14 ` Al Viro
2020-06-17 6:57 ` Stephen Rothwell
0 siblings, 2 replies; 15+ messages in thread
From: Herbert Xu @ 2020-06-16 14:38 UTC (permalink / raw)
To: Al Viro
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, netdev
On Tue, Jun 16, 2020 at 04:38:49AM +0100, Al Viro wrote:
>
> Folded and pushed
Thanks Al. Here's another one that I just got, could you add this
one too?
diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c
index c405722adfe1..c4f273e2fe78 100644
--- a/drivers/mtd/nand/raw/cadence-nand-controller.c
+++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
@@ -17,6 +17,7 @@
#include <linux/mtd/rawnand.h>
#include <linux/of_device.h>
#include <linux/iopoll.h>
+#include <linux/slab.h>
/*
* HPNFC can work in 3 modes:
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: linux-next: build failures after merge of the vfs tree
2020-06-16 14:38 ` Herbert Xu
@ 2020-06-16 15:14 ` Al Viro
2020-06-17 6:57 ` Stephen Rothwell
1 sibling, 0 replies; 15+ messages in thread
From: Al Viro @ 2020-06-16 15:14 UTC (permalink / raw)
To: Herbert Xu
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, netdev
On Wed, Jun 17, 2020 at 12:38:07AM +1000, Herbert Xu wrote:
> On Tue, Jun 16, 2020 at 04:38:49AM +0100, Al Viro wrote:
> >
> > Folded and pushed
>
> Thanks Al. Here's another one that I just got, could you add this
> one too?
Done...
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build failures after merge of the vfs tree
2020-06-16 14:38 ` Herbert Xu
2020-06-16 15:14 ` Al Viro
@ 2020-06-17 6:57 ` Stephen Rothwell
2020-06-17 7:03 ` Herbert Xu
1 sibling, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2020-06-17 6:57 UTC (permalink / raw)
To: Herbert Xu
Cc: Al Viro, Linux Next Mailing List, Linux Kernel Mailing List, netdev
[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]
Hi Herbert,
On Wed, 17 Jun 2020 00:38:07 +1000 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Tue, Jun 16, 2020 at 04:38:49AM +0100, Al Viro wrote:
> >
> > Folded and pushed
>
> Thanks Al. Here's another one that I just got, could you add this
> one too?
>
> diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c
> index c405722adfe1..c4f273e2fe78 100644
> --- a/drivers/mtd/nand/raw/cadence-nand-controller.c
> +++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
> @@ -17,6 +17,7 @@
> #include <linux/mtd/rawnand.h>
> #include <linux/of_device.h>
> #include <linux/iopoll.h>
> +#include <linux/slab.h>
>
> /*
> * HPNFC can work in 3 modes:
Presumably another include needed:
arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function 'kmalloc' [-Werror=implicit-function-declaration]
arch/s390/lib/test_unwind.c:99:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build failures after merge of the vfs tree
2020-06-17 6:57 ` Stephen Rothwell
@ 2020-06-17 7:03 ` Herbert Xu
2020-06-17 7:31 ` Stephen Rothwell
2020-06-17 8:06 ` Stephen Rothwell
0 siblings, 2 replies; 15+ messages in thread
From: Herbert Xu @ 2020-06-17 7:03 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Al Viro, Linux Next Mailing List, Linux Kernel Mailing List, netdev
On Wed, Jun 17, 2020 at 04:57:15PM +1000, Stephen Rothwell wrote:
>
> Presumably another include needed:
>
> arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function 'kmalloc' [-Werror=implicit-function-declaration]
> arch/s390/lib/test_unwind.c:99:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
Hi Stephen:
It's not clear how this file manages to include linux/uio.h but
here is a patch for it anyway:
diff --git a/arch/s390/lib/test_unwind.c b/arch/s390/lib/test_unwind.c
index 32b7a30b2485..eb382ceaa116 100644
--- a/arch/s390/lib/test_unwind.c
+++ b/arch/s390/lib/test_unwind.c
@@ -9,6 +9,7 @@
#include <linux/kallsyms.h>
#include <linux/kthread.h>
#include <linux/module.h>
+#include <linux/slab.h>
#include <linux/string.h>
#include <linux/kprobes.h>
#include <linux/wait.h>
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: linux-next: build failures after merge of the vfs tree
2020-06-17 7:03 ` Herbert Xu
@ 2020-06-17 7:31 ` Stephen Rothwell
2020-06-17 7:38 ` Herbert Xu
2020-06-17 8:06 ` Stephen Rothwell
1 sibling, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2020-06-17 7:31 UTC (permalink / raw)
To: Herbert Xu
Cc: Al Viro, Linux Next Mailing List, Linux Kernel Mailing List, netdev
[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]
Hi Herbert,
On Wed, 17 Jun 2020 17:03:17 +1000 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Wed, Jun 17, 2020 at 04:57:15PM +1000, Stephen Rothwell wrote:
> >
> > Presumably another include needed:
> >
> > arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function 'kmalloc' [-Werror=implicit-function-declaration]
> > arch/s390/lib/test_unwind.c:99:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
>
And more (these are coming from other's builds):
drivers/remoteproc/qcom_q6v5_mss.c:772:3: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
drivers/remoteproc/qcom_q6v5_mss.c:808:2: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
drivers/remoteproc/qcom_q6v5_mss.c:1195:2: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
They may have other causes as they are full linux-next builds (not just
after the merge of the vfs tree), but the timing is suspicious.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build failures after merge of the vfs tree
2020-06-17 7:31 ` Stephen Rothwell
@ 2020-06-17 7:38 ` Herbert Xu
2020-06-18 0:08 ` Stephen Rothwell
0 siblings, 1 reply; 15+ messages in thread
From: Herbert Xu @ 2020-06-17 7:38 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Al Viro, Linux Next Mailing List, Linux Kernel Mailing List, netdev
On Wed, Jun 17, 2020 at 05:31:02PM +1000, Stephen Rothwell wrote:
> > >
> > > Presumably another include needed:
> > >
> > > arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function 'kmalloc' [-Werror=implicit-function-declaration]
> > > arch/s390/lib/test_unwind.c:99:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
>
> And more (these are coming from other's builds):
>
> drivers/remoteproc/qcom_q6v5_mss.c:772:3: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
> drivers/remoteproc/qcom_q6v5_mss.c:808:2: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
> drivers/remoteproc/qcom_q6v5_mss.c:1195:2: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
>
> They may have other causes as they are full linux-next builds (not just
> after the merge of the vfs tree), but the timing is suspicious.
OK, here's a patch for both of these together:
diff --git a/arch/s390/lib/test_unwind.c b/arch/s390/lib/test_unwind.c
index 32b7a30b2485..eb382ceaa116 100644
--- a/arch/s390/lib/test_unwind.c
+++ b/arch/s390/lib/test_unwind.c
@@ -9,6 +9,7 @@
#include <linux/kallsyms.h>
#include <linux/kthread.h>
#include <linux/module.h>
+#include <linux/slab.h>
#include <linux/string.h>
#include <linux/kprobes.h>
#include <linux/wait.h>
diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index feb70283b6a2..903b2bb97e12 100644
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -26,6 +26,7 @@
#include <linux/reset.h>
#include <linux/soc/qcom/mdt_loader.h>
#include <linux/iopoll.h>
+#include <linux/slab.h>
#include "remoteproc_internal.h"
#include "qcom_common.h"
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: linux-next: build failures after merge of the vfs tree
2020-06-17 7:38 ` Herbert Xu
@ 2020-06-18 0:08 ` Stephen Rothwell
2020-06-30 1:58 ` Stephen Rothwell
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2020-06-18 0:08 UTC (permalink / raw)
To: Herbert Xu
Cc: Al Viro, Linux Next Mailing List, Linux Kernel Mailing List, netdev
[-- Attachment #1: Type: text/plain, Size: 2135 bytes --]
Hi all,
On Wed, 17 Jun 2020 17:38:45 +1000 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Wed, Jun 17, 2020 at 05:31:02PM +1000, Stephen Rothwell wrote:
> > > >
> > > > Presumably another include needed:
> > > >
> > > > arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function 'kmalloc' [-Werror=implicit-function-declaration]
> > > > arch/s390/lib/test_unwind.c:99:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
> >
> > And more (these are coming from other's builds):
> >
> > drivers/remoteproc/qcom_q6v5_mss.c:772:3: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
> > drivers/remoteproc/qcom_q6v5_mss.c:808:2: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
> > drivers/remoteproc/qcom_q6v5_mss.c:1195:2: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
> >
> > They may have other causes as they are full linux-next builds (not just
> > after the merge of the vfs tree), but the timing is suspicious.
>
> OK, here's a patch for both of these together:
>
> diff --git a/arch/s390/lib/test_unwind.c b/arch/s390/lib/test_unwind.c
> index 32b7a30b2485..eb382ceaa116 100644
> --- a/arch/s390/lib/test_unwind.c
> +++ b/arch/s390/lib/test_unwind.c
> @@ -9,6 +9,7 @@
> #include <linux/kallsyms.h>
> #include <linux/kthread.h>
> #include <linux/module.h>
> +#include <linux/slab.h>
> #include <linux/string.h>
> #include <linux/kprobes.h>
> #include <linux/wait.h>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index feb70283b6a2..903b2bb97e12 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -26,6 +26,7 @@
> #include <linux/reset.h>
> #include <linux/soc/qcom/mdt_loader.h>
> #include <linux/iopoll.h>
> +#include <linux/slab.h>
>
> #include "remoteproc_internal.h"
> #include "qcom_common.h"
I have applied those 2 by hand for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build failures after merge of the vfs tree
2020-06-18 0:08 ` Stephen Rothwell
@ 2020-06-30 1:58 ` Stephen Rothwell
2020-06-30 2:14 ` Herbert Xu
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2020-06-30 1:58 UTC (permalink / raw)
To: Herbert Xu
Cc: Al Viro, Linux Next Mailing List, Linux Kernel Mailing List, netdev
[-- Attachment #1: Type: text/plain, Size: 2361 bytes --]
Hi all,
On Thu, 18 Jun 2020 10:08:51 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Wed, 17 Jun 2020 17:38:45 +1000 Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> > On Wed, Jun 17, 2020 at 05:31:02PM +1000, Stephen Rothwell wrote:
> > > > >
> > > > > Presumably another include needed:
> > > > >
> > > > > arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function 'kmalloc' [-Werror=implicit-function-declaration]
> > > > > arch/s390/lib/test_unwind.c:99:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
> > >
> > > And more (these are coming from other's builds):
> > >
> > > drivers/remoteproc/qcom_q6v5_mss.c:772:3: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
> > > drivers/remoteproc/qcom_q6v5_mss.c:808:2: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
> > > drivers/remoteproc/qcom_q6v5_mss.c:1195:2: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
> > >
> > > They may have other causes as they are full linux-next builds (not just
> > > after the merge of the vfs tree), but the timing is suspicious.
> >
> > OK, here's a patch for both of these together:
> >
> > diff --git a/arch/s390/lib/test_unwind.c b/arch/s390/lib/test_unwind.c
> > index 32b7a30b2485..eb382ceaa116 100644
> > --- a/arch/s390/lib/test_unwind.c
> > +++ b/arch/s390/lib/test_unwind.c
> > @@ -9,6 +9,7 @@
> > #include <linux/kallsyms.h>
> > #include <linux/kthread.h>
> > #include <linux/module.h>
> > +#include <linux/slab.h>
> > #include <linux/string.h>
> > #include <linux/kprobes.h>
> > #include <linux/wait.h>
> > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> > index feb70283b6a2..903b2bb97e12 100644
> > --- a/drivers/remoteproc/qcom_q6v5_mss.c
> > +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> > @@ -26,6 +26,7 @@
> > #include <linux/reset.h>
> > #include <linux/soc/qcom/mdt_loader.h>
> > #include <linux/iopoll.h>
> > +#include <linux/slab.h>
> >
> > #include "remoteproc_internal.h"
> > #include "qcom_common.h"
>
> I have applied those 2 by hand for today.
I am still applying the above patch.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build failures after merge of the vfs tree
2020-06-30 1:58 ` Stephen Rothwell
@ 2020-06-30 2:14 ` Herbert Xu
2020-06-30 13:36 ` Al Viro
0 siblings, 1 reply; 15+ messages in thread
From: Herbert Xu @ 2020-06-30 2:14 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Al Viro, Linux Next Mailing List, Linux Kernel Mailing List, netdev
On Tue, Jun 30, 2020 at 11:58:57AM +1000, Stephen Rothwell wrote:
>
> > > OK, here's a patch for both of these together:
> > >
> > > diff --git a/arch/s390/lib/test_unwind.c b/arch/s390/lib/test_unwind.c
> > > index 32b7a30b2485..eb382ceaa116 100644
> > > --- a/arch/s390/lib/test_unwind.c
> > > +++ b/arch/s390/lib/test_unwind.c
> > > @@ -9,6 +9,7 @@
> > > #include <linux/kallsyms.h>
> > > #include <linux/kthread.h>
> > > #include <linux/module.h>
> > > +#include <linux/slab.h>
> > > #include <linux/string.h>
> > > #include <linux/kprobes.h>
> > > #include <linux/wait.h>
> > > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> > > index feb70283b6a2..903b2bb97e12 100644
> > > --- a/drivers/remoteproc/qcom_q6v5_mss.c
> > > +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> > > @@ -26,6 +26,7 @@
> > > #include <linux/reset.h>
> > > #include <linux/soc/qcom/mdt_loader.h>
> > > #include <linux/iopoll.h>
> > > +#include <linux/slab.h>
> > >
> > > #include "remoteproc_internal.h"
> > > #include "qcom_common.h"
> >
> > I have applied those 2 by hand for today.
>
> I am still applying the above patch.
Hi Al:
Could you please fold these changes into your tree?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build failures after merge of the vfs tree
2020-06-17 7:03 ` Herbert Xu
2020-06-17 7:31 ` Stephen Rothwell
@ 2020-06-17 8:06 ` Stephen Rothwell
1 sibling, 0 replies; 15+ messages in thread
From: Stephen Rothwell @ 2020-06-17 8:06 UTC (permalink / raw)
To: Herbert Xu
Cc: Al Viro, Linux Next Mailing List, Linux Kernel Mailing List, netdev
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
Hi Herbert,
On Wed, 17 Jun 2020 17:03:17 +1000 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Wed, Jun 17, 2020 at 04:57:15PM +1000, Stephen Rothwell wrote:
> >
> > Presumably another include needed:
> >
> > arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function 'kmalloc' [-Werror=implicit-function-declaration]
> > arch/s390/lib/test_unwind.c:99:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
>
> Hi Stephen:
>
> It's not clear how this file manages to include linux/uio.h but
arch/s390/lib/test_unwind.c
arch/s390/include/asm/unwind.h
include/linux/ftrace.h
include/linux/kallsyms.h
include/linux/module.h
include/linux/elf.h
arch/s390/include/asm/elf.h
include/linux/compat.h
include/linux/socket.h
include/linux/uio.h
:-(
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-06-30 13:36 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-16 0:33 linux-next: build failures after merge of the vfs tree Stephen Rothwell
2020-06-16 0:34 ` Stephen Rothwell
2020-06-16 1:05 ` Herbert Xu
2020-06-16 3:38 ` Al Viro
2020-06-16 14:38 ` Herbert Xu
2020-06-16 15:14 ` Al Viro
2020-06-17 6:57 ` Stephen Rothwell
2020-06-17 7:03 ` Herbert Xu
2020-06-17 7:31 ` Stephen Rothwell
2020-06-17 7:38 ` Herbert Xu
2020-06-18 0:08 ` Stephen Rothwell
2020-06-30 1:58 ` Stephen Rothwell
2020-06-30 2:14 ` Herbert Xu
2020-06-30 13:36 ` Al Viro
2020-06-17 8:06 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).