From: Chris Down <chris@chrisdown.name>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
Michal Hocko <mhocko@kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
"Linux F2FS DEV,
Mailing List" <linux-f2fs-devel@lists.sourceforge.net>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Arnd Bergmann <arnd@arndb.de>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
Chao Yu <chao@kernel.org>, Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Chao Yu <yuchao0@huawei.com>,
lkft-triage@lists.linaro.org,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>, Cgroups <cgroups@vger.kernel.org>
Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page
Date: Thu, 18 Jun 2020 13:37:43 +0100 [thread overview]
Message-ID: <20200618123743.GA694719@chrisdown.name> (raw)
In-Reply-To: <CALOAHbBp7Ytd-Hta9NH-_HJtVTAsR5Pw2RYrVScp7PPezCEv2w@mail.gmail.com>
Yafang Shao writes:
>On Thu, Jun 18, 2020 at 5:09 AM Chris Down <chris@chrisdown.name> wrote:
>>
>> Naresh Kamboju writes:
>> >After this patch applied the reported issue got fixed.
>>
>> Great! Thank you Naresh and Michal for helping to get to the bottom of this :-)
>>
>> I'll send out a new version tomorrow with the fixes applied and both of you
>> credited in the changelog for the detection and fix.
>
>As we have already found that the usage around memory.{emin, elow} has
>many limitations, I think memory.{emin, elow} should be used for
>memcg-tree internally only, that means they can only be used to
>calculate the protection of a memcg in a specified memcg-tree but
>should not be exposed to other MM parts.
I agree that the current semantics are mentally taxing and we should generally
avoid exposing the implementation details outside of memcg where possible. Do
you have a suggested rework? :-)
next prev parent reply other threads:[~2020-06-18 12:37 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 12:38 mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Naresh Kamboju
2020-05-01 20:58 ` Andrew Morton
2020-05-18 14:10 ` Naresh Kamboju
2020-05-19 7:52 ` Michal Hocko
2020-05-19 8:11 ` Arnd Bergmann
2020-05-19 8:45 ` Michal Hocko
2020-05-20 11:56 ` Naresh Kamboju
2020-05-20 17:59 ` Naresh Kamboju
2020-05-20 19:09 ` Chris Down
2020-05-21 9:22 ` Naresh Kamboju
2020-05-21 9:35 ` Arnd Bergmann
2020-05-21 9:55 ` Michal Hocko
2020-05-21 10:41 ` Naresh Kamboju
2020-05-21 10:58 ` Michal Hocko
2020-05-21 12:24 ` Hugh Dickins
2020-05-21 12:44 ` Michal Hocko
2020-05-21 19:17 ` Johannes Weiner
2020-05-21 20:06 ` Hugh Dickins
2020-05-21 21:58 ` Johannes Weiner
2020-05-21 23:35 ` Hugh Dickins
2020-05-28 14:59 ` Michal Hocko
2020-05-21 16:34 ` Michal Hocko
2020-05-21 19:00 ` Naresh Kamboju
2020-05-21 20:53 ` Naresh Kamboju
2020-05-28 15:03 ` Michal Hocko
2020-05-28 16:17 ` Naresh Kamboju
2020-05-28 16:41 ` Chris Down
2020-05-29 1:50 ` Yafang Shao
2020-05-29 1:56 ` Chris Down
2020-05-29 9:49 ` Michal Hocko
2020-06-11 9:55 ` Michal Hocko
2020-06-12 9:43 ` Naresh Kamboju
2020-06-12 12:09 ` Michal Hocko
2020-06-17 13:37 ` Naresh Kamboju
2020-06-17 13:57 ` Chris Down
2020-06-17 14:11 ` Michal Hocko
2020-06-17 15:53 ` Naresh Kamboju
2020-06-17 16:06 ` Michal Hocko
2020-06-17 20:13 ` Naresh Kamboju
2020-06-17 21:09 ` Chris Down
2020-06-18 1:43 ` Yafang Shao
2020-06-18 12:37 ` Chris Down [this message]
2020-06-18 12:41 ` Michal Hocko
2020-06-18 12:49 ` Chris Down
2020-06-18 14:59 ` Yafang Shao
2020-06-17 13:59 ` Michal Hocko
2020-06-17 14:08 ` Chris Down
2020-05-21 2:39 ` Yafang Shao
2020-05-21 8:58 ` Naresh Kamboju
2020-05-21 9:47 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618123743.GA694719@chrisdown.name \
--to=chris@chrisdown.name \
--cc=aarcange@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=cgroups@vger.kernel.org \
--cc=chao@kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jaegeuk@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mhocko@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).