linux-next: Signed-off-by missing for commit in the hid tree

linux-next: Signed-off-by missing for commit in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

Hi all,

Commit

  470376737e88 ("HID: allow building hid.ko as an external module")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the hid tree

[Cristian Klein]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

On Sun, Jun 21, 2020 at 07:51:24AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   470376737e88 ("HID: allow building hid.ko as an external module")
> 
> is missing a Signed-off-by from its author.
> 
> -- 
> Cheers,
> Stephen Rothwell

Hi,

My bad. Please find attached the corrected patch.

Cheers,
Cristian

[-- Attachment #2: 0001-Allow-building-hid.ko-as-an-external-module.patch --]
[-- Type: text/x-diff, Size: 2478 bytes --]

From 8005724373d8cecb241c013d16b2242c7c1fb39e Mon Sep 17 00:00:00 2001
From: Cristian Klein <cristian.klein@elastisys.com>
Date: Mon, 22 Jun 2020 08:47:58 +0200
Subject: [PATCH] Allow building hid.ko as an "external" module

For quickly testing USB HID quirks with a larger community, it is useful
to be able to build hid.ko as an external module, e.g., against the
source code of the running kernel.

Before this patch this failed as follows:
```
$ make -C /lib/modules/$(uname -r)/build M=$PWD/drivers/hid
make: Entering directory '/usr/src/linux-headers-5.3.0-51-generic'
  CC [M]  /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid-core.o
  CC [M]  /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.o
  LD [M]  /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/init.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/hbm.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/client.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/bus.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/dma-if.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/client-buffers.o
  LD [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/intel-ishtp.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.o
/home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.c:12:10: fatal error: client.h: No such file or directory
   12 | #include "client.h"
      |          ^~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.build:290: /home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.o] Error 1
make[1]: *** [scripts/Makefile.build:519: /home/cklein/linux/drivers/hid/intel-ish-hid] Error 2
make: *** [Makefile:1656: _module_/home/cklein/linux/drivers/hid] Error 2
make: Leaving directory '/usr/src/linux-headers-5.3.0-51-generic'
```

Signed-off-by: Cristian Klein <cristian.klein@elastisys.com>
---
 drivers/hid/intel-ish-hid/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/Makefile b/drivers/hid/intel-ish-hid/Makefile
index f0a82b1c7..db4974c43 100644
--- a/drivers/hid/intel-ish-hid/Makefile
+++ b/drivers/hid/intel-ish-hid/Makefile
@@ -23,4 +23,4 @@ intel-ishtp-hid-objs += ishtp-hid-client.o
 obj-$(CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER) += intel-ishtp-loader.o
 intel-ishtp-loader-objs += ishtp-fw-loader.o
 
-ccflags-y += -I $(srctree)/$(src)/ishtp
+ccflags-y += -I $(src)/ishtp
-- 
2.20.1

Re: [PATCH] Allow building hid.ko as an "external" module

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

Hi Cristian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on jikos-trivial/for-next]
[also build test ERROR on linux/master linus/master v5.8-rc2 next-20200623]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Cristian-Klein/Allow-building-hid-ko-as-an-external-module/20200622-160113
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git for-next
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/hid/intel-ish-hid/ipc/ipc.c:12:10: fatal error: client.h: No such file or directory
      12 | #include "client.h"
         |          ^~~~~~~~~~
   compilation terminated.
--
>> drivers/hid/intel-ish-hid/ipc/pci-ish.c:22:10: fatal error: ishtp-dev.h: No such file or directory
      22 | #include "ishtp-dev.h"
         |          ^~~~~~~~~~~~~
   compilation terminated.

vim +12 drivers/hid/intel-ish-hid/ipc/ipc.c

ae02e5d40d5f82 Srinivas Pandruvada 2016-08-07 @12  #include "client.h"
ae02e5d40d5f82 Srinivas Pandruvada 2016-08-07  13  #include "hw-ish.h"
ae02e5d40d5f82 Srinivas Pandruvada 2016-08-07  14  #include "hbm.h"
ae02e5d40d5f82 Srinivas Pandruvada 2016-08-07  15  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48267 bytes --]

Re: linux-next: Signed-off-by missing for commit in the hid tree

[Vicki Pfau]

Sorry about that, I must have forgotten to add it. Can I sign off on it now?

Signed-off-by: Vicki Pfau <vi@endrift.com>

On 1/2/24 13:32, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   917972636e82 ("HID: hid-steam: Disable watchdog instead of using a heartbeat")
> 
> is missing a Signed-off-by from its author.
> 

linux-next: Signed-off-by missing for commit in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

Hi all,

Commit

  917972636e82 ("HID: hid-steam: Disable watchdog instead of using a heartbeat")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the hid tree

[Benjamin Tissoires]

Hi Stephen,

On Thu, Feb 9, 2023 at 10:42 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commit
>
>   f1fc9fbc8394 ("HID: Add support for Logitech G923 Xbox Edition steering wheel")
>
> is missing a Signed-off-by from its author.
>
> This is just a typo - "Signed-of-by".

Alright, force pushed an update of the whole for-6.3/logitech branch
with both this typo fix and the missing-12-chars-for-fixes-tag that
was in that branch too.

Also force pushed for-next, which cleans a little bit everything, with
a check that the old for-next branch and the new one have the exact
same content.

Cheers,
Benjamin

>
> --
> Cheers,
> Stephen Rothwell

linux-next: Signed-off-by missing for commit in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

Hi all,

Commit

  f1fc9fbc8394 ("HID: Add support for Logitech G923 Xbox Edition steering wheel")

is missing a Signed-off-by from its author.

This is just a typo - "Signed-of-by".

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

Hi all,

Commit

  7af32d156ad7 ("Revert "HID: nintendo: Fix unused-const-variable compiler warning"")

is missing a Signed-off-by from its author and committer.

Reverts are commits as well.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi all,

Commit

  87c7ee7ad85a ("HID: asus: Prevent Claymore sending suspend event")

is missing a Signed-off-by from its author.

Actually it is just spelled wrong.  Also, please keep all the commit
message tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the hid tree

[Jiri Kosina]

On Wed, 24 Jun 2020, Stephen Rothwell wrote:

> Commit
> 
>   6d7ccae2e093 ("Revert "HID: allow building hid.ko as an external module"")
> 
> is missing a Signed-off-by from its author and committer.
> 
> Reverts are commits as well and need SOB tags and (preferably) an
> explanatory commit message.

The commit+revert pair is there only for linux-next (to maintain linear 
history there), the branch that contains the actual buggy commit will 
never make it to Linus.

Thanks,

-- 
Jiri Kosina
SUSE Labs

linux-next: Signed-off-by missing for commit in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

Hi all,

Commit

  6d7ccae2e093 ("Revert "HID: allow building hid.ko as an external module"")

is missing a Signed-off-by from its author and committer.

Reverts are commits as well and need SOB tags and (preferably) an
explanatory commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi Rodrigo,

On Wed, 16 May 2018 16:21:31 +0200 Rodrigo Rivas Costa <rodrigorivascosta@gmail.com> wrote:
>
> I'm the author of this commit. Sorry for that, but I'm unsure about what
> is to be done now. Should I resubmit the patch? Or can it be amended any
> other way? Or it is not a big deal anyway?

Its up to Jiri (the tree owner).  Some rebase the tree to add the SOB,
some prefer to just use it as a learning experience :-)
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the hid tree

[Rodrigo Rivas Costa]

On Wed, May 16, 2018 at 07:17:40AM +1000, Stephen Rothwell wrote:
> Hi Jiri,
> 
> Commit
> 
>   f82719790751 ("HID: steam: add battery device.")
> 
> is missing a Signed-off-by from its author.
Hi, Stephen, Jiri
I'm the author of this commit. Sorry for that, but I'm unsure about what
is to be done now. Should I resubmit the patch? Or can it be amended any
other way? Or it is not a big deal anyway?

Best regards.
--
Rodrigo Rivas Costa

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Signed-off-by missing for commit in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

Hi Jiri,

Commit

  f82719790751 ("HID: steam: add battery device.")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]