Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Signed-off-by missing for commit in the hid tree
@ 2020-06-20 21:51 Stephen Rothwell
  2020-06-22  7:59 ` Cristian Klein
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2020-06-20 21:51 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Cristian Klein


[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

Hi all,

Commit

  470376737e88 ("HID: allow building hid.ko as an external module")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the hid tree
  2020-06-20 21:51 linux-next: Signed-off-by missing for commit in the hid tree Stephen Rothwell
@ 2020-06-22  7:59 ` Cristian Klein
  2020-06-23 11:46   ` [PATCH] Allow building hid.ko as an "external" module kernel test robot
  0 siblings, 1 reply; 8+ messages in thread
From: Cristian Klein @ 2020-06-22  7:59 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jiri Kosina, Benjamin Tissoires, Linux Next Mailing List,
	Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

On Sun, Jun 21, 2020 at 07:51:24AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   470376737e88 ("HID: allow building hid.ko as an external module")
> 
> is missing a Signed-off-by from its author.
> 
> -- 
> Cheers,
> Stephen Rothwell

Hi,

My bad. Please find attached the corrected patch.

Cheers,
Cristian

[-- Attachment #2: 0001-Allow-building-hid.ko-as-an-external-module.patch --]
[-- Type: text/x-diff, Size: 2478 bytes --]

From 8005724373d8cecb241c013d16b2242c7c1fb39e Mon Sep 17 00:00:00 2001
From: Cristian Klein <cristian.klein@elastisys.com>
Date: Mon, 22 Jun 2020 08:47:58 +0200
Subject: [PATCH] Allow building hid.ko as an "external" module

For quickly testing USB HID quirks with a larger community, it is useful
to be able to build hid.ko as an external module, e.g., against the
source code of the running kernel.

Before this patch this failed as follows:
```
$ make -C /lib/modules/$(uname -r)/build M=$PWD/drivers/hid
make: Entering directory '/usr/src/linux-headers-5.3.0-51-generic'
  CC [M]  /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid-core.o
  CC [M]  /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.o
  LD [M]  /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/init.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/hbm.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/client.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/bus.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/dma-if.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/client-buffers.o
  LD [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/intel-ishtp.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.o
/home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.c:12:10: fatal error: client.h: No such file or directory
   12 | #include "client.h"
      |          ^~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.build:290: /home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.o] Error 1
make[1]: *** [scripts/Makefile.build:519: /home/cklein/linux/drivers/hid/intel-ish-hid] Error 2
make: *** [Makefile:1656: _module_/home/cklein/linux/drivers/hid] Error 2
make: Leaving directory '/usr/src/linux-headers-5.3.0-51-generic'
```

Signed-off-by: Cristian Klein <cristian.klein@elastisys.com>
---
 drivers/hid/intel-ish-hid/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/Makefile b/drivers/hid/intel-ish-hid/Makefile
index f0a82b1c7..db4974c43 100644
--- a/drivers/hid/intel-ish-hid/Makefile
+++ b/drivers/hid/intel-ish-hid/Makefile
@@ -23,4 +23,4 @@ intel-ishtp-hid-objs += ishtp-hid-client.o
 obj-$(CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER) += intel-ishtp-loader.o
 intel-ishtp-loader-objs += ishtp-fw-loader.o
 
-ccflags-y += -I $(srctree)/$(src)/ishtp
+ccflags-y += -I $(src)/ishtp
-- 
2.20.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Allow building hid.ko as an "external" module
  2020-06-22  7:59 ` Cristian Klein
@ 2020-06-23 11:46   ` kernel test robot
  0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2020-06-23 11:46 UTC (permalink / raw)
  To: Cristian Klein, Stephen Rothwell
  Cc: kbuild-all, Jiri Kosina, Benjamin Tissoires,
	Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

Hi Cristian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on jikos-trivial/for-next]
[also build test ERROR on linux/master linus/master v5.8-rc2 next-20200623]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Cristian-Klein/Allow-building-hid-ko-as-an-external-module/20200622-160113
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git for-next
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/hid/intel-ish-hid/ipc/ipc.c:12:10: fatal error: client.h: No such file or directory
      12 | #include "client.h"
         |          ^~~~~~~~~~
   compilation terminated.
--
>> drivers/hid/intel-ish-hid/ipc/pci-ish.c:22:10: fatal error: ishtp-dev.h: No such file or directory
      22 | #include "ishtp-dev.h"
         |          ^~~~~~~~~~~~~
   compilation terminated.

vim +12 drivers/hid/intel-ish-hid/ipc/ipc.c

ae02e5d40d5f82 Srinivas Pandruvada 2016-08-07 @12  #include "client.h"
ae02e5d40d5f82 Srinivas Pandruvada 2016-08-07  13  #include "hw-ish.h"
ae02e5d40d5f82 Srinivas Pandruvada 2016-08-07  14  #include "hbm.h"
ae02e5d40d5f82 Srinivas Pandruvada 2016-08-07  15  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48267 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the hid tree
  2020-06-24  7:52 linux-next: Signed-off-by missing for commit in the hid tree Stephen Rothwell
@ 2020-06-24  7:56 ` Jiri Kosina
  0 siblings, 0 replies; 8+ messages in thread
From: Jiri Kosina @ 2020-06-24  7:56 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Benjamin Tissoires, Linux Next Mailing List, Linux Kernel Mailing List

On Wed, 24 Jun 2020, Stephen Rothwell wrote:

> Commit
> 
>   6d7ccae2e093 ("Revert "HID: allow building hid.ko as an external module"")
> 
> is missing a Signed-off-by from its author and committer.
> 
> Reverts are commits as well and need SOB tags and (preferably) an
> explanatory commit message.

The commit+revert pair is there only for linux-next (to maintain linear 
history there), the branch that contains the actual buggy commit will 
never make it to Linus.

Thanks,

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Signed-off-by missing for commit in the hid tree
@ 2020-06-24  7:52 Stephen Rothwell
  2020-06-24  7:56 ` Jiri Kosina
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2020-06-24  7:52 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires
  Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

Hi all,

Commit

  6d7ccae2e093 ("Revert "HID: allow building hid.ko as an external module"")

is missing a Signed-off-by from its author and committer.

Reverts are commits as well and need SOB tags and (preferably) an
explanatory commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the hid tree
  2018-05-16 14:21 ` Rodrigo Rivas Costa
@ 2018-05-17  0:46   ` Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2018-05-17  0:46 UTC (permalink / raw)
  To: Rodrigo Rivas Costa
  Cc: Jiri Kosina, Linux-Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi Rodrigo,

On Wed, 16 May 2018 16:21:31 +0200 Rodrigo Rivas Costa <rodrigorivascosta@gmail.com> wrote:
>
> I'm the author of this commit. Sorry for that, but I'm unsure about what
> is to be done now. Should I resubmit the patch? Or can it be amended any
> other way? Or it is not a big deal anyway?

Its up to Jiri (the tree owner).  Some rebase the tree to add the SOB,
some prefer to just use it as a learning experience :-)
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the hid tree
  2018-05-15 21:17 Stephen Rothwell
@ 2018-05-16 14:21 ` Rodrigo Rivas Costa
  2018-05-17  0:46   ` Stephen Rothwell
  0 siblings, 1 reply; 8+ messages in thread
From: Rodrigo Rivas Costa @ 2018-05-16 14:21 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jiri Kosina, Linux-Next Mailing List, Linux Kernel Mailing List

On Wed, May 16, 2018 at 07:17:40AM +1000, Stephen Rothwell wrote:
> Hi Jiri,
> 
> Commit
> 
>   f82719790751 ("HID: steam: add battery device.")
> 
> is missing a Signed-off-by from its author.
Hi, Stephen, Jiri
I'm the author of this commit. Sorry for that, but I'm unsure about what
is to be done now. Should I resubmit the patch? Or can it be amended any
other way? Or it is not a big deal anyway?

Best regards.
--
Rodrigo Rivas Costa

> 
> -- 
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Signed-off-by missing for commit in the hid tree
@ 2018-05-15 21:17 Stephen Rothwell
  2018-05-16 14:21 ` Rodrigo Rivas Costa
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2018-05-15 21:17 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Rodrigo Rivas Costa


[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

Hi Jiri,

Commit

  f82719790751 ("HID: steam: add battery device.")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-20 21:51 linux-next: Signed-off-by missing for commit in the hid tree Stephen Rothwell
2020-06-22  7:59 ` Cristian Klein
2020-06-23 11:46   ` [PATCH] Allow building hid.ko as an "external" module kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2020-06-24  7:52 linux-next: Signed-off-by missing for commit in the hid tree Stephen Rothwell
2020-06-24  7:56 ` Jiri Kosina
2018-05-15 21:17 Stephen Rothwell
2018-05-16 14:21 ` Rodrigo Rivas Costa
2018-05-17  0:46   ` Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git