From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E532C433DF for ; Mon, 22 Jun 2020 21:50:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40F062082F for ; Mon, 22 Jun 2020 21:50:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lnWs0M9b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730626AbgFVVuN (ORCPT ); Mon, 22 Jun 2020 17:50:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730527AbgFVVuL (ORCPT ); Mon, 22 Jun 2020 17:50:11 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AA9EC061795 for ; Mon, 22 Jun 2020 14:50:11 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id g12so8155964pll.10 for ; Mon, 22 Jun 2020 14:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HO9AnfyoV6P1ml9RmfpxKfaeSgxzWVOaT2Vq3vNBOcc=; b=lnWs0M9bdocVBBBLhw+yUPaupQsgnQNFCJK+pJiVmZ07vNw8nK3vhTqTM7fjRtPrmQ BeXp8Y3BLVYRrEviTgHIDqlkTfPgwxk6+SKhwBh0lYzJXifq+81hLQjHZHXlwvYE7D3Z 338rLHdodna0JLZ+58OXLxtuOD7htkoppjQHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HO9AnfyoV6P1ml9RmfpxKfaeSgxzWVOaT2Vq3vNBOcc=; b=qD3tToxrBoDdptkZ8qI8aFLo6lzwvIQIvEWAmCcJ7oCiuIKE1b2h0jlvsKbAR9aTSu Wl+j68B3FYGE6j4V26ieo5pshtpFwzscKClR7o52WnQfkuhNjzdiYlCP/9MbyCr4ZXj3 n39Gngt7ZQkzOzjN/V97ELweMWXpGl0VIurXtsK8or73EW0sxWKWmMPBLnunRduw88Wx frTBl7MapaXkDua0eVmJTj/lS5Iln79tNgX+URv6Hq5l0W+EefyeAqcfZFJxQ+Petaaw SSVaAhU98rVd/vB+qM1lYSOJ6G7Eeln0t6FFpbofwO01PmDZzhq8Kk1X0kPPZD3nCMUS CCuA== X-Gm-Message-State: AOAM531yLv3xnnoskEs6Y0nbMkMzpU87snUZzBcBNIIvkc5WL+hQa6R6 dz3UTtwm7xXNr2QcOtlJfbz2Gg== X-Google-Smtp-Source: ABdhPJxa5Z82Hov2tfdjL/FmMAkdOj7Sb3arynM+T3CBUgUa49ZBQBQv4Q5BIBd9XVoezZqa3CUsJQ== X-Received: by 2002:a17:90a:a405:: with SMTP id y5mr20189871pjp.15.1592862611014; Mon, 22 Jun 2020 14:50:11 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p14sm428618pjf.32.2020.06.22.14.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 14:50:09 -0700 (PDT) Date: Mon, 22 Jun 2020 14:50:08 -0700 From: Kees Cook To: Randy Dunlap Cc: akpm@linux-foundation.org, broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" Subject: Re: mmotm 2020-06-20-21-36 uploaded (lkdtm/bugs.c) Message-ID: <202006221445.36E03CCBE9@keescook> References: <20200621043737.pb6JV%akpm@linux-foundation.org> <20a39fd4-622d-693c-c8d6-1fbab12af62a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20a39fd4-622d-693c-c8d6-1fbab12af62a@gmail.com> Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, Jun 22, 2020 at 08:37:17AM -0700, Randy Dunlap wrote: > On 6/20/20 9:37 PM, akpm@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2020-06-20-21-36 has been uploaded to > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment: > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > > more than once a week. > > drivers/misc/lkdtm/bugs.c has build errors when building UML for i386 > (allmodconfig or allyesconfig): > > > In file included from ../drivers/misc/lkdtm/bugs.c:17:0: > ../arch/x86/um/asm/desc.h:7:0: warning: "LDT_empty" redefined > #define LDT_empty(info) (\ > > In file included from ../arch/um/include/asm/mmu.h:10:0, > from ../include/linux/mm_types.h:18, > from ../include/linux/sched/signal.h:13, > from ../drivers/misc/lkdtm/bugs.c:11: > ../arch/x86/um/asm/mm_context.h:65:0: note: this is the location of the previous definition > #define LDT_empty(info) (_LDT_empty(info)) The LKDTM test landed a while ago: b09511c253e5 ("lkdtm: Add a DOUBLE_FAULT crash type on x86") and nothing has touched arch/x86/um/asm/desc.h nor arch/x86/um/asm/mm_context.h in a while either. Regardless, it seems arch/x86/um/asm/desc.h is not needed any more? -- Kees Cook