linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Jun 24 [build failure on arm64]
Date: Wed, 24 Jun 2020 11:55:28 +0100	[thread overview]
Message-ID: <20200624105528.GB6134@willie-the-truck> (raw)
In-Reply-To: <7a7e31a8-9a7b-2428-ad83-2264f20bdc2d@hisilicon.com>

On Wed, Jun 24, 2020 at 05:08:56PM +0800, Shaokun Zhang wrote:
> +Will Deacon,
> 
> Hi Will,
> 
> There's a build failure on arm64:
> 
>   CALL    scripts/atomic/check-atomics.sh
>   CALL    scripts/checksyscalls.sh
>   LD      arch/arm64/kernel/vdso/vdso.so.dbg
> ld: unrecognized option '--no-eh-frame-hdr'
> ld: use the --help option for usage information
> arch/arm64/kernel/vdso/Makefile:64: recipe for target
> 'arch/arm64/kernel/vdso/vdso.so.dbg' failed
> make[1]: *** [arch/arm64/kernel/vdso/vdso.so.dbg] Error 1
> arch/arm64/Makefile:175: recipe for target 'vdso_prepare' failed
> make: *** [vdso_prepare] Error 2
> 
> GCC version is followed:
> gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609
> 
> It seems caused by
> 87676cfca141 arm64: vdso: Disable dwarf unwinding through the sigreturn
> trampoline

Urgh, binutils quality strikes again. If you're able to reproduce locally,
can you try the diff below, please? All the linkers I have kicking around
seem to support --no-eh-frame-hdr.

Will

--->8

diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile
index 1e5a940532da..97d3d3632093 100644
--- a/arch/arm64/kernel/vdso/Makefile
+++ b/arch/arm64/kernel/vdso/Makefile
@@ -23,8 +23,9 @@ btildflags-$(CONFIG_ARM64_BTI_KERNEL) += -z force-bti
 # potential future proofing if we end up with internal calls to the exported
 # routines, as x86 does (see 6f121e548f83 ("x86, vdso: Reimplement vdso.so
 # preparation in build-time C")).
-ldflags-y := -shared -nostdlib -soname=linux-vdso.so.1 --hash-style=sysv \
-               -Bsymbolic --no-eh-frame-hdr --build-id -n $(btildflags-y) -T
+ldflags-y := -shared -nostdlib -soname=linux-vdso.so.1 --hash-style=sysv       \
+            -Bsymbolic $(call ld-option, --no-eh-frame-hdr) --build-id -n      \
+            $(btildflags-y) -T
 
 ccflags-y := -fno-common -fno-builtin -fno-stack-protector -ffixed-x18
 ccflags-y += -DDISABLE_BRANCH_PROFILING


  reply	other threads:[~2020-06-24 10:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24  6:53 linux-next: Tree for Jun 24 Stephen Rothwell
2020-06-24  9:08 ` linux-next: Tree for Jun 24 [build failure on arm64] Shaokun Zhang
2020-06-24 10:55   ` Will Deacon [this message]
2020-06-24 11:57     ` Jon Hunter
2020-06-24 12:22       ` Will Deacon
2020-06-24 12:29         ` Jon Hunter
2020-06-28  0:54     ` Shaokun Zhang
2020-06-24 14:37 ` linux-next: Tree for Jun 24 (scsi -> ata) Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200624105528.GB6134@willie-the-truck \
    --to=will@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).