Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the printk tree
@ 2020-07-27 13:46 Stephen Rothwell
  2020-07-27 15:07 ` John Ogness
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2020-07-27 13:46 UTC (permalink / raw)
  To: Petr Mladek
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, John Ogness,
	Sergey Senozhatsky


[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Hi all,

In commit

  96b917f8e9ec ("printk: ringbuffer: support dataless records")

Fixes tag

  Fixes: ("printk: use the lockless ringbuffer")

has these problem(s):

  - No SHA1 recognised

Maybe you meant

Fixes: 896fbe20b4e2 ("printk: use the lockless ringbuffer")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Fixes tag needs some work in the printk tree
  2020-07-27 13:46 linux-next: Fixes tag needs some work in the printk tree Stephen Rothwell
@ 2020-07-27 15:07 ` John Ogness
  2020-07-27 22:19   ` Stephen Rothwell
  0 siblings, 1 reply; 6+ messages in thread
From: John Ogness @ 2020-07-27 15:07 UTC (permalink / raw)
  To: Stephen Rothwell, Petr Mladek
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sergey Senozhatsky

On 2020-07-27, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> In commit
>
>   96b917f8e9ec ("printk: ringbuffer: support dataless records")
>
> Fixes tag
>
>   Fixes: ("printk: use the lockless ringbuffer")
>
> has these problem(s):
>
>   - No SHA1 recognised
>
> Maybe you meant
>
> Fixes: 896fbe20b4e2 ("printk: use the lockless ringbuffer")

Yes, sorry. I did not think linux-next SHA1 hashes were used in commit
logs.

John Ogness

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Fixes tag needs some work in the printk tree
  2020-07-27 15:07 ` John Ogness
@ 2020-07-27 22:19   ` Stephen Rothwell
  2020-07-28  1:22     ` Sergey Senozhatsky
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2020-07-27 22:19 UTC (permalink / raw)
  To: John Ogness
  Cc: Petr Mladek, Linux Next Mailing List, Linux Kernel Mailing List,
	Sergey Senozhatsky


[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

Hi John,

On Mon, 27 Jul 2020 17:13:44 +0206 John Ogness <john.ogness@linutronix.de> wrote:
>
> On 2020-07-27, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > In commit
> >
> >   96b917f8e9ec ("printk: ringbuffer: support dataless records")
> >
> > Fixes tag
> >
> >   Fixes: ("printk: use the lockless ringbuffer")
> >
> > has these problem(s):
> >
> >   - No SHA1 recognised
> >
> > Maybe you meant
> >
> > Fixes: 896fbe20b4e2 ("printk: use the lockless ringbuffer")  
> 
> Yes, sorry. I did not think linux-next SHA1 hashes were used in commit
> logs.

Well, it makes sense to use them if they are stable (i.e. the tree they
are in does not rebase) which, by this part of the cycle, I would
*hope* would be true (but sometimes isn't :-().

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Fixes tag needs some work in the printk tree
  2020-07-27 22:19   ` Stephen Rothwell
@ 2020-07-28  1:22     ` Sergey Senozhatsky
  0 siblings, 0 replies; 6+ messages in thread
From: Sergey Senozhatsky @ 2020-07-28  1:22 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: John Ogness, Petr Mladek, Linux Next Mailing List,
	Linux Kernel Mailing List, Sergey Senozhatsky

On (20/07/28 08:19), Stephen Rothwell wrote:
> On Mon, 27 Jul 2020 17:13:44 +0206 John Ogness <john.ogness@linutronix.de> wrote:
> >
> > On 2020-07-27, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
[..]
> > > Maybe you meant
> > >
> > > Fixes: 896fbe20b4e2 ("printk: use the lockless ringbuffer")  
> >
> > Yes, sorry. I did not think linux-next SHA1 hashes were used in commit
> > logs.

Neither did I. The tag made sense to me, because it fixes a regression
after all.

> Well, it makes sense to use them if they are stable (i.e. the tree they
> are in does not rebase) which, by this part of the cycle, I would
> *hope* would be true (but sometimes isn't :-().

So we probably should not have Fixes tags in linux-next commits
(printk rework branch) then, for the time being. I'll keep an eye
on that.

	-ss

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Fixes tag needs some work in the printk tree
  2019-04-25 13:30 Stephen Rothwell
@ 2019-04-26  7:37 ` Petr Mladek
  0 siblings, 0 replies; 6+ messages in thread
From: Petr Mladek @ 2019-04-26  7:37 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

On Thu 2019-04-25 23:30:49, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   e43bb4d0feb8 ("vsprintf: Consistent %pK handling for kptr_restrict == 0")
> 
> Fixes tag
> 
>   Fixes: commit ef0010a30935de4e0211 ("vsprintf: don't use 'restricted_pointer()' when not restricting")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected

Thanks for the report! I have just fixed it.

Best Regards,
Petr

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: Fixes tag needs some work in the printk tree
@ 2019-04-25 13:30 Stephen Rothwell
  2019-04-26  7:37 ` Petr Mladek
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2019-04-25 13:30 UTC (permalink / raw)
  To: Petr Mladek; +Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Hi all,

In commit

  e43bb4d0feb8 ("vsprintf: Consistent %pK handling for kptr_restrict == 0")

Fixes tag

  Fixes: commit ef0010a30935de4e0211 ("vsprintf: don't use 'restricted_pointer()' when not restricting")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 13:46 linux-next: Fixes tag needs some work in the printk tree Stephen Rothwell
2020-07-27 15:07 ` John Ogness
2020-07-27 22:19   ` Stephen Rothwell
2020-07-28  1:22     ` Sergey Senozhatsky
  -- strict thread matches above, loose matches on Subject: below --
2019-04-25 13:30 Stephen Rothwell
2019-04-26  7:37 ` Petr Mladek

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git