From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A22C433DF for ; Thu, 30 Jul 2020 00:59:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 117B32075D for ; Thu, 30 Jul 2020 00:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728245AbgG3A7i (ORCPT ); Wed, 29 Jul 2020 20:59:38 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:34210 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726859AbgG3A7i (ORCPT ); Wed, 29 Jul 2020 20:59:38 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1k0wup-00050D-0F; Thu, 30 Jul 2020 10:59:24 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 30 Jul 2020 10:59:22 +1000 Date: Thu, 30 Jul 2020 10:59:22 +1000 From: Herbert Xu To: Andy Shevchenko Cc: Waiman Long , Stephen Rothwell , Petr Mladek , Linux Next Mailing List , Linux Kernel Mailing List , Sergey Senozhatsky , "Steven Rostedt (VMware)" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop Message-ID: <20200730005922.GA9710@gondor.apana.org.au> References: <20200729210311.425d0e9b@canb.auug.org.au> <20200729114757.GA19388@gondor.apana.org.au> <20200729122807.GA7047@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Wed, Jul 29, 2020 at 06:04:57PM +0300, Andy Shevchenko wrote: > On Wed, Jul 29, 2020 at 4:35 PM Waiman Long wrote: > > On 7/29/20 8:28 AM, Herbert Xu wrote: > > ... > > > This patch series looks good to me. I just wonder if we should also move > > ATOMIC64_INIT() to types.h for symmetry purpose. Anyway, > > Same question here. Yes I almost started doing it but at least one architecture (arc) had a custom atomic64_t so I kept it out just to be on the safe side. We certainly could do this as a follow-up patch. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt