From: Bjorn Helgaas <helgaas@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Linux Next Mailing List" <linux-next@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>
Subject: Re: linux-next: build warning after merge of the pci tree
Date: Tue, 4 Aug 2020 21:29:01 -0500 [thread overview]
Message-ID: <20200805022901.GA464417@bjorn-Precision-5520> (raw)
In-Reply-To: <20200805113216.28ddc0f2@canb.auug.org.au>
On Wed, Aug 05, 2020 at 11:32:16AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the pci tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/pci/controller/pcie-altera.c: In function 'altera_pcie_parse_dt':
> drivers/pci/controller/pcie-altera.c:697:17: warning: unused variable 'dev' [-Wunused-variable]
> 697 | struct device *dev = &pcie->pdev->dev;
> | ^~~
>
> Introduced by commit
>
> caecb05c8000 ("PCI: Remove dev_err() when handing an error from platform_get_irq()")
Yeah, I blew it, sorry.
e2dcd20b1645 ("PCI: controller: Convert to
devm_platform_ioremap_resource_byname()") removed one use of "dev",
and caecb05c8000 ("PCI: Remove dev_err() when handing an error from
platform_get_irq()") removed the other. They were on independent
branches and I didn't catch it when merging them. I thought I had
built the result, but I must not have.
Fixed and re-pushed.
next prev parent reply other threads:[~2020-08-05 2:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 1:32 linux-next: build warning after merge of the pci tree Stephen Rothwell
2020-08-05 2:29 ` Bjorn Helgaas [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-09 2:38 Stephen Rothwell
2020-09-15 3:43 ` Stephen Rothwell
2020-09-09 2:37 Stephen Rothwell
2020-09-09 16:06 ` Rob Herring
2020-09-15 3:47 ` Stephen Rothwell
2020-09-15 10:53 ` Lorenzo Pieralisi
2020-09-15 17:22 ` Bjorn Helgaas
2020-09-02 1:07 Stephen Rothwell
2020-09-02 12:33 ` Bjorn Helgaas
2020-09-02 14:13 ` Vaibhav Gupta
2016-06-23 1:51 Stephen Rothwell
2016-06-23 16:48 ` Bjorn Helgaas
2016-06-24 8:07 ` Johannes Thumshirn
2013-09-03 23:55 Stephen Rothwell
2013-09-03 23:59 ` Bjorn Helgaas
2012-12-10 9:03 Stephen Rothwell
2012-12-10 21:25 ` Bjorn Helgaas
2012-12-10 23:21 ` Bjorn Helgaas
2012-05-01 6:08 Stephen Rothwell
2012-05-01 7:35 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805022901.GA464417@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).