From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81298C433E7 for ; Mon, 12 Oct 2020 05:13:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2966120780 for ; Mon, 12 Oct 2020 05:13:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="QNXBnStp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbgJLFNo (ORCPT ); Mon, 12 Oct 2020 01:13:44 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:45055 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725967AbgJLFNo (ORCPT ); Mon, 12 Oct 2020 01:13:44 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4C8mzl4WHpz9sS8; Mon, 12 Oct 2020 16:13:39 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1602479621; bh=N9dW3z7wNBwEnucfX/iwZh7H+XANweIaXriLKck+wP8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QNXBnStpBYKekdJdJj+sg5fDnugd6iJCajr5gUmAVHfiu0QQ7La5C0zKBwoOmYToY 3TSuCMFi70BJuJ9SN0tQAT9vptKIq0elnKvUh4ailkv5noO6Nu+XAqe9/K8qXg8hj9 Jcex7p/lEKYqPr0It6o36Z0EIj+PO+pkpsQSfHexiPeyeocSHCTLXjwwCnhXSwVxqf V+QbIu9Uda6ZlkfXahjihw1XBnPIWYbVJuXscbar8qqSLFLKR+1kai6Fm77BFcSgRP CPubyCb+3cg+PMv+rEi1eoYivDDL4prUuK57ayODzCVof7qF8yjQK4km7pfySmfGo0 aoj/iTEitOUOw== Date: Mon, 12 Oct 2020 16:13:38 +1100 From: Stephen Rothwell To: Jiri Olsa Cc: Vasily Gorbik , Arnaldo Carvalho de Melo , Josh Poimboeuf , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Mark Rutland , Alexander Shishkin , Namhyung Kim , "H. Peter Anvin" , Masami Hiramatsu , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: [PATCH RESEND 1/1] perf build: Allow nested externs to enable BUILD_BUG() usage Message-ID: <20201012161338.3c94f6e5@canb.auug.org.au> In-Reply-To: <20201012085936.241cc62d@canb.auug.org.au> References: <20201009112327.GC656950@krava> <20201009124111.GD656950@krava> <20201012085936.241cc62d@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/4AgCVPaFVmv3l11czc64wIJ"; protocol="application/pgp-signature"; micalg=pgp-sha256 Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org --Sig_/4AgCVPaFVmv3l11czc64wIJ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Mon, 12 Oct 2020 08:59:36 +1100 Stephen Rothwell = wrote: > > On Fri, 9 Oct 2020 14:41:11 +0200 Jiri Olsa wrote: > > > > On Fri, Oct 09, 2020 at 02:25:23PM +0200, Vasily Gorbik wrote: =20 > > > Currently BUILD_BUG() macro is expanded to smth like the following: > > > do { > > > extern void __compiletime_assert_0(void) > > > __attribute__((error("BUILD_BUG failed"))); > > > if (!(!(1))) > > > __compiletime_assert_0(); > > > } while (0); > > >=20 > > > If used in a function body this obviously would produce build errors > > > with -Wnested-externs and -Werror. > > >=20 > > > To enable BUILD_BUG() usage in tools/arch/x86/lib/insn.c which perf > > > includes in intel-pt-decoder, build perf without -Wnested-externs. > > >=20 > > > Reported-by: Stephen Rothwell > > > Signed-off-by: Vasily Gorbik =20 > >=20 > > that one applied nicely ;-) thanks > >=20 > > Acked-by: Jiri Olsa =20 >=20 > I will apply that patch to the merge of the tip tree today (instead of > reverting the series I reverted in Friday) (unless I get an update of > the tip tree containing it, of course). Tested-by: Stephen Rothwell # build tested --=20 Cheers, Stephen Rothwell --Sig_/4AgCVPaFVmv3l11czc64wIJ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl+D5gIACgkQAVBC80lX 0GwaXQf8Df4cAa7F6f6di3mQnyp2/awOB6O9oJWhuDuTveX1GiDUaKteCAHxordW 3Ze8HL6ursvrEj0am7YX6Br9l6M86KMYqdYxqbjBKleQhzjek66EHzg8N0Kjhvyi yfg6THPe2pseNFwnBMJ11gPeLtLH7Ce3FyYtVQDBWrgsX58zxP1tFZURuch/S940 IEM6Y5CBrm77PajODkvPzCzplgn69HVQRraPFDxjlJ3Kof7m02d5xGcvmoAt3Q04 FVvGY4fgcO709G1GXhHl/WemP1o2rkdJ9pTil7MTZ9MPVCQWJTPKm2LamN5pCmxs dQmwdmOy+/d3BQr4mRYfXoBCYSNC7A== =NStr -----END PGP SIGNATURE----- --Sig_/4AgCVPaFVmv3l11czc64wIJ--