From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: John Ogness <john.ogness@linutronix.de>, Petr Mladek <pmladek@suse.com>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
open list <linux-kernel@vger.kernel.org>,
lkft-triage@lists.linaro.org, LTP List <ltp@lists.linux.it>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: BUG: KASAN: global-out-of-bounds in vprintk_store on x86_64
Date: Wed, 14 Oct 2020 21:47:01 +0900 [thread overview]
Message-ID: <20201014124701.GA614@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <CA+G9fYt46oC7-BKryNDaaXPJ9GztvS2cs_7GjYRjanRi4+ryCQ@mail.gmail.com>
On (20/10/14 16:19), Naresh Kamboju wrote:
> Crash log:
> --------------
> [ 221.921944] oom-kill:constraint=CONSTRAINT_MEMCG,nodemask=(null),cpuset=c,mems_allowed=0,oom_memcg=/0,task_memcg=in
> [ 221.922108] ==================================================================
> [ 221.922111] BUG: KASAN: global-out-of-bounds in vprintk_store+0x362/0x3d0
> [ 221.922112] Write of size 2 at addr ffffffffba51dbcd by task
> memcg_test_1/11282
> [ 221.922113]
> [ 221.922114] CPU: 1 PID: 11282 Comm: memcg_test_1 Not tainted
> 5.9.0-next-20201013 #1
> [ 221.922116] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
> 2.0b 07/27/2017
> [ 221.922116] Call Trace:
> [ 221.922117] dump_stack+0xa4/0xd9
> [ 221.922118] print_address_description.constprop.0+0x21/0x210
> [ 221.922119] ? _raw_write_lock_bh+0xe0/0xe0
> [ 221.922120] ? vprintk_store+0x362/0x3d0
> [ 221.922121] kasan_report.cold+0x37/0x7c
> [ 221.922122] ? vprintk_store+0x362/0x3d0
> [ 221.922123] check_memory_region+0x18c/0x1f0
> [ 221.922124] memcpy+0x3c/0x60
> [ 221.922125] vprintk_store+0x362/0x3d0
> [ 221.922125] ? __ia32_sys_syslog+0x50/0x50
> [ 221.922126] ? _raw_spin_lock_irqsave+0x9b/0x100
> [ 221.922127] ? _raw_spin_lock_irq+0xf0/0xf0
> [ 221.922128] ? __kasan_check_write+0x14/0x20
> [ 221.922129] vprintk_emit+0x8d/0x1f0
> [ 221.922130] vprintk_default+0x1d/0x20
> [ 221.922131] vprintk_func+0x5a/0x100
> [ 221.922132] printk+0xb2/0xe3
> [ 221.922133] ? swsusp_write.cold+0x189/0x189
> [ 221.922134] ? kernfs_vfs_xattr_set+0x60/0x60
> [ 221.922134] ? _raw_write_lock_bh+0xe0/0xe0
> [ 221.922135] ? trace_hardirqs_on+0x38/0x100
> [ 221.922136] pr_cont_kernfs_path.cold+0x49/0x4b
A side note,
So this brings the question:
#define PATH_MAX 4096
static char kernfs_pr_cont_buf[PATH_MAX];
void pr_cont_kernfs_path(struct kernfs_node *kn)
{
...
if (sz >= sizeof(kernfs_pr_cont_buf)) {
pr_cont("(name too long)");
goto out;
}
pr_cont("%s", kernfs_pr_cont_buf);
...
}
Do we still want to limit printk line to 1024?
There are functions that want longer lines (e.g. kernel boot command
line).
-ss
next prev parent reply other threads:[~2020-10-14 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 10:49 BUG: KASAN: global-out-of-bounds in vprintk_store on x86_64 Naresh Kamboju
2020-10-14 12:47 ` Sergey Senozhatsky [this message]
2020-10-14 14:05 ` Petr Mladek
2020-10-14 15:13 ` Petr Mladek
2020-10-14 17:50 ` [PATCH] printk: ringbuffer: Wrong data pointer when appending small string Petr Mladek
2020-10-15 6:31 ` Sergey Senozhatsky
2020-10-15 9:59 ` John Ogness
2020-10-15 12:22 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014124701.GA614@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=ltp@lists.linux.it \
--cc=naresh.kamboju@linaro.org \
--cc=pmladek@suse.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=rostedt@goodmis.org \
--cc=rppt@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).