linux-next: build warning after merge of the hwmon-staging tree

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/hwmon/pwm-fan.c: In function 'pwm_fan_is_visible':
drivers/hwmon/pwm-fan.c:167:22: warning: unused variable 'ctx' [-Wunused-variable]
  167 |  struct pwm_fan_ctx *ctx = (struct pwm_fan_ctx *)data;
      |                      ^~~

Introduced by commit

  439ed83acc19 ("hwmon: (pwm-fan) Convert to hwmon_device_register_with_info API")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hwmon-staging tree

[Paul Barker]

On Mon, 30 Nov 2020 at 00:56, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/hwmon/pwm-fan.c: In function 'pwm_fan_is_visible':
> drivers/hwmon/pwm-fan.c:167:22: warning: unused variable 'ctx' [-Wunused-variable]
>   167 |  struct pwm_fan_ctx *ctx = (struct pwm_fan_ctx *)data;
>       |                      ^~~
>
> Introduced by commit
>
>   439ed83acc19 ("hwmon: (pwm-fan) Convert to hwmon_device_register_with_info API")
>

Ah yes. I removed the code that used ctx but forgot to remove the
assignment itself. I'm surprised it didn't generate a warning for me.

I can fix it up tomorrow and send a v3 patch series.

Thanks,

-- 
Paul Barker
Konsulko Group

Re: linux-next: build warning after merge of the hwmon-staging tree

[Guenter Roeck]

On Mon, Nov 30, 2020 at 01:14:03AM +0000, Paul Barker wrote:
> On Mon, 30 Nov 2020 at 00:56, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the hwmon-staging tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/hwmon/pwm-fan.c: In function 'pwm_fan_is_visible':
> > drivers/hwmon/pwm-fan.c:167:22: warning: unused variable 'ctx' [-Wunused-variable]
> >   167 |  struct pwm_fan_ctx *ctx = (struct pwm_fan_ctx *)data;
> >       |                      ^~~
> >
> > Introduced by commit
> >
> >   439ed83acc19 ("hwmon: (pwm-fan) Convert to hwmon_device_register_with_info API")
> >
> 
> Ah yes. I removed the code that used ctx but forgot to remove the
> assignment itself. I'm surprised it didn't generate a warning for me.
> 
> I can fix it up tomorrow and send a v3 patch series.
> 
Not necessary; I already took care of it.

Guenter

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/hwmon/adp1050.rst:15: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commit

  8631d463d634 ("hwmon: pmbus: adp1050: Add driver support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced this warning:

MAINTAINERS:27997: WARNING: unknown document: '../devicetree/bindings/hwmon/ltc4286'

Introduced by commit

  892a1aa5d051 ("dt-bindings: hwmon: Add lltc ltc4286 driver bindings")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hwmon-staging tree

[Guenter Roeck]

On 12/11/23 19:12, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> MAINTAINERS:27997: WARNING: unknown document: '../devicetree/bindings/hwmon/ltc4286'
> 
> Introduced by commit
> 
>    892a1aa5d051 ("dt-bindings: hwmon: Add lltc ltc4286 driver bindings")
> 

Fixed up.

Thanks,
Guenter

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced this warning:

/home/sfr/next/next/Documentation/hwmon/ltc2991.rst:35: WARNING: Title underline too short.

sysfs-Interface
-------------

Introduced by commit

  522ea9d023df ("hwmon: Add driver for ltc2991")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/hwmon/emc2305.rst:16: WARNING: Title underline too short.

Introduced by commit

  47efd143900b ("docs: hwmon: add emc2305.rst to docs")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

WARNING: unmet direct dependencies detected for SENSORS_NCT6775
  Depends on [n]: HWMON [=y] && !PPC [=y] && (ACPI_WMI [=n] || ACPI_WMI [=n]=n)
  Selected by [y]:
  - SENSORS_NCT6775_I2C [=y] && HWMON [=y] && I2C [=y]

Probably introduced by commit

  58f1d9ebfce6 ("hwmon: (nct6775) Add i2c driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hwmon-staging tree

[Zev Weiss]

On Tue, May 10, 2022 at 03:11:04AM PDT, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the hwmon-staging tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> WARNING: unmet direct dependencies detected for SENSORS_NCT6775
>   Depends on [n]: HWMON [=y] && !PPC [=y] && (ACPI_WMI [=n] || ACPI_WMI [=n]=n)
>   Selected by [y]:
>   - SENSORS_NCT6775_I2C [=y] && HWMON [=y] && I2C [=y]
> 
> Probably introduced by commit
> 
>   58f1d9ebfce6 ("hwmon: (nct6775) Add i2c driver")
> 

Ah -- yes, thanks.  The Kconfig symbols in that patch series underwent 
some changes between revisions during review and I missed a couple of 
places that should have been updated.  I believe the patch below should 
fix it.

Thanks,
Zev


From 817067c631ca7c7537be4bd18b0c9b5d2b735e54 Mon Sep 17 00:00:00 2001
From: Zev Weiss <zev@bewilderbeest.net>
Date: Tue, 10 May 2022 03:22:20 -0700
Subject: [PATCH] hwmon: (nct6775) Fix Kconfig references in
 SENSORS_NCT6775_I2C

In the process of renaming some Kconfig symbols during the review
process a couple of updates got omitted.  Make the i2c driver select
the correct dependency (the core module, not the platform driver), and
refer to the intended symbol for the platform driver in its help text.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
---
 drivers/hwmon/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index fe49dccf16bf..590d3d550acb 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1506,7 +1506,7 @@ config SENSORS_NCT6775_I2C
 	tristate "I2C driver for Nuvoton NCT6775F and compatibles"
 	depends on I2C
 	select REGMAP_I2C
-	select SENSORS_NCT6775
+	select SENSORS_NCT6775_CORE
 	help
 	  If you say yes here you get support for the hardware monitoring
 	  functionality of the Nuvoton NCT6106D, NCT6775F, NCT6776F, NCT6779D,
@@ -1514,7 +1514,7 @@ config SENSORS_NCT6775_I2C
 	  Super-I/O chips via their I2C interface.
 
 	  If you're not building a kernel for a BMC, this is probably
-	  not the driver you want (see CONFIG_SENSORS_NCT6775_PLATFORM).
+	  not the driver you want (see CONFIG_SENSORS_NCT6775).
 
 	  This driver can also be built as a module. If so, the module
 	  will be called nct6775-i2c.
-- 
2.36.0

Re: linux-next: build warning after merge of the hwmon-staging tree

[Guenter Roeck]

On 5/10/22 03:47, Zev Weiss wrote:
> On Tue, May 10, 2022 at 03:11:04AM PDT, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the hwmon-staging tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>>
>> WARNING: unmet direct dependencies detected for SENSORS_NCT6775
>>    Depends on [n]: HWMON [=y] && !PPC [=y] && (ACPI_WMI [=n] || ACPI_WMI [=n]=n)
>>    Selected by [y]:
>>    - SENSORS_NCT6775_I2C [=y] && HWMON [=y] && I2C [=y]
>>
>> Probably introduced by commit
>>
>>    58f1d9ebfce6 ("hwmon: (nct6775) Add i2c driver")
>>
> 
> Ah -- yes, thanks.  The Kconfig symbols in that patch series underwent
> some changes between revisions during review and I missed a couple of
> places that should have been updated.  I believe the patch below should
> fix it.
> 

I squashed the patch below into the patch introducing the i2c driver
to avoid later bisect issues.

Thanks,
Guenter

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/hwmon/lan966x.rst: WARNING: document isn't included in any toctree

Introduced by commit

  14ed2cdb02e0 ("hwmon: add driver for the Microchip LAN966x SoC")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hwmon-staging tree

[Michael Walle]

Hi,

Am 2022-05-03 09:22, schrieb Stephen Rothwell:
> After merging the hwmon-staging tree, today's linux-next build 
> (htmldocs)
> produced this warning:
> 
> Documentation/hwmon/lan966x.rst: WARNING: document isn't included in 
> any toctree
> 
> Introduced by commit
> 
>   14ed2cdb02e0 ("hwmon: add driver for the Microchip LAN966x SoC")

Ouch. Guenter, should I send a fix on top or will you fix it in
your tree?

-michael

Re: linux-next: build warning after merge of the hwmon-staging tree

[Guenter Roeck]

On 5/3/22 00:34, Michael Walle wrote:
> Hi,
> 
> Am 2022-05-03 09:22, schrieb Stephen Rothwell:
>> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
>> produced this warning:
>>
>> Documentation/hwmon/lan966x.rst: WARNING: document isn't included in any toctree
>>
>> Introduced by commit
>>
>>   14ed2cdb02e0 ("hwmon: add driver for the Microchip LAN966x SoC")
> 
> Ouch. Guenter, should I send a fix on top or will you fix it in
> your tree?
> 

I'll fix it up.

Guenter

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/hwmon/sy7636a-hwmon.rst:4: WARNING: Title underline too short.

Kernel driver sy7636a-hwmon
=========================

Introduced by commit

  de34a4053250 ("hwmon: sy7636a: Add temperature driver for sy7636a")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hwmon-staging tree

[Lee Jones]

On Thu, 10 Feb 2022, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/hwmon/sy7636a-hwmon.rst:4: WARNING: Title underline too short.
> 
> Kernel driver sy7636a-hwmon
> =========================
> 
> Introduced by commit
> 
>   de34a4053250 ("hwmon: sy7636a: Add temperature driver for sy7636a")

Oh wow, that's new (to me), and a little petty, no?

Would you like me to apply this patch to my branch Guenter?

I can either send out a new PR, or let it wallow.

-------- 8< --------

From: Lee Jones <lee.jones@linaro.org>

 Documentation/hwmon/sy7636a-hwmon.rst:4: WARNING: Title underline too short.

 Kernel driver sy7636a-hwmon
 =========================

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 Documentation/hwmon/sy7636a-hwmon.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/hwmon/sy7636a-hwmon.rst b/Documentation/hwmon/sy7636a-hwmon.rst
index 5612079397d52..c85db7b329415 100644
--- a/Documentation/hwmon/sy7636a-hwmon.rst
+++ b/Documentation/hwmon/sy7636a-hwmon.rst
@@ -1,7 +1,7 @@
 .. SPDX-License-Identifier: GPL-2.0-or-later
 
 Kernel driver sy7636a-hwmon
-=========================
+===========================
 
 Supported chips:
 
-- 

Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build warning after merge of the hwmon-staging tree

[Guenter Roeck]

Hi Lee,

On 2/10/22 00:50, Lee Jones wrote:
> On Thu, 10 Feb 2022, Stephen Rothwell wrote:
> 
>> Hi all,
>>
>> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
>> produced this warning:
>>
>> Documentation/hwmon/sy7636a-hwmon.rst:4: WARNING: Title underline too short.
>>
>> Kernel driver sy7636a-hwmon
>> =========================
>>
>> Introduced by commit
>>
>>    de34a4053250 ("hwmon: sy7636a: Add temperature driver for sy7636a")
> 
> Oh wow, that's new (to me), and a little petty, no?
> 
> Would you like me to apply this patch to my branch Guenter?
> 

It would be great if you can do that since you already wrote it.

> I can either send out a new PR, or let it wallow.
> 
Wallow is fine with me; that can go in through your branch.

Actually, I wonder if I should just drop your immutable branch from
my tree and let it go in through your tree. The hwmon patch has my Acked-by:
already, and there are no further dependencies, so it isn't really necessary
for both of us to carry it. What do you think ?

Thanks,
Guenter

> -------- 8< --------
> 
> From: Lee Jones <lee.jones@linaro.org>
> 
>   Documentation/hwmon/sy7636a-hwmon.rst:4: WARNING: Title underline too short.
> 
>   Kernel driver sy7636a-hwmon
>   =========================
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>   Documentation/hwmon/sy7636a-hwmon.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/hwmon/sy7636a-hwmon.rst b/Documentation/hwmon/sy7636a-hwmon.rst
> index 5612079397d52..c85db7b329415 100644
> --- a/Documentation/hwmon/sy7636a-hwmon.rst
> +++ b/Documentation/hwmon/sy7636a-hwmon.rst
> @@ -1,7 +1,7 @@
>   .. SPDX-License-Identifier: GPL-2.0-or-later
>   
>   Kernel driver sy7636a-hwmon
> -=========================
> +===========================
>   
>   Supported chips:
>   

Re: linux-next: build warning after merge of the hwmon-staging tree

[Lee Jones]

On Thu, 10 Feb 2022, Guenter Roeck wrote:

> Hi Lee,
> 
> On 2/10/22 00:50, Lee Jones wrote:
> > On Thu, 10 Feb 2022, Stephen Rothwell wrote:
> > 
> > > Hi all,
> > > 
> > > After merging the hwmon-staging tree, today's linux-next build (htmldocs)
> > > produced this warning:
> > > 
> > > Documentation/hwmon/sy7636a-hwmon.rst:4: WARNING: Title underline too short.
> > > 
> > > Kernel driver sy7636a-hwmon
> > > =========================
> > > 
> > > Introduced by commit
> > > 
> > >    de34a4053250 ("hwmon: sy7636a: Add temperature driver for sy7636a")
> > 
> > Oh wow, that's new (to me), and a little petty, no?
> > 
> > Would you like me to apply this patch to my branch Guenter?
> > 
> 
> It would be great if you can do that since you already wrote it.
> 
> > I can either send out a new PR, or let it wallow.
> > 
> Wallow is fine with me; that can go in through your branch.
> 
> Actually, I wonder if I should just drop your immutable branch from
> my tree and let it go in through your tree. The hwmon patch has my Acked-by:
> already, and there are no further dependencies, so it isn't really necessary
> for both of us to carry it. What do you think ?

That's your call to make. :)

The patch is going in, either way.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build warning after merge of the hwmon-staging tree

[Guenter Roeck]

On 2/10/22 10:07, Lee Jones wrote:
> On Thu, 10 Feb 2022, Guenter Roeck wrote:
> 
>> Hi Lee,
>>
>> On 2/10/22 00:50, Lee Jones wrote:
>>> On Thu, 10 Feb 2022, Stephen Rothwell wrote:
>>>
>>>> Hi all,
>>>>
>>>> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
>>>> produced this warning:
>>>>
>>>> Documentation/hwmon/sy7636a-hwmon.rst:4: WARNING: Title underline too short.
>>>>
>>>> Kernel driver sy7636a-hwmon
>>>> =========================
>>>>
>>>> Introduced by commit
>>>>
>>>>     de34a4053250 ("hwmon: sy7636a: Add temperature driver for sy7636a")
>>>
>>> Oh wow, that's new (to me), and a little petty, no?
>>>
>>> Would you like me to apply this patch to my branch Guenter?
>>>
>>
>> It would be great if you can do that since you already wrote it.
>>
>>> I can either send out a new PR, or let it wallow.
>>>
>> Wallow is fine with me; that can go in through your branch.
>>
>> Actually, I wonder if I should just drop your immutable branch from
>> my tree and let it go in through your tree. The hwmon patch has my Acked-by:
>> already, and there are no further dependencies, so it isn't really necessary
>> for both of us to carry it. What do you think ?
> 
> That's your call to make. :)
> 
> The patch is going in, either way.
> 

Sounds good. I'll drop it.

Thanks,
Guenter

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/hwmon/index.rst:18: WARNING: toctree contains reference to nonexisting document 'hwmon/asus_wmi_ec_sensors'
Documentation/hwmon/asus_ec_sensors.rst: WARNING: document isn't included in any toctree

Introduced by commit

  d4b4bb104d12 ("hwmon: (asus-ec-sensors) update documentation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hwmon-staging tree

[Guenter Roeck]

On 2/3/22 21:16, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/hwmon/index.rst:18: WARNING: toctree contains reference to nonexisting document 'hwmon/asus_wmi_ec_sensors'
> Documentation/hwmon/asus_ec_sensors.rst: WARNING: document isn't included in any toctree
> 
> Introduced by commit
> 
>    d4b4bb104d12 ("hwmon: (asus-ec-sensors) update documentation")
> 
Fixed up, thanks!

Guenter

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build
(htmldocs) produced this warning:

Documentation/hwmon/mp5023.rst: WARNING: document isn't included in any toctree

Introduced by commit

  883cb06f2553 ("hwmon: (pmbus) Add support for MPS Multi-phase mp5023")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: module mp5023 uses symbol pmbus_do_probe from namespace PMBUS, but does not import it.

Introduced by commit

  883cb06f2553 ("hwmon: (pmbus) Add support for MPS Multi-phase mp5023")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: module dps920ab uses symbol pmbus_get_debugfs_dir from namespace PMBUS, but does not import it.
WARNING: modpost: module dps920ab uses symbol pmbus_do_probe from namespace PMBUS, but does not import it.
WARNING: modpost: module dps920ab uses symbol pmbus_read_word_data from namespace PMBUS, but does not import it.
WARNING: modpost: module dps920ab uses symbol pmbus_write_word_data from namespace PMBUS, but does not import it.

Introduced by commit

  47e986c5a316 ("hwmon: (pmbus) Add driver for Delta DPS-920AB PSU")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hwmon-staging tree

[Guenter Roeck]

On Thu, Jun 10, 2021 at 10:21:17AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> WARNING: modpost: module dps920ab uses symbol pmbus_get_debugfs_dir from namespace PMBUS, but does not import it.
> WARNING: modpost: module dps920ab uses symbol pmbus_do_probe from namespace PMBUS, but does not import it.
> WARNING: modpost: module dps920ab uses symbol pmbus_read_word_data from namespace PMBUS, but does not import it.
> WARNING: modpost: module dps920ab uses symbol pmbus_write_word_data from namespace PMBUS, but does not import it.
> 
> Introduced by commit
> 
>   47e986c5a316 ("hwmon: (pmbus) Add driver for Delta DPS-920AB PSU")

Fixed.

Thanks,
Guenter

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/hwmon/bpa-rs600.rst: WARNING: document isn't included in any toctree

Introduced by commit

  9a8210575cde ("hwmon: (pmbus) Add driver for BluTek BPA-RS600")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hwmon-staging tree

[Guenter Roeck]

[-- Attachment #1.1: Type: text/plain, Size: 397 bytes --]

On 3/30/21 12:27 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/hwmon/bpa-rs600.rst: WARNING: document isn't included in any toctree
> 
> Introduced by commit
> 
>   9a8210575cde ("hwmon: (pmbus) Add driver for BluTek BPA-RS600")
> 
I fixed it up.

Thanks,
Guenter


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: linux-next: build warning after merge of the hwmon-staging tree

[Chris Packham]

My bad. I'll send a patch shortly

On 30/03/21 8:27 pm, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/hwmon/bpa-rs600.rst: WARNING: document isn't included in any toctree
>
> Introduced by commit
>
>    9a8210575cde ("hwmon: (pmbus) Add driver for BluTek BPA-RS600")
>

Re: linux-next: build warning after merge of the hwmon-staging tree

[Guenter Roeck]

On 3/30/21 1:25 PM, Chris Packham wrote:
> My bad. I'll send a patch shortly
> 

No need. I patched it up already.

Thanks,
Guenter

> On 30/03/21 8:27 pm, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
>> produced this warning:
>>
>> Documentation/hwmon/bpa-rs600.rst: WARNING: document isn't included in any toctree
>>
>> Introduced by commit
>>
>>    9a8210575cde ("hwmon: (pmbus) Add driver for BluTek BPA-RS600")
>>
> 

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/hwmon/ir36021.rst:34: WARNING: Malformed table.
No bottom table border found.

======================= ===========================
curr1_label             "iin"
curr1_input             Measured input current
curr1_alarm             Input fault alarm

curr2_label             "iout1"
curr2_input             Measured output current
curr2_alarm             Output over-current alarm

in1_label               "vin"
in1_input               Measured input voltage
in1_alarm               Input under-voltage alarm

in2_label               "vout1"
in2_input               Measured output voltage
in2_alarm               Output over-voltage alarm

power1_label            "pin"
power1_input            Measured input power
power1_alarm            Input under-voltage alarm

power2_label            "pout1"
power2_input            Measured output power

temp1_input             Measured temperature
temp1_alarm             Temperature alarm

temp2_input             Measured other loop temperature
temp2_alarm             Temperature alarm

Caused by commit

  0be9fee30ff9 ("hwmon: (pmbus) Add driver for Infineon IR36021")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hwmon-staging tree

[Chris Packham]

On 12/03/21 4:50 pm, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/hwmon/ir36021.rst:34: WARNING: Malformed table.
> No bottom table border found.
>
> ======================= ===========================
> curr1_label             "iin"
> curr1_input             Measured input current
> curr1_alarm             Input fault alarm
>
> curr2_label             "iout1"
> curr2_input             Measured output current
> curr2_alarm             Output over-current alarm
>
> in1_label               "vin"
> in1_input               Measured input voltage
> in1_alarm               Input under-voltage alarm
>
> in2_label               "vout1"
> in2_input               Measured output voltage
> in2_alarm               Output over-voltage alarm
>
> power1_label            "pin"
> power1_input            Measured input power
> power1_alarm            Input under-voltage alarm
>
> power2_label            "pout1"
> power2_input            Measured output power
>
> temp1_input             Measured temperature
> temp1_alarm             Temperature alarm
>
> temp2_input             Measured other loop temperature
> temp2_alarm             Temperature alarm
>
> Caused by commit
>
>    0be9fee30ff9 ("hwmon: (pmbus) Add driver for Infineon IR36021")
>
Easy enough to fix. Who should I send the patch to?

Re: linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

Hi Chris,

On Fri, 12 Mar 2021 04:00:45 +0000 Chris Packham <Chris.Packham@alliedtelesis.co.nz> wrote:
>
> Easy enough to fix. Who should I send the patch to?

Guenter, since the original patch is in his tree.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3245 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/hwmon/max16601.rst:94: WARNING: Malformed table.
Text in column margin in table line 39.

======================= =======================================================
in1_label               "vin1"
in1_input               VCORE input voltage.
in1_alarm               Input voltage alarm.

in2_label               "vout1"
in2_input               VCORE output voltage.
in2_alarm               Output voltage alarm.

curr1_label             "iin1"
curr1_input             VCORE input current, derived from duty cycle and output
                        current.
curr1_max               Maximum input current.
curr1_max_alarm         Current high alarm.

curr[P+2]_label         "iin1.P"
curr[P+2]_input         VCORE phase P input current.

curr[N+2]_label         "iin2"
curr[N+2]_input         VCORE input current, derived from sensor element.
                        'N' is the number of enabled/populated phases.

curr[N+3]_label         "iin3"
curr[N+3]_input         VSA input current.

curr[N+4]_label         "iout1"
curr[N+4]_input         VCORE output current.
curr[N+4]_crit          Critical output current.
curr[N+4]_crit_alarm    Output current critical alarm.
curr[N+4]_max           Maximum output current.
curr[N+4]_max_alarm     Output current high alarm.

curr[N+P+5]_label       "iout1.P"
curr[N+P+5]_input       VCORE phase P output current.

curr[2*N+5]_label       "iout3"
curr[2*N+5]_input       VSA output current.
curr[2*N+5]_highest     Historical maximum VSA output current.
curr[2*N+5]_reset_history
                        Write any value to reset curr21_highest.
curr[2*N+5]_crit        Critical output current.
curr[2*N+5]_crit_alarm  Output current critical alarm.
curr[2*N+5]_max         Maximum output current.
curr[2*N+5]_max_alarm   Output current high alarm.

power1_label            "pin1"
power1_input            Input power, derived from duty cycle and output current.
power1_alarm            Input power alarm.

power2_label            "pin2"
power2_input            Input power, derived from input current sensor.

power3_label            "pout"
power3_input            Output power.

temp1_input             VCORE temperature.
temp1_crit              Critical high temperature.
temp1_crit_alarm        Chip temperature critical high alarm.
temp1_max               Maximum temperature.
temp1_max_alarm         Chip temperature high alarm.

temp2_input             TSENSE_0 temperature
temp3_input             TSENSE_1 temperature
temp4_input             TSENSE_2 temperature
temp5_input             TSENSE_3 temperature

temp6_input             VSA temperature.
temp6_crit              Critical high temperature.
temp6_crit_alarm        Chip temperature critical high alarm.
temp6_max               Maximum temperature.
temp6_max_alarm         Chip temperature high alarm.
======================= =======================================================

Introduced by commit

  90b0f71d62df ("hwmon: (pmbus/max16601) Determine and use number of populated phases")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/hwmon/q54sj108a2.rst:4: WARNING: Title underline too short.

Kernel driver q54sj108a2
=====================

Introduced by commit

  b722d7b9e4da ("hwmon: (pmbus) Driver for Delta power supplies Q54SJ108A2")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/hwmon/axi-fan-control.c: In function 'axi_fan_control_probe':
drivers/hwmon/axi-fan-control.c:419:26: warning: 'res' may be used uninitialized in this function [-Wmaybe-uninitialized]
  419 |   (unsigned long long)res->start, ctl->base);
      |                          ^~

Introduced by commit

  690dd9ce04f6 ("hwmon: Support ADI Fan Control IP")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hwmon-staging tree

[Guenter Roeck]

On 2/10/20 2:23 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/hwmon/axi-fan-control.c: In function 'axi_fan_control_probe':
> drivers/hwmon/axi-fan-control.c:419:26: warning: 'res' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    419 |   (unsigned long long)res->start, ctl->base);
>        |                          ^~
> 
> Introduced by commit
> 
>    690dd9ce04f6 ("hwmon: Support ADI Fan Control IP")
> 

Fixed up (res was actually leftover from an earlier patch version
and unused).

Guenter

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/hwmon/lm90.c: In function 'lm90_write_convrate':
drivers/hwmon/lm90.c:597:42: warning: 'config_stop' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (data->flags & LM90_PAUSE_FOR_CONFIG && config_orig != config_stop)
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hwmon/lm90.c:598:3: warning: 'config_orig' may be used uninitialized in this function [-Wmaybe-uninitialized]
   i2c_smbus_write_byte_data(client, LM90_REG_W_CONFIG1,
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        config_orig);
        ~~~~~~~~~~~~

Introduced by commit

  479a503fa073 ("hwmon: (lm90) Fix max6658 sporadic wrong temperature reading")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the hwmon-staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

Hi all,

After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/hwmon/pmbus/adm1275.c: In function 'adm1275_write_pmon_config':
drivers/hwmon/pmbus/adm1275.c:179:23: warning: unused variable 'data' [-Wunused-variable]
  struct adm1275_data *data = to_adm1275_data(info);
                       ^~~~

Introduced by commit

  438318513375 ("hwmon: (pmbus/adm1275) support PMBUS_VIRT_*_SAMPLES")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]