linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: manual merge of the ftrace tree with Linus' tree
Date: Tue, 8 Dec 2020 16:02:22 +1100	[thread overview]
Message-ID: <20201208160222.04ad114f@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1956 bytes --]

Hi all,

Today's linux-next merge of the ftrace tree got a conflict in:

  kernel/trace/ring_buffer.c

between commit:

  68e10d5ff512 ("ring-buffer: Always check to put back before stamp when crossing pages")

from Linus' tree and commit:

  5b7be9c709e1 ("ring-buffer: Add test to validate the time stamp deltas")

from the ftrace tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc kernel/trace/ring_buffer.c
index a6268e09160a,7cd888ee9ac7..000000000000
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@@ -3234,12 -3391,16 +3391,14 @@@ __rb_reserve_next(struct ring_buffer_pe
  
  	/* See if we shot pass the end of this buffer page */
  	if (unlikely(write > BUF_PAGE_SIZE)) {
 -		if (tail != w) {
 -			/* before and after may now different, fix it up*/
 -			b_ok = rb_time_read(&cpu_buffer->before_stamp, &info->before);
 -			a_ok = rb_time_read(&cpu_buffer->write_stamp, &info->after);
 -			if (a_ok && b_ok && info->before != info->after)
 -				(void)rb_time_cmpxchg(&cpu_buffer->before_stamp,
 -						      info->before, info->after);
 -		}
 +		/* before and after may now different, fix it up*/
 +		b_ok = rb_time_read(&cpu_buffer->before_stamp, &info->before);
 +		a_ok = rb_time_read(&cpu_buffer->write_stamp, &info->after);
 +		if (a_ok && b_ok && info->before != info->after)
 +			(void)rb_time_cmpxchg(&cpu_buffer->before_stamp,
 +					      info->before, info->after);
+ 		if (a_ok && b_ok)
+ 			check_buffer(cpu_buffer, info, CHECK_FULL_PAGE);
  		return rb_move_tail(cpu_buffer, tail, info);
  	}
  

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2020-12-08  5:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08  5:02 Stephen Rothwell [this message]
2020-12-14 20:37 ` linux-next: manual merge of the ftrace tree with Linus' tree Stephen Rothwell
2020-12-14 21:33   ` Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2023-08-28  1:59 Stephen Rothwell
2023-04-11  2:46 Stephen Rothwell
2023-04-11  3:01 ` Steven Rostedt
2021-10-28  5:31 Stephen Rothwell
2021-10-28 13:14 ` Steven Rostedt
2021-09-15  0:44 Stephen Rothwell
2021-09-15  0:47 ` Steven Rostedt
2021-02-15  4:03 Stephen Rothwell
2019-05-16  1:05 Stephen Rothwell
2019-05-16  1:53 ` Steven Rostedt
2019-05-16  3:32   ` Stephen Rothwell
2019-05-16  1:00 Stephen Rothwell
2018-08-15  4:04 Stephen Rothwell
2015-11-05  2:51 Stephen Rothwell
2015-11-05  3:20 ` Steven Rostedt
2013-07-10  3:51 Stephen Rothwell
2013-04-22  5:55 Stephen Rothwell
2013-04-09  6:30 Stephen Rothwell
2013-03-18  2:00 Stephen Rothwell
2013-03-18 13:26 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201208160222.04ad114f@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).