linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the kvm tree with the arm64-fixes tree
@ 2020-12-18  2:47 Stephen Rothwell
  2020-12-18 10:31 ` Catalin Marinas
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2020-12-18  2:47 UTC (permalink / raw)
  To: Paolo Bonzini, KVM, Catalin Marinas, Will Deacon
  Cc: Linux Kernel Mailing List, Linux Next Mailing List, Marc Zyngier

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

Hi all,

Today's linux-next merge of the kvm tree got a conflict in:

  arch/arm64/include/asm/kvm_asm.h

between commit:

  9fd339a45be5 ("arm64: Work around broken GCC 4.9 handling of "S" constraint")

from the arm64-fixes tree and commit:

  b881cdce77b4 ("KVM: arm64: Allocate hyp vectors statically")

from the kvm tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc arch/arm64/include/asm/kvm_asm.h
index 8e5fa28b78c2,7ccf770c53d9..000000000000
--- a/arch/arm64/include/asm/kvm_asm.h
+++ b/arch/arm64/include/asm/kvm_asm.h
@@@ -198,14 -199,6 +199,12 @@@ extern void __vgic_v3_init_lrs(void)
  
  extern u32 __kvm_get_mdcr_el2(void);
  
- extern char __smccc_workaround_1_smc[__SMCCC_WORKAROUND_1_SMC_SZ];
- 
 +#if defined(GCC_VERSION) && GCC_VERSION < 50000
 +#define SYM_CONSTRAINT	"i"
 +#else
 +#define SYM_CONSTRAINT	"S"
 +#endif
 +
  /*
   * Obtain the PC-relative address of a kernel symbol
   * s: symbol

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-next: manual merge of the kvm tree with the arm64-fixes tree
  2020-12-18  2:47 linux-next: manual merge of the kvm tree with the arm64-fixes tree Stephen Rothwell
@ 2020-12-18 10:31 ` Catalin Marinas
  0 siblings, 0 replies; 2+ messages in thread
From: Catalin Marinas @ 2020-12-18 10:31 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Paolo Bonzini, KVM, Will Deacon, Linux Kernel Mailing List,
	Linux Next Mailing List, Marc Zyngier

On Fri, Dec 18, 2020 at 01:47:39PM +1100, Stephen Rothwell wrote:
> Today's linux-next merge of the kvm tree got a conflict in:
> 
>   arch/arm64/include/asm/kvm_asm.h
> 
> between commit:
> 
>   9fd339a45be5 ("arm64: Work around broken GCC 4.9 handling of "S" constraint")
> 
> from the arm64-fixes tree and commit:
> 
>   b881cdce77b4 ("KVM: arm64: Allocate hyp vectors statically")
> 
> from the kvm tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> -- 
> Cheers,
> Stephen Rothwell
> 
> diff --cc arch/arm64/include/asm/kvm_asm.h
> index 8e5fa28b78c2,7ccf770c53d9..000000000000
> --- a/arch/arm64/include/asm/kvm_asm.h
> +++ b/arch/arm64/include/asm/kvm_asm.h
> @@@ -198,14 -199,6 +199,12 @@@ extern void __vgic_v3_init_lrs(void)
>   
>   extern u32 __kvm_get_mdcr_el2(void);
>   
> - extern char __smccc_workaround_1_smc[__SMCCC_WORKAROUND_1_SMC_SZ];
> - 
>  +#if defined(GCC_VERSION) && GCC_VERSION < 50000
>  +#define SYM_CONSTRAINT	"i"
>  +#else
>  +#define SYM_CONSTRAINT	"S"
>  +#endif
>  +
>   /*
>    * Obtain the PC-relative address of a kernel symbol
>    * s: symbol

Thanks Stephen, it looks fine. I'll send a pull request later today with
this commit but it's simple enough for Linus to fix it.

-- 
Catalin

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-18 10:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-18  2:47 linux-next: manual merge of the kvm tree with the arm64-fixes tree Stephen Rothwell
2020-12-18 10:31 ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).