From: Pratyush Yadav <p.yadav@ti.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Mark Brown <broonie@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Subject: Re: linux-next: Fixes tag needs some work in the spi tree
Date: Tue, 12 Jan 2021 02:28:12 +0530 [thread overview]
Message-ID: <20210111205810.tipt54yk2dljim3l@ti.com> (raw)
In-Reply-To: <20210112073606.7cb02e42@canb.auug.org.au>
+Cc checkpatch.pl maintainers.
On 12/01/21 07:36AM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 2ef0170e9039 ("spi: cadence-quadspi: Fix build warning on 32-bit platforms")
>
> Fixes tag
>
> Fixes: f453f293979f ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Did yu mean
>
> Fixes: f453f293979f ("spi: cadence-quadspi: Add DTR support")
>
> or
>
> Fixes: 0920a32cf6f2 ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")
I meant this one. My mistake. Copied the wrong hash. Any way to fix this
now?
This check should probably be added in checkpatch.pl so mistakes like
this can be avoided in the future.
--
Regards,
Pratyush Yadav
Texas Instruments India
next prev parent reply other threads:[~2021-01-11 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 20:36 linux-next: Fixes tag needs some work in the spi tree Stephen Rothwell
2021-01-11 20:58 ` Pratyush Yadav [this message]
2021-01-11 23:00 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2024-02-19 21:44 Stephen Rothwell
2024-02-19 22:48 ` Randy Dunlap
2024-02-19 22:54 ` Mark Brown
2022-03-17 21:18 Stephen Rothwell
2022-03-18 7:10 ` Biju Das
2022-03-18 15:44 ` Mark Brown
2022-03-18 15:48 ` Biju Das
2021-05-11 22:24 Stephen Rothwell
2021-04-11 22:37 Stephen Rothwell
2019-04-01 18:12 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111205810.tipt54yk2dljim3l@ti.com \
--to=p.yadav@ti.com \
--cc=apw@canonical.com \
--cc=broonie@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).