linux-next: Fixes tag needs some work in the spi tree

linux-next: Fixes tag needs some work in the spi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi all,

In commit

  2ef0170e9039 ("spi: cadence-quadspi: Fix build warning on 32-bit platforms")

Fixes tag

  Fixes: f453f293979f ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did yu mean

Fixes: f453f293979f ("spi: cadence-quadspi: Add DTR support")

or

Fixes: 0920a32cf6f2 ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the spi tree

[Pratyush Yadav]

+Cc checkpatch.pl maintainers.

On 12/01/21 07:36AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   2ef0170e9039 ("spi: cadence-quadspi: Fix build warning on 32-bit platforms")
> 
> Fixes tag
> 
>   Fixes: f453f293979f ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Did yu mean
> 
> Fixes: f453f293979f ("spi: cadence-quadspi: Add DTR support")
> 
> or
> 
> Fixes: 0920a32cf6f2 ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")

I meant this one. My mistake. Copied the wrong hash. Any way to fix this 
now?

This check should probably be added in checkpatch.pl so mistakes like 
this can be avoided in the future.

-- 
Regards,
Pratyush Yadav
Texas Instruments India

Re: linux-next: Fixes tag needs some work in the spi tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

On Tue, Jan 12, 2021 at 02:28:12AM +0530, Pratyush Yadav wrote:

> I meant this one. My mistake. Copied the wrong hash. Any way to fix this 
> now?

Not without rebasing which I generally avoid.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the spi tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

On Mon, Feb 19, 2024 at 02:48:51PM -0800, Randy Dunlap wrote:
> On 2/19/24 13:44, Stephen Rothwell wrote:

> > Fixes tag

> >   Fixes: hash ("spi: Update the "master/slave" terminology in documentation")

> > has these problem(s):

> >   - No SHA1 recognised

> > Maybe you meant

> > Fixes: 99769a52464d ("spi: Update the "master/slave" terminology in documentation")

> oh dear. Yes, I did.

> Mark, what do I need to do here?

Nothing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the spi tree

[Randy Dunlap]

On 2/19/24 13:44, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   afd2a4ae296d ("spi: spi-summary.rst: fix underline length")
> 
> Fixes tag
> 
>   Fixes: hash ("spi: Update the "master/slave" terminology in documentation")
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> Maybe you meant
> 
> Fixes: 99769a52464d ("spi: Update the "master/slave" terminology in documentation")
> 

oh dear. Yes, I did.

Mark, what do I need to do here?

Thanks and sorry for the trouble.

-- 
#Randy

linux-next: Fixes tag needs some work in the spi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi all,

In commit

  afd2a4ae296d ("spi: spi-summary.rst: fix underline length")

Fixes tag

  Fixes: hash ("spi: Update the "master/slave" terminology in documentation")

has these problem(s):

  - No SHA1 recognised

Maybe you meant

Fixes: 99769a52464d ("spi: Update the "master/slave" terminology in documentation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the spi tree

[Biju Das]

Hi Mark,

> Subject: Re: linux-next: Fixes tag needs some work in the spi tree
> 
> On Fri, Mar 18, 2022 at 07:10:59AM +0000, Biju Das wrote:
> > Hi Stephen and Mark,
> >
> > My bad, I have added Fixes tag at last minute and missed running Check
> > patch with that change.
> >
> > Is it possible to manually fix this?
> 
> No, that'd involve rebasing.  It's fine, just remember this in future.

OK, Will take care this in future.

By the way, I have ran check patch on this patch on Linux-next and unfortunately
It doesn't complain about leading 'commit' in fixes tag.

Thanks,
Biju

Re: linux-next: Fixes tag needs some work in the spi tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

On Fri, Mar 18, 2022 at 07:10:59AM +0000, Biju Das wrote:
> Hi Stephen and Mark,
> 
> My bad, I have added Fixes tag at last minute and missed running
> Check patch with that change.
> 
> Is it possible to manually fix this?

No, that'd involve rebasing.  It's fine, just remember this in future.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the spi tree

[Biju Das]

Hi Stephen and Mark,

My bad, I have added Fixes tag at last minute and missed running
Check patch with that change.

Is it possible to manually fix this?

Regards,
Biju


> Subject: linux-next: Fixes tag needs some work in the spi tree
> 
> Hi all,
> 
> In commit
> 
>   ebc4cb43ea5a ("spi: Fix erroneous sgs value with min_t()")
> 
> Fixes tag
> 
>   Fixes: commit 1a4e53d2fc4f68aa ("spi: Fix invalid sgs value")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected
> 
> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the spi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

Hi all,

In commit

  ebc4cb43ea5a ("spi: Fix erroneous sgs value with min_t()")

Fixes tag

  Fixes: commit 1a4e53d2fc4f68aa ("spi: Fix invalid sgs value")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the spi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi all,

In commit

  86b1d8ecb5f1 ("spi: tegra114: Fix an error message")

Fixes tag

  Fixes: f333a331ad ("spi/tegra114: add spi driver")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the spi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Hi all,

In commit

  e980048263ba ("spi: orion: set devdata properly as it is being used later")

Fixes tag

  Fixes: 0e6521f13c2 ("spi: orion: Use device_get_match_data() helper")

has these problem(s):

  - SHA1 should be at least 12 digits long

Probably not worth rebasing to fix, but this can be avoided in future
commits by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the spi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

Hi Mark,

In commit

  fc9ba6e3e28a ("spi: tegra114: use packed mode for 32 bits per word")

Fixes tag

  Fixes: Use packed mode for 32 bits per word transfers to increase

has these problem(s):

  - No SHA1 recognised

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]