linux-next: Fixes tag needs some work in the v4l-dvb-fixes tree

linux-next: Fixes tag needs some work in the v4l-dvb-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

Hi all,

In commit

  95e9295daa84 ("media: Revert "media: videobuf2: Fix length check for single plane dmabuf queueing"")

Fixes tag

  Fixes: 961d3b27 ("media: videobuf2: Fix length check for single plane dmabuf queueing")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the v4l-dvb-fixes tree

[Sakari Ailus]

On Mon, Jul 17, 2023 at 06:58:28PM +0300, Kalle Valo wrote:
> Sakari Ailus <sakari.ailus@linux.intel.com> writes:
> 
> > On Fri, Jul 14, 2023 at 08:38:25AM +1000, Stephen Rothwell wrote:
> >> Hi all,
> >> 
> >> In commit
> >> 
> >>   b0b43354c345 ("media: tc358746: Address compiler warnings")
> >> 
> >> Fixes tag
> >> 
> >>   Fixes: 80a21da3605 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")
> >> 
> >> has these problem(s):
> >> 
> >>   - SHA1 should be at least 12 digits long
> >>     This can be fixed for the future by setting core.abbrev to 12 (or
> >>     more) or (for git v2.11 or later) just making sure it is not set
> >>     (or set to "auto").
> >> 
> >> Also, please keep all the commit message tags together at the end of
> >> the commit message.
> >
> > Apologies for this, I guess I've removed one character too many from the
> > hash.
> >
> > I'll switch to a script (or alias) to do this. It'd be, though, helpful if
> > git could do this on its own.
> 
> Are you asking for git to create the Fixes tag? The documentation has
> has a tip using --pretty=fixes which is quite handy:
> 
> https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

Thanks! This is much nicer than a bash alias I created.

-- 
Sakari Ailus

Re: linux-next: Fixes tag needs some work in the v4l-dvb-fixes tree

[Kalle Valo]

Sakari Ailus <sakari.ailus@linux.intel.com> writes:

> On Fri, Jul 14, 2023 at 08:38:25AM +1000, Stephen Rothwell wrote:
>> Hi all,
>> 
>> In commit
>> 
>>   b0b43354c345 ("media: tc358746: Address compiler warnings")
>> 
>> Fixes tag
>> 
>>   Fixes: 80a21da3605 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")
>> 
>> has these problem(s):
>> 
>>   - SHA1 should be at least 12 digits long
>>     This can be fixed for the future by setting core.abbrev to 12 (or
>>     more) or (for git v2.11 or later) just making sure it is not set
>>     (or set to "auto").
>> 
>> Also, please keep all the commit message tags together at the end of
>> the commit message.
>
> Apologies for this, I guess I've removed one character too many from the
> hash.
>
> I'll switch to a script (or alias) to do this. It'd be, though, helpful if
> git could do this on its own.

Are you asking for git to create the Fixes tag? The documentation has
has a tip using --pretty=fixes which is quite handy:

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: linux-next: Fixes tag needs some work in the v4l-dvb-fixes tree

[Sakari Ailus]

hi Stephen,

On Fri, Jul 14, 2023 at 08:38:25AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   b0b43354c345 ("media: tc358746: Address compiler warnings")
> 
> Fixes tag
> 
>   Fixes: 80a21da3605 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").
> 
> Also, please keep all the commit message tags together at the end of
> the commit message.

Apologies for this, I guess I've removed one character too many from the
hash.

I'll switch to a script (or alias) to do this. It'd be, though, helpful if
git could do this on its own.

-- 
Kind regards,

Sakari Ailus

linux-next: Fixes tag needs some work in the v4l-dvb-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

Hi all,

In commit

  b0b43354c345 ("media: tc358746: Address compiler warnings")

Fixes tag

  Fixes: 80a21da3605 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

Also, please keep all the commit message tags together at the end of
the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]