linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the modules tree
@ 2021-01-18 19:35 Stephen Rothwell
  0 siblings, 0 replies; 12+ messages in thread
From: Stephen Rothwell @ 2021-01-18 19:35 UTC (permalink / raw)
  To: Jessica Yu
  Cc: Linux Kernel Mailing List, Linux Next Mailing List, Frank van der Linden

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Hi all,

In commit

  46b93cf85455 ("module: harden ELF info handling")

Fixes tag

  Fixes: 5fdc7db644 ("module: setup load info before module_sig_check()")

has these problem(s):

  - SHA1 should be at least 12 digits long

This can be fixed for future commits by setting core.abbrev to 12
(or more) or (for git v2.11 or later) just making sure it is not set
(or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: linux-next: Fixes tag needs some work in the modules tree
  2023-07-23 22:33 Stephen Rothwell
@ 2023-07-24 19:11 ` Luis Chamberlain
  0 siblings, 0 replies; 12+ messages in thread
From: Luis Chamberlain @ 2023-07-24 19:11 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Palmer Dabbelt, Linux Kernel Mailing List, Linux Next Mailing List

On Mon, Jul 24, 2023 at 08:33:48AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   3d917b5d3ba5 ("modpost, kallsyms: Treat add '$'-prefixed symbols as mapping symbols")
> 
> Fixes tag
> 
>   Fixes: c05780ef3c1 ("module: Ignore RISC-V mapping symbols too")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long

Fixed, thanks.

  Luis

^ permalink raw reply	[flat|nested] 12+ messages in thread
* linux-next: Fixes tag needs some work in the modules tree
@ 2023-07-23 22:33 Stephen Rothwell
  2023-07-24 19:11 ` Luis Chamberlain
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2023-07-23 22:33 UTC (permalink / raw)
  To: Luis Chamberlain
  Cc: Palmer Dabbelt, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

Hi all,

In commit

  3d917b5d3ba5 ("modpost, kallsyms: Treat add '$'-prefixed symbols as mapping symbols")

Fixes tag

  Fixes: c05780ef3c1 ("module: Ignore RISC-V mapping symbols too")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: linux-next: Fixes tag needs some work in the modules tree
  2022-04-04 22:15 Stephen Rothwell
@ 2022-04-05 15:45 ` Luis Chamberlain
  0 siblings, 0 replies; 12+ messages in thread
From: Luis Chamberlain @ 2022-04-05 15:45 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Aaron Tomlin, Linux Kernel Mailing List, Linux Next Mailing List

On Tue, Apr 05, 2022 at 08:15:29AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   450f0134ccf0 ("module: Make internal.h and decompress.c more compliant")
> 
> Fixes tag
> 
>   Fixes: f314dfea16a ("modsign: log module name in the event of an error")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").

Fixed, thanks!

  Luis

^ permalink raw reply	[flat|nested] 12+ messages in thread
* linux-next: Fixes tag needs some work in the modules tree
@ 2022-04-04 22:15 Stephen Rothwell
  2022-04-05 15:45 ` Luis Chamberlain
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2022-04-04 22:15 UTC (permalink / raw)
  To: Luis Chamberlain
  Cc: Aaron Tomlin, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

Hi all,

In commit

  450f0134ccf0 ("module: Make internal.h and decompress.c more compliant")

Fixes tag

  Fixes: f314dfea16a ("modsign: log module name in the event of an error")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: linux-next: Fixes tag needs some work in the modules tree
  2022-03-01  0:33 Stephen Rothwell
@ 2022-03-01  0:43 ` Luis Chamberlain
  0 siblings, 0 replies; 12+ messages in thread
From: Luis Chamberlain @ 2022-03-01  0:43 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Aaron Tomlin, Linux Kernel Mailing List, Linux Next Mailing List

On Tue, Mar 01, 2022 at 11:33:33AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   f131a1296ecf ("module: Make internal.h and decompress.c more compliant")
> 
> Fixes tag
> 
>   Fixes: f314dfea16a ("modsign: log module name in the event of an error")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").

This is not that critical but I've decided to reset my tree again back
to Linus' tree as I jumped the gun in mergig this to modulex-next as it
has not been run time tested yet. So I've dumped this on modules-testing, and
once we get more testing results I'll push this to modules-next.

I can fix the commit log to have 12 digits on the SHA1 manually,
provided no other compile or run time issues are found.

  Luis

^ permalink raw reply	[flat|nested] 12+ messages in thread
* linux-next: Fixes tag needs some work in the modules tree
@ 2022-03-01  0:33 Stephen Rothwell
  2022-03-01  0:43 ` Luis Chamberlain
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2022-03-01  0:33 UTC (permalink / raw)
  To: Luis Chamberlain
  Cc: Aaron Tomlin, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

Hi all,

In commit

  f131a1296ecf ("module: Make internal.h and decompress.c more compliant")

Fixes tag

  Fixes: f314dfea16a ("modsign: log module name in the event of an error")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: linux-next: Fixes tag needs some work in the modules tree
  2020-02-17 20:38 Stephen Rothwell
@ 2020-02-17 20:42 ` Jessica Yu
  0 siblings, 0 replies; 12+ messages in thread
From: Jessica Yu @ 2020-02-17 20:42 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

+++ Stephen Rothwell [18/02/20 07:38 +1100]:
>Hi all,
>
>Commit
>
>  b99931f169fe ("kernel: module: Replace zero-length array with flexible-array member")
>
>is missing a Signed-off-by from its committer.

Gah sorry, that's fixed now. 

Thanks!

Jessica

^ permalink raw reply	[flat|nested] 12+ messages in thread
* linux-next: Fixes tag needs some work in the modules tree
@ 2020-02-17 20:38 Stephen Rothwell
  2020-02-17 20:42 ` Jessica Yu
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2020-02-17 20:38 UTC (permalink / raw)
  To: Jessica Yu; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

Hi all,

Commit

  b99931f169fe ("kernel: module: Replace zero-length array with flexible-array member")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: linux-next: Fixes tag needs some work in the modules tree
  2019-04-30 22:10 Stephen Rothwell
  2019-04-30 22:13 ` Prarit Bhargava
@ 2019-05-01  8:03 ` Jessica Yu
  1 sibling, 0 replies; 12+ messages in thread
From: Jessica Yu @ 2019-05-01  8:03 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Prarit Bhargava

+++ Stephen Rothwell [01/05/19 08:10 +1000]:
>Hi all,
>
>In commit
>
>  7e470ea99bcd ("kernel/module: Reschedule while waiting for modules to finish loading")
>
>Fixes tag
>
>  Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
>
>has these problem(s):
>
>  - the "linux-next commit" is unexpected (and not really meaningful
>    once this is merged into Linus' tree)
>
>-- 
>Cheers,
>Stephen Rothwell

A fixed verison has been pushed out to modules-next.

Thanks!

Jessica

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: linux-next: Fixes tag needs some work in the modules tree
  2019-04-30 22:10 Stephen Rothwell
@ 2019-04-30 22:13 ` Prarit Bhargava
  2019-05-01  8:03 ` Jessica Yu
  1 sibling, 0 replies; 12+ messages in thread
From: Prarit Bhargava @ 2019-04-30 22:13 UTC (permalink / raw)
  To: Stephen Rothwell, Jessica Yu
  Cc: Linux Next Mailing List, Linux Kernel Mailing List



On 4/30/19 6:10 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   7e470ea99bcd ("kernel/module: Reschedule while waiting for modules to finish loading")
> 
> Fixes tag
> 
>   Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
> 
> has these problem(s):
> 
>   - the "linux-next commit" is unexpected (and not really meaningful
>     once this is merged into Linus' tree)
> 

Stephen, I will send out an updated patch now.

P.

^ permalink raw reply	[flat|nested] 12+ messages in thread
* linux-next: Fixes tag needs some work in the modules tree
@ 2019-04-30 22:10 Stephen Rothwell
  2019-04-30 22:13 ` Prarit Bhargava
  2019-05-01  8:03 ` Jessica Yu
  0 siblings, 2 replies; 12+ messages in thread
From: Stephen Rothwell @ 2019-04-30 22:10 UTC (permalink / raw)
  To: Jessica Yu
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Prarit Bhargava

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi all,

In commit

  7e470ea99bcd ("kernel/module: Reschedule while waiting for modules to finish loading")

Fixes tag

  Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")

has these problem(s):

  - the "linux-next commit" is unexpected (and not really meaningful
    once this is merged into Linus' tree)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-07-24 19:11 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 19:35 linux-next: Fixes tag needs some work in the modules tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2023-07-23 22:33 Stephen Rothwell
2023-07-24 19:11 ` Luis Chamberlain
2022-04-04 22:15 Stephen Rothwell
2022-04-05 15:45 ` Luis Chamberlain
2022-03-01  0:33 Stephen Rothwell
2022-03-01  0:43 ` Luis Chamberlain
2020-02-17 20:38 Stephen Rothwell
2020-02-17 20:42 ` Jessica Yu
2019-04-30 22:10 Stephen Rothwell
2019-04-30 22:13 ` Prarit Bhargava
2019-05-01  8:03 ` Jessica Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).